From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 8A1D81B107 for ; Tue, 23 Oct 2018 10:37:34 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0A28E21FF4; Tue, 23 Oct 2018 04:37:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 23 Oct 2018 04:37:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=rufjbb0Zh6QzDrgGcV/ukHeFW0D31VihyA+nDXkvkbA=; b=Y1czRxrNGbVr Qb979q9A97w2iuSsdH9Z70IdGYvVfLgyz+TnPKKa7fUnrhg09rukIyqoH6Imobx7 NyRpaa6166pBs4xvTcRYEh7S1xCyF2BrIgjP9Y359a9djGeRAaoZpVF/tBkZAHME yUidZbXr7iFDrH0i00r3dDBGUo+Uc6s= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=rufjbb0Zh6QzDrgGcV/ukHeFW0D31VihyA+nDXkvk bA=; b=zEDnkzpahX7LmLO5sgVQpa7XlXgRVOYXA6GP/tW8s1M6d6KAdKtaEx9kA eUwdGmSCh/qW9sA3aB0WaaZbPyd8hv/5z9CW2bjKX/0N+AKcPH6XXfLQKoychhx0 CeJsZwO0EdQ1LIWanCnOFzYf0TmxR/yHws5gwWKaps8hBNaQ+bAoxMIWeVrGqUsT DFi+dStpoOH6tJaAYVALdlVh654BX2DPR3BWdYkfEwLGs6fC3kaIIN+tLUn0u1RY cAHUcFipROYGCI0V168y43DF66hfp6RZhPYg3QCANprguaxU+Z2ShTMWgyzZxaR6 cwn5GjL/k0DibpHAHV5biAu9dow3g== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A304D102E4; Tue, 23 Oct 2018 04:37:32 -0400 (EDT) From: Thomas Monjalon To: Lewis Donzis Cc: dev@dpdk.org, "Wiles, Keith" Date: Tue, 23 Oct 2018 10:37:34 +0200 Message-ID: <1590899.CaVHfE2u3J@xps> In-Reply-To: References: <9DDD01EB-C8A2-40F1-AF77-EBFA1E96D595@perftech.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] Change ether_addr to avoid conflict X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Oct 2018 08:37:34 -0000 22/10/2018 17:06, Wiles, Keith: >=20 > > On Oct 21, 2018, at 8:39 AM, Lewis Donzis wrote: > >=20 > > Please consider changing =E2=80=9Cstruct ether_addr=E2=80=9D in rte_eth= er.h to =E2=80=9Cstruct rte_ether_addr=E2=80=9D, in order to avoid conflict= s with the same structure name /usr/include/net/ethernet.h. > >=20 > > This is kind of a pain for us since we would like to include ethernet.h= in order to get some other definitions, but we can=E2=80=99t because it co= nflicts with the same structure name in rte_ether.h. >=20 > I agree, but it will require a deprecation notice as a lot of code uses i= t. Yes, it is a very long standing issue. During the last technical board meeting, we discussed a plan to fix it: http://mails.dpdk.org/archives/dev/2018-October/116695.html