From: Archana Muniganti <marchana@marvell.com>
To: <marko.kovacevic@intel.com>, <roy.fan.zhang@intel.com>,
<akhil.goyal@nxp.com>
Cc: Archana Muniganti <marchana@marvell.com>, <anoobj@marvell.com>,
<pathreya@marvell.com>, <ayverma@marvell.com>,
<kkotamarthy@marvell.com>, <dev@dpdk.org>, <stable@dpdk.org>
Subject: [dpdk-dev] [PATCH 3/3] examples/fips_validation: fix overwrite of COUNT for TDES vectors
Date: Thu, 11 Jun 2020 19:14:17 +0530 [thread overview]
Message-ID: <1591883057-11008-3-git-send-email-marchana@marvell.com> (raw)
In-Reply-To: <1591883057-11008-1-git-send-email-marchana@marvell.com>
Application updates first line of each test vector with
COUNT = i(where i = 1,2,3..) assuming first line contains
COUNT string. But few of the TDES input test vectors don't
contain COUNT string and thus COUNT is getting overwritten on
other data.
Fixes: 527cbf3d5ee3 ("examples/fips_validation: support TDES parsing")
Signed-off-by: Archana Muniganti <marchana@marvell.com>
Signed-off-by: Kanaka Durga Kotamarthy <kkotamarthy@marvell.com>
---
examples/fips_validation/fips_validation.c | 8 ++++++++
examples/fips_validation/main.c | 5 ++++-
2 files changed, 12 insertions(+), 1 deletion(-)
diff --git a/examples/fips_validation/fips_validation.c b/examples/fips_validation/fips_validation.c
index 3aaec20..9bdf257 100644
--- a/examples/fips_validation/fips_validation.c
+++ b/examples/fips_validation/fips_validation.c
@@ -640,6 +640,14 @@
cb = &info.writeback_callbacks[0];
+ if (!(strstr(info.vec[0], cb->key))) {
+ fprintf(info.fp_wr, "%s%u\n", cb->key, count);
+ i = 0;
+ } else {
+ snprintf(info.vec[0], strlen(info.vec[0]) + 4, "%s%u", cb->key,
+ count);
+ i = 1;
+ }
snprintf(info.vec[0], strlen(info.vec[0]) + 4, "%s%u", cb->key, count);
for (i = 1; i < info.nb_vec_lines; i++) {
diff --git a/examples/fips_validation/main.c b/examples/fips_validation/main.c
index f9b2056..efd32a8 100644
--- a/examples/fips_validation/main.c
+++ b/examples/fips_validation/main.c
@@ -1070,7 +1070,10 @@ struct fips_test_ops {
int test_mode = info.interim_info.tdes_data.test_mode;
for (i = 0; i < TDES_EXTERN_ITER; i++) {
- if (i != 0)
+ if (i == 0) {
+ if (!(strstr(info.vec[0], "COUNT")))
+ fprintf(info.fp_wr, "%s%u\n", "COUNT = ", 0);
+ } else
update_info_vec(i);
fips_test_write_one_case();
--
1.8.3.1
next prev parent reply other threads:[~2020-06-11 13:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-11 13:44 [dpdk-dev] [PATCH 1/3] examples/fips_validation: fix TDES interim callback Archana Muniganti
2020-06-11 13:44 ` [dpdk-dev] [PATCH 2/3] examples/fips_validation: fix parsing of TDES vectors Archana Muniganti
2020-06-11 13:44 ` Archana Muniganti [this message]
2020-07-02 18:53 ` [dpdk-dev] [PATCH 1/3] examples/fips_validation: fix TDES interim callback Akhil Goyal
2020-07-12 23:39 ` Thomas Monjalon
2020-07-15 20:00 ` Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1591883057-11008-3-git-send-email-marchana@marvell.com \
--to=marchana@marvell.com \
--cc=akhil.goyal@nxp.com \
--cc=anoobj@marvell.com \
--cc=ayverma@marvell.com \
--cc=dev@dpdk.org \
--cc=kkotamarthy@marvell.com \
--cc=marko.kovacevic@intel.com \
--cc=pathreya@marvell.com \
--cc=roy.fan.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).