From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0036A0093; Mon, 15 Jun 2020 11:37:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 392DD4C7A; Mon, 15 Jun 2020 11:37:54 +0200 (CEST) Received: from new2-smtp.messagingengine.com (new2-smtp.messagingengine.com [66.111.4.224]) by dpdk.org (Postfix) with ESMTP id ABD002B94 for ; Mon, 15 Jun 2020 11:37:52 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailnew.nyi.internal (Postfix) with ESMTP id 0E7155800FA; Mon, 15 Jun 2020 05:37:52 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Mon, 15 Jun 2020 05:37:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= z5TkKtgdfNPzLtkwnQ+qNue5E6Vi6fIMwgbibOJDdKM=; b=q4aLhEOZjBWI+6UH atFRvWDTxLtqiCMC6tsiG3qPBsV3CL5BVAPPGiTum/iNWtv4naWnYSXEwOHO4wXX HkbmJHCEQt687iahZ3/sZsmZW0OAftRybMyYWQi/xWC1sE+GjIjt8ablirTCiw3t H9wRgybHwxaHDt0QmGZsElvTIBfUN39EwoWRWE0rjnRXnV8RL/X4FB2ucLpaB7xZ ObN6r0MJ5ja/8T/yaz/B83IYRblu+Skb1IauhJUOjEdXW965jZ50oev+SXm/K1Kk W6JvHjrJrSOW+hxMkMmpXpEDAMZHSV/nqdGEjiFoVpL6zYkHDPuokQ9RxlR92H89 YAUaTg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=z5TkKtgdfNPzLtkwnQ+qNue5E6Vi6fIMwgbibOJDd KM=; b=Fl7nTLdzFvHq0Ui7Bsgpak/2HmjH/l5nEzMBG5imBePYmR6K4m9wpkbGz idj9pyIu9KMjB8hnrFxp/laJEXE/yjPojSu8CK3/mv2KWZLL4IH+tHQeoVTrMvu5 vE6F5u9Ua2WlPIFST1mbQjP7vr3hhwcfjZfheSzSvh7zAS5WcrSm3wB78v/fU6ad wBbk6D3vuM8NYU5WFgxAK73kW9U9fOeKjMyYs/Hh8t79NlrYyroNdW5kDa5M172q a3M3e3Q/XyzgMzOM8K/u7UL3W8OJg/MiLLHnEdAv2R9VkCn6jNbp8AoRqz9s6IIM p0WgzTtZjdu1akiJlNuJzg1jTlFeQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudeikedgudejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id EC8913280060; Mon, 15 Jun 2020 05:37:49 -0400 (EDT) From: Thomas Monjalon To: Pallavi Kadam Cc: dev@dpdk.org, ranjit.menon@intel.com, dmitry.kozliuk@gmail.com, Narcisa.Vasile@microsoft.com, tbashar@mellanox.com, Harini.Ramakrishnan@microsoft.com, talshn@mellanox.com, fady@mellanox.com, ocardona@microsoft.com, Narcisa Ana Maria Vasile Date: Mon, 15 Jun 2020 11:37:48 +0200 Message-ID: <159222587.G9T3qyYgsE@thomas> In-Reply-To: <20200611201837.GA42520@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20200528231455.13636-1-pallavi.kadam@intel.com> <20200611195055.3024-1-pallavi.kadam@intel.com> <20200611201837.GA42520@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4] eal: fix warnings on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 11/06/2020 22:18, Narcisa Ana Maria Vasile: > On Thu, Jun 11, 2020 at 12:50:55PM -0700, Pallavi Kadam wrote: > > Fixed bunch of warnings when compiling using clang on Windows > > such as the use of an unsafe string function (strerror), > > [-Wunused-variable], [-Wunused-function] in eal_common_options.c > > [-Wunused-const-variable] in getopt.c and [-Wunused-parameter] > > in eal_common_thread.c. > > Also fixed warnings generated using Mingw: > > [-Werror=old-style-definition], [-Werror=cast-function-type] and > > [-Werror=attributes] > > > > v4 changes: > > Removed -Werror that was added on Windows in v3 > > Removed self 'Tested-by' line > > > > v3 changes: > > Fixed pthread warning > > Added -Werror on Windows > > Fixed MinGW warnings > > > > v2 changes: > > Excluded dirent.h file on Windows temporarily. > > (This file will stay on Windows for later use) > > > > Signed-off-by: Ranjit Menon > > Signed-off-by: Pallavi Kadam > > --- > Tested with clang, no warnings generated. > Tested-by: Narcisa Vasile > Acked-by: Narcisa Vasile Applied, thanks