From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: dev@dpdk.org
Cc: "Nicolás Pernas Maradei" <nico@emutex.com>
Subject: Re: [dpdk-dev] [PATCH] Fix librte_pmd_pcap driver double stop error
Date: Mon, 29 Sep 2014 15:21:18 +0200 [thread overview]
Message-ID: <1592464.PQabvuCgtP@xps13> (raw)
In-Reply-To: <1410380225-13751-1-git-send-email-nico@emutex.com>
2014-09-10 17:17, Nicolás Pernas Maradei:
> From: Nicolás Pernas Maradei <nico@emutex.com>
>
> librte_pmd_pcap driver was opening the pcap/interfaces only at init time and
> closing them only when the port was being stopped. This behaviour would cause
> problems (leading to segfault) if the user closed the port 2 times. The first
> time the pcap/interfaces would be normally closed but libpcap would throw an
> error causing a segfault if the closed pcaps/interfaces were closed again.
> This behaviour is solved by re-openning pcaps/interfaces when the port is
> started (only if these weren't open already for example at init time).
>
> Signed-off-by: Nicolás Pernas Maradei <nico@emutex.com>
> ---
> lib/librte_pmd_pcap/rte_eth_pcap.c | 254 +++++++++++++++++++++++++++++--------
> 1 file changed, 202 insertions(+), 52 deletions(-)
Someone to review this patch?
--
Thomas
next prev parent reply other threads:[~2014-09-29 13:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 20:17 Nicolás Pernas Maradei
2014-09-29 13:21 ` Thomas Monjalon [this message]
2014-09-29 14:24 ` Neil Horman
2014-10-04 18:14 ` Nicolás Pernas Maradei
2014-10-06 14:35 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1592464.PQabvuCgtP@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=nico@emutex.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).