From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 161E0235 for ; Tue, 29 May 2018 21:53:33 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 581B520F1D; Tue, 29 May 2018 15:53:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 29 May 2018 15:53:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=fnbkvuLGBT8n+rMZ4G4wwJ0u2/ 3110gx0lGU/eZimN8=; b=Ffsn7lbUou5cEAcbcIdzWNB+24+UYYuu705DgolpTA S1K2qU6ciQp4S/zgvQHTgfm9WyI+41pQJOHzyLLgpfX+BrSbg7i4p5k2e2zwPA+M PaATIISWU0pQVepNDhD8j3KqSReiNOJkpgdGU8JU0yKjK9mEbqNznlnI0W63Vs1d o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=fnbkvu LGBT8n+rMZ4G4wwJ0u2/3110gx0lGU/eZimN8=; b=hhgbFKQT9m80gveaVrgfy9 VDjYlshOAFMwi1EjuePVDQJG4L8C+Jc6jijB1t7yQji/RK6Ht0jdi0AcYHuH1cvu s8f5lz4dTGCPXkQiUKlS2kYLe4+EEa/nosr5wUjdUlCrMZKeFtsMCvkS0W2ODaCG kvpnqF4b7+2NLMRAV88YDeusorTaaQdthDB9EQMrviGi0RRSy6DVaCxYNYV9Y49J LP/9Uo2qaQth+V354ACJBCHU06DiNEQAt65Gs5BBe2//OAKzg2fuTRwW1Knvm6bR ThryI65H0TxfnsWYhOntlX35FDo4tfPep4KpNhE9UXywX31hkIWmkVfhhbE54nNA == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 956D5E4BF6; Tue, 29 May 2018 15:53:32 -0400 (EDT) From: Thomas Monjalon To: Gavin Hu Cc: Bruce Richardson , "dev@dpdk.org" Date: Tue, 29 May 2018 21:53:30 +0200 Message-ID: <1593317.cps1H5Vuk1@xps> In-Reply-To: References: <1527133127-29407-1-git-send-email-gavin.hu@arm.com> <20180529150008.GA25480@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/2] mk: fix cross build errors X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 May 2018 19:53:34 -0000 29/05/2018 18:20, Gavin Hu: > > > -----Original Message----- > > From: Bruce Richardson > > Sent: Tuesday, May 29, 2018 11:00 PM > > To: Thomas Monjalon > > Cc: Gavin Hu ; dev@dpdk.org > > Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2 1/2] mk: fix cross build > > errors > > > > On Tue, May 29, 2018 at 04:45:55PM +0200, Thomas Monjalon wrote: > > > 28/05/2018 15:24, Bruce Richardson: > > > > Would a simpler solution for this not be to put "-Wno-implicit- > > fallthrough" > > > > for pmdinfogen? GCC will not give a warning for an unrecognised "-Wno" > > > > flag when compiling, unless there are other errors. This means we > > > > can just use the flag without bothering with version checks. > > > > > > No, it does not work. > > > I have this error with clang 5.0.1: > > > error: unknown warning option '-Wno-format-truncation' > > > > > Yes, you still need to check for GCC to use the flag, just not for a specific > > version of GCC. > > > > /Bruce > Hi Thomas, did you meet this clang error when you applied my patch(which version?) or your own one? > @Bruce and Thomas, Could you review my v5 patch? Thanks! I've already replied to your v5. The error is seen with your v5.