From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 43A882C00
 for <dev@dpdk.org>; Wed, 14 Jun 2017 23:22:24 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id B6FC120BA7;
 Wed, 14 Jun 2017 17:22:23 -0400 (EDT)
Received: from frontend2 ([10.202.2.161])
 by compute1.internal (MEProxy); Wed, 14 Jun 2017 17:22:23 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=A3eI48VhQu3eNgA
 NzNSOk1naqgiiIkztuqKs8l0ZX7c=; b=fOG4arOQX0gHXba6MH5DmlcSR5QW68R
 XJEJU8G5UhggxwWwY+37eTGZdSjA1CqRWxN/mhxjfq0Uy7sWmsIj0rS/ivexNkCl
 +E6j7I0XM2y3Jots0ZLVy/ZmnTflYyLW2te8uu+8CRCM0bXJ5bvUPbAdjIwDt+N5
 OiTAMDIBT254=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
 fm1; bh=A3eI48VhQu3eNgANzNSOk1naqgiiIkztuqKs8l0ZX7c=; b=J/2kAMuN
 R411z6ZKc+lGCFHTy5RbPQQ4bRq5EUda8nJLvaubke4FD8fKA7bldzTnVR/aU5rl
 VQs9tefSA5tEijvJnGh79tLFB3KEx7N0qrIQE2E87r1pazCGLPqmtU0aRBsmgv+5
 zR92CwQNa/1zpwnulhd2E3Q2PMlWztRQ6xa/WDNF3j4h4XVU35O5ZHlx/T49Zhx9
 M5g3ttQCWCdaP8X7Rq13Y1kVhIS9gHuahWsrVAW5Gfu3pPMTz4u6Q2g8ITY/LXYt
 2/6uZDnQtP0VYnU9JKMXs0xBJQcZbPR7atmQOr5yJ1hVTkNpptCfvnOd2MWZoyX2
 Cafmig7/9Kx7kQ==
X-ME-Sender: <xms:D6lBWS94qg4dOVdKhKAxpbMkn5fkn1vV0ctT1Zmk3qZddYhRUe0Omg>
X-Sasl-enc: mWHV3rpHgUeZ//xL5NR+HbPL/DEatXWEL3XuOOamq1Sm 1497475343
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 44B0C24766;
 Wed, 14 Jun 2017 17:22:23 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: bernard.iremonger@intel.com
Cc: dev@dpdk.org
Date: Wed, 14 Jun 2017 23:22:22 +0200
Message-ID: <15933671.otTXsCeEv9@xps>
In-Reply-To: <1497280691-18641-2-git-send-email-bernard.iremonger@intel.com>
References: <1495191794-9112-1-git-send-email-bernard.iremonger@intel.com>
 <1497280691-18641-2-git-send-email-bernard.iremonger@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v2 1/4] ethdev: modify callback process API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Jun 2017 21:22:24 -0000

Hi,

12/06/2017 17:18, Bernard Iremonger:
> Change the rte_eth_dev_callback_process function to return int,
> and add a void *ret_param parameter.

You should squash tests and examples changes in this change to avoid
breaking compilation.
Doc patch can also be squashed.

> --- a/lib/librte_ether/rte_ether_version.map
> +++ b/lib/librte_ether/rte_ether_version.map
> +DPDK_17.08 {
> +	global:
> +
> +	_rte_eth_dev_callback_process;
> +
> +} DPDK_17.05;

You should remove the original function from 2.2 ABI block.