DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Nirmoy Das <ndas@suse.de>
Cc: dev@dpdk.org, "Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [dpdk-dev] [PATCH] app/testpmd: Fix typos
Date: Fri, 10 Mar 2017 14:14:08 +0100	[thread overview]
Message-ID: <1593411.rPLBrTQPi8@xps13> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE2026D95C1@IRSMSX103.ger.corp.intel.com>

2017-02-28 17:20, Mcnamara, John:
> > fixes trivial typos in app/test-pmd/cmdline.c, app/test-pmd/icmpecho.c,
> > app/test-pmd/testpmd.c
> > 
> > Signed-off-by: Nirmoy Das <ndas@suse.de>
> 
> 
> Hi Nirmoy,
> 
> Thanks for that.
> 
> Just a small heads-up since this is your first patch. The subject line should
> be lowercase (apart from known abbreviations) and there is no need to list
> the files in the body since git will record that anyway. Have a look at
> the contribution guidelines for some more pointers:
> 
> http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-subject-line
> 
> Apart from that, thanks for the patch.
> 
> Acked-by: John McNamara <john.mcnamara@intel.com>

Applied, thanks

Nirmoy, we are looking for reviewers with a good english reading ;)

      reply	other threads:[~2017-03-10 13:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-27 19:23 Nirmoy Das
2017-02-28 17:20 ` Mcnamara, John
2017-03-10 13:14   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1593411.rPLBrTQPi8@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    --cc=ndas@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).