From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f51.google.com (mail-wm0-f51.google.com [74.125.82.51]) by dpdk.org (Postfix) with ESMTP id 4E0F82BA1 for ; Wed, 9 Mar 2016 10:50:35 +0100 (CET) Received: by mail-wm0-f51.google.com with SMTP id n186so169664330wmn.1 for ; Wed, 09 Mar 2016 01:50:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=oB+Omon1m0TJI4xkOk5kAdDeULpDjLH0KAdMqIJsex0=; b=QsrvOUOa8I13Wad1wiz/dDBDzrHnzlrSk410cfAObu8HWIuUQF+zv7gMmknWAED31I pXhw5U3P6NFfFTrFLuhFbwO1JLK7c3wyBJEJ1p1ZRH+Zu9+gj1M4aV+BftdJWn0Is5rE sVXZW1Xy9NTJ+SPjoq6BqNOw0nU6dvJ0iKkK6eAg+yamSKb8aSDZ52ut9XzpUr6MXcX4 6fLJjBpNKlkd770vN9x/tNk/mkBgRwp+R8M2vOsT6ml87FQ+7m39PoDKhGuzLsQmz26z k5wvhW8wd0UuRWabS+Y6z/lemgMcOE6UrPMgFPl0t9uysbaRA+rMWgrK/G0140cl4Cn9 u7Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=oB+Omon1m0TJI4xkOk5kAdDeULpDjLH0KAdMqIJsex0=; b=mN0w0Vzgp0osLPTj/ksq16b+OXYJA6Obf4QkmOwk4gGc87GnEVbUC0w1JSBneOjQgi sMq8DhPfHu6AfwR/DJ3tkgiNli6LyDlLFI7LUecNYy5QXo/Y08w4DfAk2/+eRALEhH9U 6prxIQC7AUcQ9gbNnyo2hYux/YacpkTCsb2WAsYw7gR7N307Kmg1zvky9u6T7w2MVwr9 6td44h0bOJLA389Ah244itMRRdsZlDo62VTr6f+jrjq7emKVgbdmLWGJfs+huM+pU/mg C+xlXFNRwKR0TCspec/kdwUJ0lr0ltqXdm43h0/dTywaqT9WH0+ESbSiy2Ut/LCAtbE6 9B0g== X-Gm-Message-State: AD7BkJLiw35LI7OIq6EDryydYhuMGKS6AjN6cDeWx4foN8PXmZi7FSBusWZQUt7AdQboMf6F X-Received: by 10.28.6.139 with SMTP id 133mr25255981wmg.84.1457517035157; Wed, 09 Mar 2016 01:50:35 -0800 (PST) Received: from xps13.localnet (171.36.101.84.rev.sfr.net. [84.101.36.171]) by smtp.gmail.com with ESMTPSA id c128sm22875629wma.11.2016.03.09.01.50.34 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 09 Mar 2016 01:50:34 -0800 (PST) From: Thomas Monjalon To: Wenzhuo Lu Date: Wed, 09 Mar 2016 10:48:55 +0100 Message-ID: <1593514.bEiGrs9mO2@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1457494514-5862-2-git-send-email-wenzhuo.lu@intel.com> References: <1452496044-17524-1-git-send-email-wenzhuo.lu@intel.com> <1457494514-5862-1-git-send-email-wenzhuo.lu@intel.com> <1457494514-5862-2-git-send-email-wenzhuo.lu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v8 1/5] lib/librte_ether: change function name of tunnel port config X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Mar 2016 09:50:35 -0000 2016-03-09 11:35, Wenzhuo Lu: > + uint16_t udp_port; /**< UDP port used for the tunnel. */ > + uint8_t prot_type; /**< Tunnel type. */ Is 42 a valid tunnel type? Please reference where to find the constants. Think as a user who won't read your datasheet. [...] > /** > - * Add UDP tunneling port of an Ethernet device for filtering a specific > - * tunneling packet by UDP port number. > + * Add UDP tunneling port for a specific type of tunnel. > + * The packets with this UDP port will be parsed as this type of tunnel. We progress. What will be parsed? What will be the action? checksum? decapsulation? [...] > int > +rte_eth_dev_udp_tunnel_port_add(uint8_t port_id, > + struct rte_eth_udp_tunnel *tunnel_udp); > +/* Below is deprecated. Replaced by rte_eth_dev_udp_tunnel_port_add. */ > +int > rte_eth_dev_udp_tunnel_add(uint8_t port_id, > struct rte_eth_udp_tunnel *tunnel_udp); Better. Please make a doxygen comment with @see. We still need a __rte_deprecated attribute on the function. > --- a/lib/librte_ether/rte_ether_version.map > +++ b/lib/librte_ether/rte_ether_version.map > @@ -117,3 +117,10 @@ DPDK_2.2 { > > local: *; > }; > + > +DPDK_2.3 { > + global: > + > + rte_eth_dev_udp_tunnel_port_add; > + rte_eth_dev_udp_tunnel_port_delete; > +}DPDK_2.2; Please rename 2.3 to 16.04.