From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 858AAA046B for ; Wed, 26 Jun 2019 16:51:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 135DE1E25; Wed, 26 Jun 2019 16:51:36 +0200 (CEST) Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id AB67B1E20 for ; Wed, 26 Jun 2019 16:51:33 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1EA2521B10; Wed, 26 Jun 2019 10:51:33 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 26 Jun 2019 10:51:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=qfuU1p/EC9rG+IqbunMfaxphkkm6r9F9br1oD6HeAjg=; b=ip829eQHIxwK TzaLVcAV6cDfn8sWjfjHEVSDqhSYXbcT0AZ8dnPf/4pwz5TT9vq7HmR7b9D1kMtk n4P6/wj9MQS2c1kdUsRNbXNJhXejSh4M1SLDxWj9XEkzlYAI8EEhWV3KkbP4eHZp Z5m9oMny1qDPNGMwTDE5TjRVG4GFbVU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=qfuU1p/EC9rG+IqbunMfaxphkkm6r9F9br1oD6HeA jg=; b=mDRsUPXa0oPGqSkPpbWBKB+D275ZdLYnJ7EoMlM+JI2Eb2Qur0WECRp6l 4Cr+qmVv+uPHZ29d+cb65ojc94Y0FUVac679kMSZIjt4LmHWE29m/hn9G2YYYMoK DTbEd4lqO4f7LeVSXPhEbLzq6GstdKIYiHv6A+sGvIOu2nDbgHSB0CteZaaqOIzV IwU7HGBMin7bfsoxlLG61G7CkDHsh2ZSbO8VVkN14W9nwnJwAiC6zjjLvxM4dseL xtcQQj1g0Cv7cSa7g4xkcA6tFVj/3jgukgmN1x5MN5cHqYUkw79n/MtuoO1a6esp FXc1n13aijxOBUeXDq9Osus+VCj+A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudeigdekfecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucffoh hmrghinhepughpughkrdhorhhgnecukfhppeejjedrudefgedrvddtfedrudekgeenucfr rghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenuc evlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 93D8B380079; Wed, 26 Jun 2019 10:51:31 -0400 (EDT) From: Thomas Monjalon To: "Smoczynski, MarcinX" Cc: dev@dpdk.org, "Ananyev, Konstantin" , "Richardson, Bruce" , "adrien.mazarguil@6wind.com" Date: Wed, 26 Jun 2019 16:51:30 +0200 Message-ID: <15935766.HosnGNfXbe@xps> In-Reply-To: <2601191342CEEE43887BDE71AB9772580161FE75AF@irsmsx105.ger.corp.intel.com> References: <20190514140416.4192-1-marcinx.smoczynski@intel.com> <20190514140416.4192-2-marcinx.smoczynski@intel.com> <2601191342CEEE43887BDE71AB9772580161FE75AF@irsmsx105.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/1] build: enable BSD features visibility for FreeBSD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > When a component uses either XOPEN_SOURCE or POSIX_C_SOURCE macro > > explicitly in its build recipe, it restricts visibility of a non POSIX > > features subset, such as IANA protocol numbers (IPPROTO_* macros). > > Non standard features are enabled by default for DPDK both for Linux > > thanks to _GNU_SOURCE and for FreeBSD thanks to __BSD_VISIBLE. However > > using XOPEN_SOURCE or POSIX_(C_)SOURCE in a component causes > > __BSD_VISIBLE to be defined to 0 for FreeBSD, causing different feature > > sets visibility for Linux and FreeBSD. It restricts from using IPPROTO > > macros in public headers, such as rte_ip.h, despite the fact they are > > already widely used in sources. > > > > Add __BSD_VISIBLE macro specified unconditionally for FreeBSD targets > > which enforces feature sets visibility unification between Linux and > > FreeBSD. > > > > Add single -D_GNU_SOURCE to config/meson.build as a project argument > > instead of adding separate directive for each project subtree. > > > > This patch solves the problem of build breaks for [1] on FreeBSD [2] > > following the discussion [3]. > > > > [1] https://mails.dpdk.org/archives/dev/2019-May/131885.html > > [2] http://mails.dpdk.org/archives/test-report/2019-May/082263.html > > [3] https://mails.dpdk.org/archives/dev/2019-May/132110.html > > > > Signed-off-by: Marcin Smoczynski > > Acked-by: Konstantin Ananyev Applied, thanks