From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id ADB1B2986; Thu, 2 May 2019 10:10:40 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DE6A424394; Thu, 2 May 2019 04:10:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 02 May 2019 04:10:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=aZXpgvVxUGE2f6fzppiggI6+zw/qF6EArgXSlcLuWWE=; b=Sov2+hjJQeQj JBBhXlaF3oZthj1cm3FqrTj8Qv58QogtSnq2j0TIJIusUjY9c9cnGvtE/aLFgDiy l3j35c8xn7Tw4jUcGJZsXhPd8YnWWj7ObVb5YTRaJSLNNO0eBV4/BhQp+zmUYo2/ /2BoWV1i0+RWp91zWPEq4y+E2l8uPx4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=aZXpgvVxUGE2f6fzppiggI6+zw/qF6EArgXSlcLuW WE=; b=Tn7/Spu1bvPCWdb+62HKCWXDEiLYsyP4Ub4zJidYF2RSeMqOguRI0/v/4 ysqjG6+jvP3QDu/3KqrPFULoGk+PtQH4CBRw6fc3fRvpNiba//fG+MI0HTWkQF/c GfWi462wbb1NSidvt3bB9keiprVqjDQxiDfBKVD2qIAxEqtgXLDrsqOPkYmGyy5S XOeSfPzfdwcxRrig/CFtDXnuNFtyM3LHOzUZpJs6MEvrjZDl2qpGw/aAIAxOBoSW rkm2ZJbdJHnhw9/ThMpb0e2ddfsTAE526aXFJJN4n+ESL5T58jlQYBh4tSX9S4eY iBuA7f4no2RQOE24wXidDlxAx9qWg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrieelgddtudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 61BB9E4382; Thu, 2 May 2019 04:10:37 -0400 (EDT) From: Thomas Monjalon To: Yongseok Koh Cc: ferruh.yigit@intel.com, anatoly.burakov@intel.com, shahafs@mellanox.com, dev@dpdk.org, stable@dpdk.org Date: Thu, 02 May 2019 10:10:35 +0200 Message-ID: <1593707.DseZV921jT@xps> In-Reply-To: <20190502074357.32031-1-yskoh@mellanox.com> References: <20190502014436.40545-1-yskoh@mellanox.com> <20190502074357.32031-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 1/2] bus/pci: add Mellanox kernel driver type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 May 2019 08:10:40 -0000 02/05/2019 09:43, Yongseok Koh: > Mellanox mlx4/5 PMD doesn't need to be detached from kernel driver and > attached to VFIO/UIO. Control path still goes through the existing kernel > drivers, which is mlx4_core/mlx5_core. The real change here is to handle RTE_PCI_DRV_IOVA_AS_VA with Mellanox kernel drivers. It think it should be explained in the commit log, because there is no other reason for not using RTE_KDRV_UNKNOWN. > @@ -568,7 +571,8 @@ pci_one_device_has_iova_va(void) > FOREACH_DRIVER_ON_PCIBUS(drv) { > if (drv && drv->drv_flags & RTE_PCI_DRV_IOVA_AS_VA) { > FOREACH_DEVICE_ON_PCIBUS(dev) { > - if (dev->kdrv == RTE_KDRV_VFIO && > + if ((dev->kdrv == RTE_KDRV_VFIO || > + dev->kdrv == RTE_KDRV_NIC_MLX) && > rte_pci_match(drv, dev)) > return 1; > } From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 86902A0AC5 for ; Thu, 2 May 2019 10:10:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4D86A29CB; Thu, 2 May 2019 10:10:42 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id ADB1B2986; Thu, 2 May 2019 10:10:40 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id DE6A424394; Thu, 2 May 2019 04:10:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Thu, 02 May 2019 04:10:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=aZXpgvVxUGE2f6fzppiggI6+zw/qF6EArgXSlcLuWWE=; b=Sov2+hjJQeQj JBBhXlaF3oZthj1cm3FqrTj8Qv58QogtSnq2j0TIJIusUjY9c9cnGvtE/aLFgDiy l3j35c8xn7Tw4jUcGJZsXhPd8YnWWj7ObVb5YTRaJSLNNO0eBV4/BhQp+zmUYo2/ /2BoWV1i0+RWp91zWPEq4y+E2l8uPx4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=aZXpgvVxUGE2f6fzppiggI6+zw/qF6EArgXSlcLuW WE=; b=Tn7/Spu1bvPCWdb+62HKCWXDEiLYsyP4Ub4zJidYF2RSeMqOguRI0/v/4 ysqjG6+jvP3QDu/3KqrPFULoGk+PtQH4CBRw6fc3fRvpNiba//fG+MI0HTWkQF/c GfWi462wbb1NSidvt3bB9keiprVqjDQxiDfBKVD2qIAxEqtgXLDrsqOPkYmGyy5S XOeSfPzfdwcxRrig/CFtDXnuNFtyM3LHOzUZpJs6MEvrjZDl2qpGw/aAIAxOBoSW rkm2ZJbdJHnhw9/ThMpb0e2ddfsTAE526aXFJJN4n+ESL5T58jlQYBh4tSX9S4eY iBuA7f4no2RQOE24wXidDlxAx9qWg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrieelgddtudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhho mhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 61BB9E4382; Thu, 2 May 2019 04:10:37 -0400 (EDT) From: Thomas Monjalon To: Yongseok Koh Cc: ferruh.yigit@intel.com, anatoly.burakov@intel.com, shahafs@mellanox.com, dev@dpdk.org, stable@dpdk.org Date: Thu, 02 May 2019 10:10:35 +0200 Message-ID: <1593707.DseZV921jT@xps> In-Reply-To: <20190502074357.32031-1-yskoh@mellanox.com> References: <20190502014436.40545-1-yskoh@mellanox.com> <20190502074357.32031-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 1/2] bus/pci: add Mellanox kernel driver type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190502081035.Z7ULVCjghqoqk7AObmQtACEyBol0Bky2R1nrvp2IQAA@z> 02/05/2019 09:43, Yongseok Koh: > Mellanox mlx4/5 PMD doesn't need to be detached from kernel driver and > attached to VFIO/UIO. Control path still goes through the existing kernel > drivers, which is mlx4_core/mlx5_core. The real change here is to handle RTE_PCI_DRV_IOVA_AS_VA with Mellanox kernel drivers. It think it should be explained in the commit log, because there is no other reason for not using RTE_KDRV_UNKNOWN. > @@ -568,7 +571,8 @@ pci_one_device_has_iova_va(void) > FOREACH_DRIVER_ON_PCIBUS(drv) { > if (drv && drv->drv_flags & RTE_PCI_DRV_IOVA_AS_VA) { > FOREACH_DEVICE_ON_PCIBUS(dev) { > - if (dev->kdrv == RTE_KDRV_VFIO && > + if ((dev->kdrv == RTE_KDRV_VFIO || > + dev->kdrv == RTE_KDRV_NIC_MLX) && > rte_pci_match(drv, dev)) > return 1; > }