From: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
To: dev@dpdk.org
Cc: matan@mellanox.com, rasland@mellanox.com, stable@dpdk.org
Subject: [dpdk-dev] [PATCH] common/mlx5: fix physical port name pattern recognition
Date: Wed, 8 Jul 2020 20:52:16 +0000 [thread overview]
Message-ID: <1594241536-5300-1-git-send-email-viacheslavo@mellanox.com> (raw)
This patch makes the Infiniband device physical port name
recognition more strict. Currently mlx5 PMD might recognize
the names like "pf0sf0" erroneously as "pf0" and the wrong
device type (host PF representor) is reported.
The names like "pf0sf0" belong to PCI subfunctions which
is currently not supported by mlx5 PMD and this false
recognition must be eliminated.
Fixes: 420bbdae89f2 ("net/mlx5: fix host physical function representor naming")
Cc: stable@dpdk.org
Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
---
drivers/common/mlx5/linux/mlx5_common_os.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/common/mlx5/linux/mlx5_common_os.c b/drivers/common/mlx5/linux/mlx5_common_os.c
index e74aa89..7bb3ba6 100644
--- a/drivers/common/mlx5/linux/mlx5_common_os.c
+++ b/drivers/common/mlx5/linux/mlx5_common_os.c
@@ -89,7 +89,7 @@
mlx5_translate_port_name(const char *port_name_in,
struct mlx5_switch_info *port_info_out)
{
- char pf_c1, pf_c2, vf_c1, vf_c2;
+ char pf_c1, pf_c2, vf_c1, vf_c2, eol;
char *end;
int sc_items;
@@ -97,9 +97,9 @@
* Check for port-name as a string of the form pf0vf0
* (support kernel ver >= 5.0 or OFED ver >= 4.6).
*/
- sc_items = sscanf(port_name_in, "%c%c%d%c%c%d",
+ sc_items = sscanf(port_name_in, "%c%c%d%c%c%d%c",
&pf_c1, &pf_c2, &port_info_out->pf_num,
- &vf_c1, &vf_c2, &port_info_out->port_name);
+ &vf_c1, &vf_c2, &port_info_out->port_name, &eol);
if (sc_items == 6 &&
pf_c1 == 'p' && pf_c2 == 'f' &&
vf_c1 == 'v' && vf_c2 == 'f') {
@@ -110,8 +110,8 @@
* Check for port-name as a string of the form p0
* (support kernel ver >= 5.0, or OFED ver >= 4.6).
*/
- sc_items = sscanf(port_name_in, "%c%d",
- &pf_c1, &port_info_out->port_name);
+ sc_items = sscanf(port_name_in, "%c%d%c",
+ &pf_c1, &port_info_out->port_name, &eol);
if (sc_items == 2 && pf_c1 == 'p') {
port_info_out->name_type = MLX5_PHYS_PORT_NAME_TYPE_UPLINK;
return;
@@ -120,8 +120,8 @@
* Check for port-name as a string of the form pf0
* (support kernel ver >= 5.7 for HPF representor on BF).
*/
- sc_items = sscanf(port_name_in, "%c%c%d",
- &pf_c1, &pf_c2, &port_info_out->pf_num);
+ sc_items = sscanf(port_name_in, "%c%c%d%c",
+ &pf_c1, &pf_c2, &port_info_out->pf_num, &eol);
if (sc_items == 3 && pf_c1 == 'p' && pf_c2 == 'f') {
port_info_out->port_name = -1;
port_info_out->name_type = MLX5_PHYS_PORT_NAME_TYPE_PFHPF;
--
1.8.3.1
next reply other threads:[~2020-07-08 20:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 20:52 Viacheslav Ovsiienko [this message]
2020-07-09 12:01 ` Raslan Darawsheh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1594241536-5300-1-git-send-email-viacheslavo@mellanox.com \
--to=viacheslavo@mellanox.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=rasland@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).