From: Simei Su <simei.su@intel.com>
To: qi.z.zhang@intel.com
Cc: dev@dpdk.org, jia.guo@intel.com, Simei Su <simei.su@intel.com>
Subject: [dpdk-dev] [PATCH] net/ice: fix invalid RSS type
Date: Thu, 9 Jul 2020 14:26:34 +0800 [thread overview]
Message-ID: <1594275994-318254-1-git-send-email-simei.su@intel.com> (raw)
When a RSS rule with only RSS type modifirer L2/L3/L4 SRC/DST_ONLY,
it should return failure. This patch adds invalid RSS type check.
Fixes: dfaedcf20170 ("net/ice: refactor PF hash flow")
Signed-off-by: Simei Su <simei.su@intel.com>
---
drivers/net/ice/ice_hash.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c
index cbd6116..777bd6d 100644
--- a/drivers/net/ice/ice_hash.c
+++ b/drivers/net/ice/ice_hash.c
@@ -721,6 +721,11 @@ struct ice_hash_match_type ice_hash_type_list[] = {
* of the same level.
*/
rss_type = rte_eth_rss_hf_refine(rss_type);
+ /* Check if only L2/L3/L4 src/dst-only exists. */
+ if ((rss_type & 0xffffffff) == 0)
+ return rte_flow_error_set(error, ENOTSUP,
+ RTE_FLOW_ERROR_TYPE_ACTION, action,
+ "rss type with only L2/L3/L4 src/dst only is invalid");
combine_type = ETH_RSS_L2_SRC_ONLY |
ETH_RSS_L2_DST_ONLY |
--
1.8.3.1
next reply other threads:[~2020-07-09 6:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 6:26 Simei Su [this message]
2020-07-09 6:46 ` Zhang, Qi Z
2020-07-09 7:32 ` Su, Simei
2020-07-09 7:50 ` [dpdk-dev] [PATCH v2] " Simei Su
2020-07-11 14:01 ` [dpdk-dev] [PATCH v3] " Simei Su
2020-07-15 10:25 ` [dpdk-dev] [PATCH v4] " Simei Su
2020-07-15 14:13 ` Zhang, Qi Z
2020-07-16 3:01 ` Su, Simei
2020-07-16 3:24 ` [dpdk-dev] [PATCH v5] " Simei Su
2020-07-16 3:33 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1594275994-318254-1-git-send-email-simei.su@intel.com \
--to=simei.su@intel.com \
--cc=dev@dpdk.org \
--cc=jia.guo@intel.com \
--cc=qi.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).