DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/ice: fix invalid RSS type
@ 2020-07-09  6:26 Simei Su
  2020-07-09  6:46 ` Zhang, Qi Z
  2020-07-09  7:50 ` [dpdk-dev] [PATCH v2] " Simei Su
  0 siblings, 2 replies; 10+ messages in thread
From: Simei Su @ 2020-07-09  6:26 UTC (permalink / raw)
  To: qi.z.zhang; +Cc: dev, jia.guo, Simei Su

When a RSS rule with only RSS type modifirer L2/L3/L4 SRC/DST_ONLY,
it should return failure. This patch adds invalid RSS type check.

Fixes: dfaedcf20170 ("net/ice: refactor PF hash flow")

Signed-off-by: Simei Su <simei.su@intel.com>
---
 drivers/net/ice/ice_hash.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/ice/ice_hash.c b/drivers/net/ice/ice_hash.c
index cbd6116..777bd6d 100644
--- a/drivers/net/ice/ice_hash.c
+++ b/drivers/net/ice/ice_hash.c
@@ -721,6 +721,11 @@ struct ice_hash_match_type ice_hash_type_list[] = {
 			 * of the same level.
 			 */
 			rss_type = rte_eth_rss_hf_refine(rss_type);
+			/* Check if only L2/L3/L4 src/dst-only exists. */
+			if ((rss_type & 0xffffffff) == 0)
+				return rte_flow_error_set(error, ENOTSUP,
+					RTE_FLOW_ERROR_TYPE_ACTION, action,
+					"rss type with only L2/L3/L4 src/dst only is invalid");
 
 			combine_type = ETH_RSS_L2_SRC_ONLY |
 					ETH_RSS_L2_DST_ONLY |
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2020-07-16  3:33 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-09  6:26 [dpdk-dev] [PATCH] net/ice: fix invalid RSS type Simei Su
2020-07-09  6:46 ` Zhang, Qi Z
2020-07-09  7:32   ` Su, Simei
2020-07-09  7:50 ` [dpdk-dev] [PATCH v2] " Simei Su
2020-07-11 14:01   ` [dpdk-dev] [PATCH v3] " Simei Su
2020-07-15 10:25     ` [dpdk-dev] [PATCH v4] " Simei Su
2020-07-15 14:13       ` Zhang, Qi Z
2020-07-16  3:01         ` Su, Simei
2020-07-16  3:24       ` [dpdk-dev] [PATCH v5] " Simei Su
2020-07-16  3:33         ` Zhang, Qi Z

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git