From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42A00A052B; Wed, 29 Jul 2020 16:29:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1BCEE10A3; Wed, 29 Jul 2020 16:29:30 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140054.outbound.protection.outlook.com [40.107.14.54]) by dpdk.org (Postfix) with ESMTP id 311A2A69; Wed, 29 Jul 2020 16:29:29 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bapzeZ/ua0dDkh4b4EHvGtw0houbJnBvra4BHkGhA1D+u3eaAVXITznBjQ1p1Ej8A2q4y8ERLnt2vCcDeePfNESSh1waMywFNrX1PSb+QGk2coF3n4jhXNAfKN6x1Hp0WAq9nb1ZSkVIB2noJydt0jVGtiSklvODd0ZQ343fRPGUoQY8hJ5PPaeWuBj69hNuOtGftDOqRd6MS2Bg3uswJTE8tTYZd5ZUtdI304/E2CPGmk/q3CouaviBc8ediXrEWTG8jxCeTBURSCoa4nKQ8b5+rA5QEISlVXIsJ6ZWTYEdptnaSC6kGwH0P8k+5AQU8vQhX5d+5BaRB0rK77tPaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dLtd85mvlTK8/bTMi+SxrwULenf7TglnLeeVTowE8NY=; b=S/K5KUQnWcoh1nvR5u78fyn/Q3uMz5nYgrPhzXh58EhvEeF2VnGDdL1Th9uzLIZ7n7UT9iRUSAkP8Nj1go7+tJUnhwxBhnrYspOq5hyBy4Nw15GZ4lUFMJ9pE3n8U5d7NffDsU6yuoxHd29I6dnx7kbKxEBVf90WQ8Q8l0rJ4ScNptJivoglZus9T+EcTWm9Oe8aOtpEcMBoSidymsy15ZayhEdaTwg6h4goBNeHh0xgG5US80TOi32YHzKavEvwDtJ1LPlbbyYqE6Z2oFW0WqUO2ZHARJ1bBheoCVPxFpwx2qr6GG12rV7Ttwtkn8Nj4iSrMRV8AHci3jTq2tkz+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com; dkim=pass header.d=mellanox.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dLtd85mvlTK8/bTMi+SxrwULenf7TglnLeeVTowE8NY=; b=M9YjYNASpWJq+tOKYRLKars9ec8OxA6X+OqZIZ37GZJqLjFMGxKBSAsKovl0/fti3bUKiww9CutHqQUIfPwjjrsnrR857tK4WCWx1a6pfurj9Sn0HLFXWr5wx0exOPZ5v7o+1xyQXO9obE1Vx46sK72A7neFrVVg1MWHt1cuzBU= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=mellanox.com; Received: from AM0PR0502MB3874.eurprd05.prod.outlook.com (2603:10a6:208:1a::29) by AM0PR05MB5859.eurprd05.prod.outlook.com (2603:10a6:208:124::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.17; Wed, 29 Jul 2020 14:29:27 +0000 Received: from AM0PR0502MB3874.eurprd05.prod.outlook.com ([fe80::95cf:cfc1:b5da:314e]) by AM0PR0502MB3874.eurprd05.prod.outlook.com ([fe80::95cf:cfc1:b5da:314e%6]) with mapi id 15.20.3216.034; Wed, 29 Jul 2020 14:29:27 +0000 From: Shiri Kuzin To: dev@dpdk.org Cc: matan@mellanox.com, rasland@mellanox.com, orika@mellanox.com, viacheslavo@mellanox.com, stable@dpdk.org Date: Wed, 29 Jul 2020 17:29:00 +0300 Message-Id: <1596032940-20138-1-git-send-email-shirik@mellanox.com> X-Mailer: git-send-email 1.8.3.1 Content-Type: text/plain X-ClientProxiedBy: AM0PR01CA0153.eurprd01.prod.exchangelabs.com (2603:10a6:208:aa::22) To AM0PR0502MB3874.eurprd05.prod.outlook.com (2603:10a6:208:1a::29) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from mellanox.com (94.188.199.18) by AM0PR01CA0153.eurprd01.prod.exchangelabs.com (2603:10a6:208:aa::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3239.16 via Frontend Transport; Wed, 29 Jul 2020 14:29:26 +0000 X-Mailer: git-send-email 1.8.3.1 X-Originating-IP: [94.188.199.18] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-MS-Office365-Filtering-Correlation-Id: 6bcedc73-36f1-44fd-c11d-08d833cbcc75 X-MS-TrafficTypeDiagnostic: AM0PR05MB5859: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtFwd X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FqrPh6ViMYbocQZjl+kMVIRcSqd12Nj5zYq/1Ywvnf4ldMJK/jkVNwxDxK+hjv4/g/eR8u1/sviNqL8LTrA/a7yRnZvz2nUGJ9ECh9hvB3hd8V9Z1BqXlkysxCrOF1C1DZklqo4tUzVKEM7HZYI6FoG14+dOF2A4uEbW5of3a1ExciBp+4Uqjp1osZ49L+ai1ljlaZKB2Tn7n+9piEJcVaJmaFjHMfwDbWcgv8yhkmijIsoFVlzdnMjcaXP1Owptaty+WVoghIe3zyUVXhJJOI6vpAfPMPx+Zmjj1zMX1LCICOTpLC37F4rNp9Gfckhtb15xJHWTIOkKP1jozaVerw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AM0PR0502MB3874.eurprd05.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(346002)(396003)(136003)(366004)(39860400002)(376002)(5660300002)(55016002)(2616005)(66476007)(16526019)(86362001)(6666004)(66946007)(186003)(8886007)(26005)(66556008)(956004)(7696005)(52116002)(2906002)(478600001)(4326008)(450100002)(8676002)(8936002)(83380400001)(4744005)(36756003)(6916009)(316002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: jZMVUEBAM0zbYISU2loVxHhD3BilLSE/HV025+NWbTrbcGV7Bxopp6BM/FYxPv1LpsrFtyUSvucPM/ELdFfbVBFVQPDPcussCnm4WuPt7VJCnu7zoZIFImMVwd/kNW/W+Now7QjfazcVhUCsoT5noYF2sS8M1vdkdk3+iIaHwEEC2i+E40dml9ikdKe6UPLoak378ruKTk7SPEYAuIYerUU2P2SgwNSGr3/dyz00FA0f3CEMYM4A7Aw0UCWZBNkyt/ddJzU8aICXqMthPVxSIZ0tg2OMOO8HJ7LRp9GWRrIbdHc5Rgu8SYA7fIa2/GxjlIi0rqoF/JGymWKh82rGc6aDqxScIqZPG/RmDvjn9qhRpqQq4dNaldKYTI8C4r000gNhI79raXy0z8QMXWeQQM/ewJqq5EpEjCPD2a0+GMe0oynMaqzkWhVQembNcss3ZBGwKSPyFWijpJAkVY2cCctQ4wTu22NGoE8q3P5zEuTqIp+I2ZNF+HHlaoShsaYh4p1HdSC6jFBQ6ZqrqVz5kIidWr0kc5wziSNImtDJJ5bqkaUaj7cozDC0AjbVxWfJ+Ubg2IPAgcM4AbsSf7rZyZUfCGfpMNYBk/ulANkTZAk2hIyNiM9L7RuWa2ELChsc3jRpPf+lKbSgcMUR41aRcQ== X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-Network-Message-Id: 6bcedc73-36f1-44fd-c11d-08d833cbcc75 X-MS-Exchange-CrossTenant-AuthSource: AM0PR0502MB3874.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jul 2020 14:29:27.7260 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vnIRlBP+9wS9XB+DypKqTe7+MOpJTNi80duSGwZvhNplZLtq/7YUH5+cW2Cnf2hEtFqht9q9X4/Bnd7mfLgn+g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR05MB5859 Subject: [dpdk-dev] [PATCH] common/mlx5: fix MAC addresses flush X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" mlx5_nl_mac_addr_flush should flush all allocated MAC addresses. The MAC addresses array size should be of size MLX5_MAX_MAC_ADDRESSES, but currently we return without flushing the addresses if size is MLX5_MAX_MAC_ADDRESSES. This was fixed by not allowing an array larger than MLX5_MAX_MAC_ADDRESSES. Fixes: e9a8ac59b6e2 ("common/mlx5: fix MAC addresses assert") Cc: stable@dpdk.org Signed-off-by: Shiri Kuzin Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/linux/mlx5_nl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/common/mlx5/linux/mlx5_nl.c b/drivers/common/mlx5/linux/mlx5_nl.c index 8ab7f6b..0ecd9c7 100644 --- a/drivers/common/mlx5/linux/mlx5_nl.c +++ b/drivers/common/mlx5/linux/mlx5_nl.c @@ -790,7 +790,7 @@ struct mlx5_nl_ifindex_data { { int i; - if (n <= 0 || n >= MLX5_MAX_MAC_ADDRESSES) + if (n <= 0 || n > MLX5_MAX_MAC_ADDRESSES) return; for (i = n - 1; i >= 0; --i) { -- 1.8.3.1