From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com
 [209.85.212.176]) by dpdk.org (Postfix) with ESMTP id A2980C594
 for <dev@dpdk.org>; Mon, 27 Jul 2015 17:54:45 +0200 (CEST)
Received: by wibxm9 with SMTP id xm9so123239982wib.1
 for <dev@dpdk.org>; Mon, 27 Jul 2015 08:54:45 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=YIKHf2ga0QVPAt3XPqYDtRdLeQ3UpV/wlSlUR/EJy2I=;
 b=Jl1RUtqagC5NIwhYsq7NJDu2m7pdd5vP2+rCBvxp42kOYr6m859j4FlHpxrmV0jo+o
 ReN+uKePw/m8diQwPOOJ0NPrywryeRFCb1Wv92xcrSlPL5b+3Xf6MBQxbbTkMlh0xNja
 LTzu2yt2elnxjAp6mJd6oB/I7MkiqR1aVBKgHWhjMTSEFuhgieEJWOVAVXg3TtMAHZsw
 iLdxnc0pafQm6vXSAnI1jav06AbPZNzPupKqp4KycgmT6DUEiKZu1MDLmbxTyZM4bAHx
 QdFiMwzjYq4E9SgNYgnTR+iqDPQ/F3LrU3xPuX33ibKaRaVOqXQqrPX1CqKM79X5W4b4
 f10w==
X-Gm-Message-State: ALoCoQlhuaiBdNEkUaH8cb2M46AZ40DQBd0XA7PPiPOZoIEiGoTiFD6WOm+bUpLvP8WzJOvOXBLW
X-Received: by 10.180.206.14 with SMTP id lk14mr25339052wic.50.1438012485492; 
 Mon, 27 Jul 2015 08:54:45 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by smtp.gmail.com with ESMTPSA id yu4sm8360601wjc.43.2015.07.27.08.54.44
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 27 Jul 2015 08:54:44 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Sanford, Robert" <rsanford@akamai.com>
Date: Mon, 27 Jul 2015 17:53:29 +0200
Message-ID: <1596194.uj9h7LeazE@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.8 (Linux/4.0.4-2-ARCH; KDE/4.14.8; x86_64; ; )
In-Reply-To: <D1DBC78D.B26C%rsanford@akamai.com>
References: <1437691347-58708-1-git-send-email-rsanford2@gmail.com>
 <4708068.jtpnxJe3Ir@xps13> <D1DBC78D.B26C%rsanford@akamai.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 0/3] timer: fix rte_timer_manage and improve
	unit tests
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 27 Jul 2015 15:54:45 -0000

2015-07-27 15:46, Sanford, Robert:
> Hi Thomas,
> 
> > Please, could you re-send this serie after having added the description
> >of
> > each patch in the commit messages?
> 
> Yes, I will move the paragraphs that begin with "Patch n" from patch 0 to
> their respective patches.
> 
> > It seems you fix 2 bugs in the first patch. It may be clearer to split it
> > in 2 patches with separate explanations.
> 
> No, I respectfully disagree. The only bug that we address in patch 1 is
> that the slaves become out of sync with the master.
> The section that begins with "Description of rte_timer_manage() race
> condition bug" is a general description to give background info for both
> patches 2 and 3. I would like to leave that section in part 0, if it's OK
> with you.

OK perfect, thanks.