From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2B8DFA04C3; Mon, 10 Aug 2020 17:08:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 202C12B84; Mon, 10 Aug 2020 17:08:32 +0200 (CEST) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 1A1582A5D for ; Mon, 10 Aug 2020 17:08:31 +0200 (CEST) Received: from Internal Mail-Server by MTLPINE1 (envelope-from orika@nvidia.com) with SMTP; 10 Aug 2020 18:08:29 +0300 Received: from pegasus04.mtr.labs.mlnx. (pegasus04.mtr.labs.mlnx [10.210.16.126]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 07AF8TSk016577; Mon, 10 Aug 2020 18:08:29 +0300 From: Ori Kam To: thomas@monjalon.net, arybchenko@solarflare.com, david.marchand@redhat.com, Ori Kam , John McNamara , Marko Kovacevic Cc: orika@nvidia.com, dev@dpdk.org Date: Mon, 10 Aug 2020 15:08:25 +0000 Message-Id: <1597072105-91338-1-git-send-email-orika@nvidia.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1596464905-43867-1-git-send-email-orika@mellanox.com> References: <1596464905-43867-1-git-send-email-orika@mellanox.com> Subject: [dpdk-dev] [PATCH v4] doc: update RSS action with best effort X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Using the rte_flow action RSS types field, may result in undefined outcome. For example selecting both UDP and TCP, selecting TCP RSS type but the pattern is targeting UDP traffic. another option is that the PMD doesn't support all requested types. Until now, it wasn't clear what will happen in such cases. This commit clarify this issue by stating that the PMD will work in the best-effort mode, and will fail in case the requested type is not supported. Signed-off-by: Ori Kam Signed-off-by: Andrew Rybchenko --- doc/guides/prog_guide/rte_flow.rst | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst index 3e5cd1e..944e824 100644 --- a/doc/guides/prog_guide/rte_flow.rst +++ b/doc/guides/prog_guide/rte_flow.rst @@ -1735,6 +1735,19 @@ unspecified "best-effort" settings from the underlying PMD, which depending on the flow rule, may result in anything ranging from empty (single queue) to all-inclusive RSS. +If non-applicable for matching packets RSS types are requested, +these RSS types are simply ignored. For example, it happens if: + +- Hashing of both TCP and UDP ports is requested + (only one can present in a packet). + +- Requested RSS types contradict to flow rule pattern + (e.g. pattern has UDP item, but RSS types contain TCP). + +If requested RSS hash types are not supported by the Ethernet device at all +(not reported in ``dev_info.flow_tpe_rss_offloads``), +the flow creation will fail. + Note: RSS hash result is stored in the ``hash.rss`` mbuf field which overlaps ``hash.fdir.lo``. Since `Action: MARK`_ sets the ``hash.fdir.hi`` field only, both can be requested simultaneously. -- 1.8.3.1