From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wg0-f49.google.com (mail-wg0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id 2CC3EADCF for ; Tue, 24 Feb 2015 03:47:14 +0100 (CET) Received: by wgha1 with SMTP id a1so2517762wgh.5 for ; Mon, 23 Feb 2015 18:47:14 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=LG3StU3aq7XrRWHc16NU6vHG+L+GWbvU/irCo3UglJg=; b=ZM1BP6YQTfDDI3Crgo/KW58SVTuHkout/M2FZH+ebiX/XGskbFF+6ml1S+VUJThQXY Hf8HMuamNzI0qFAfDpoHcoYDdvaFF31SIMkaPZv0H2VlYLv9XZvufSLVRrD72BdYGEJ4 aHuFSBuoVl2mfxL6FO0LkOGuCCINpWcpCuhsndLBIK1vJk4p723mXwU/M3QNHC5lcbhB G89rmjQdwmmD24XQBBmuvLpMTQUNlsajLyP0cmyZUkXfPw0ODPVCTovDTJD33BMXuSHo a5tP5IISL6nXqmWFXUupp6r7r/CVK0shG1BqUZKFYJjLgEgBfVjEohm/IJfmvgIymiVj G/ww== X-Gm-Message-State: ALoCoQmzU/7P9yd0WwWmpR2nOvQJKiiGmbdMabJlyXQh4478bVAvE9rIYwiAR0bCB3qT4qidPo6S X-Received: by 10.181.8.75 with SMTP id di11mr21347535wid.26.1424746034011; Mon, 23 Feb 2015 18:47:14 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by mx.google.com with ESMTPSA id lx10sm26357645wjb.17.2015.02.23.18.47.11 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Feb 2015 18:47:13 -0800 (PST) From: Thomas Monjalon To: Panu Matilainen Date: Tue, 24 Feb 2015 03:46:41 +0100 Message-ID: <1597878.lL4fhc8lIW@xps13> Organization: 6WIND User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; ) In-Reply-To: References: <7a06a1e8019a40d4175c6bc2e1d7e62cf956b291.1424261465.git.pmatilai@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v2] mk: Rework gcc version detection to permit versions newer than 4.x X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Feb 2015 02:47:14 -0000 > Separately comparing major and minor versions becomes seriously clumsy > when with major version changes, convert the entire version string into > a numeric value (ie 4.6.0 becomes 460 and 5.0.0 becomes 500) and use > that for comparisons, eliminate unnecessary negations while at it. > This makes the comparisons simpler, more obvious and makes gcc 5.0 > naturally recognized at least as capable as newest 4.x. > > This three-digit scheme would run into trouble if gcc ever went to > two-digit version segments, but that hasn't happened in the last 10+ > years so it seems like a safe assumption. > > Signed-off-by: Panu Matilainen Acked-by: Thomas Monjalon Applied, thanks