From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 88F7CA00C5; Thu, 11 Jun 2020 18:14:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2C55ADE0; Thu, 11 Jun 2020 18:14:46 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id C5E9A23D for ; Thu, 11 Jun 2020 18:14:44 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 08ADF5C018C; Thu, 11 Jun 2020 12:14:44 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 11 Jun 2020 12:14:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 5dDvbp8hKemLNsD1tznLMoyecYZs4eOaRgoa7rOZ3WM=; b=QupY9Nx/0eHXtOkJ zRZpIE4lSYlTES+dTrBM03RiHFYWyn7Ymw+WqeKBGNJTTQui3s+qfNXAzFQVXKbx cxZB1wV7NmcI9l0UfZgk5/2ZDuzzNyaF2FA9uypNm7eYNzGc/PAUNC04D2xe4HBZ v7UVnl83tMzV80leebp/FRVLDGpA5SE29KHuMWKaS9qmLFaeAFU12FeMvtFZ2UYb mmgfT08C98aSpMnuKgLPs3hdAFYu2WEnuLOe4pUdhE98s8GKULW9lgiw0CLYaJ2e vBPEudM15wfQ73Jlfx6TvmmFDDDg/uHqgoLKOftWLulEtu0fEhFKAxzrdasRN9xa hTMq2w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=5dDvbp8hKemLNsD1tznLMoyecYZs4eOaRgoa7rOZ3 WM=; b=E7DUFqMytowuE4C1kOSctP5UuGLyHiDMwg21TXSw/Mib7tqawc7jE5zJq F/Ca2iJK7ZevlMO5FgGVWLKKRnJOYUlUQsL/p9h48Mdq4wu9vAViSo8YB2PLIILa DzRoH/UjWcFBHLN4Y7FGJituZWbT7/Ep4djF5TZQVs8tFAD73YUI8EscdiZJxTZh F2xaZxsatJXp/o7gjs5sqMPIJFFPGNYme+1JyjY/fqungtRCTh1xp9h9CzsvS+vY Jn3ecTC/Oe5yb4gYfj70se0mBIxZYjr3E6DmAuBqpuhH7x+byUTfwCj4x0SS9D9X W7GWn8p3mT7p+N5EuidWDgUVtPDLw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudehledgjeefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 81F4930618B7; Thu, 11 Jun 2020 12:14:42 -0400 (EDT) From: Thomas Monjalon To: Harini.Ramakrishnan@microsoft.com, Pallavi Kadam , navasile@linux.microsoft.com Cc: dev@dpdk.org, ranjit.menon@intel.com, dmitry.kozliuk@gmail.com, Narcisa.Vasile@microsoft.com, tbashar@mellanox.com, talshn@mellanox.com, fady@mellanox.com Date: Thu, 11 Jun 2020 18:14:41 +0200 Message-ID: <1597883.oqJHaQj4sU@thomas> In-Reply-To: <20200528231455.13636-2-pallavi.kadam@intel.com> References: <20200514203945.1484-1-pallavi.kadam@intel.com> <20200528231455.13636-1-pallavi.kadam@intel.com> <20200528231455.13636-2-pallavi.kadam@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 1/2] eal: fix warnings on Windows X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 29/05/2020 01:14, Pallavi Kadam: > Fixed bunch of warnings when compiling using clang on Windows > such as the use of an unsafe string function (strerror), > [-Wunused-variable], [-Wunused-function] in eal_common_options.c > [-Wunused-const-variable] in getopt.c and [-Wunused-parameter] > in eal_common_thread.c. > Also fixed warnings generated using Mingw: > [-Werror=old-style-definition], [-Werror=cast-function-type] and > [-Werror=attributes] > > Signed-off-by: Ranjit Menon > Signed-off-by: Pallavi Kadam > Tested-by: Pallavi Kadam Tested-by is useless if you are the author of the patch. > lib/librte_eal/common/eal_common_options.c | 8 +++++++- > lib/librte_eal/windows/eal.c | 2 +- > lib/librte_eal/windows/eal_lcore.c | 2 +- > lib/librte_eal/windows/eal_thread.c | 3 ++- > lib/librte_eal/windows/getopt.c | 4 ++-- > lib/librte_eal/windows/include/pthread.h | 6 ++++-- > 6 files changed, 17 insertions(+), 8 deletions(-) There were some changes since v2 which were not reviewed. Someone please?