* [dpdk-dev] [PATCH] net/iavf: fix default mac set fail issue
@ 2020-08-25 3:00 Li Han
2020-08-31 8:27 ` Zhang, Qi Z
0 siblings, 1 reply; 2+ messages in thread
From: Li Han @ 2020-08-25 3:00 UTC (permalink / raw)
To: jingjing.wu, beilei.xing; +Cc: dev, Li Han
rte_is_valid_assigned_ether_addr retrun true
if the given ethernet address is valid.
Signed-off-by: Li Han <han.li1@zte.com.cn>
---
drivers/net/iavf/iavf_ethdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index c3aa4cd..18ce809 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -973,7 +973,7 @@ static int iavf_config_rx_queues_irqs(struct rte_eth_dev *dev,
return 0;
/* If the MAC address is configured by host, skip the setting */
- if (rte_is_valid_assigned_ether_addr(perm_addr))
+ if (!rte_is_valid_assigned_ether_addr(perm_addr))
return -EPERM;
ret = iavf_add_del_eth_addr(adapter, old_addr, false);
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] net/iavf: fix default mac set fail issue
2020-08-25 3:00 [dpdk-dev] [PATCH] net/iavf: fix default mac set fail issue Li Han
@ 2020-08-31 8:27 ` Zhang, Qi Z
0 siblings, 0 replies; 2+ messages in thread
From: Zhang, Qi Z @ 2020-08-31 8:27 UTC (permalink / raw)
To: Li Han, Wu, Jingjing, Xing, Beilei; +Cc: dev
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Li Han
> Sent: Tuesday, August 25, 2020 11:01 AM
> To: Wu, Jingjing <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>
> Cc: dev@dpdk.org; Li Han <han.li1@zte.com.cn>
> Subject: [dpdk-dev] [PATCH] net/iavf: fix default mac set fail issue
>
> rte_is_valid_assigned_ether_addr retrun true if the given ethernet address is
> valid.
>
> Signed-off-by: Li Han <han.li1@zte.com.cn>
> ---
> drivers/net/iavf/iavf_ethdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
> index c3aa4cd..18ce809 100644
> --- a/drivers/net/iavf/iavf_ethdev.c
> +++ b/drivers/net/iavf/iavf_ethdev.c
> @@ -973,7 +973,7 @@ static int iavf_config_rx_queues_irqs(struct
> rte_eth_dev *dev,
> return 0;
>
> /* If the MAC address is configured by host, skip the setting */
> - if (rte_is_valid_assigned_ether_addr(perm_addr))
> + if (!rte_is_valid_assigned_ether_addr(perm_addr))
A valid mac address means it already be configured by host, so it should be skipped.
> return -EPERM;
>
> ret = iavf_add_del_eth_addr(adapter, old_addr, false);
> --
> 1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-08-31 8:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-25 3:00 [dpdk-dev] [PATCH] net/iavf: fix default mac set fail issue Li Han
2020-08-31 8:27 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).