From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 51086160 for ; Wed, 24 Jan 2018 17:52:18 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C767B22720; Wed, 24 Jan 2018 11:52:17 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Wed, 24 Jan 2018 11:52:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=wRDHfwAm/EfbZB3pjfXeAlF2Mz +lMjWqfK3tFs+VCrc=; b=NxelNegNvXA+SQXab3MstXFZh+3jgcuSHm34JwdVaq u2ZJrYDwqrcbw6nhU3QfLFXzPrN96iQnt/meZanuz004ys/ZTvd3T8lnR7zwfk6e eVbX2ptdYOfgL5G3Ub/2Z6VPji1LkXhUaWRjn7jy52a0Q8DOw4wex6EHr8OAIAeO 0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=wRDHfw Am/EfbZB3pjfXeAlF2Mz+lMjWqfK3tFs+VCrc=; b=rPLpKS6sdDlcgRhlTVCj9+ 4kB914PwXB/wJa+Gt2CuNEMcrqXOM1tmC539kp52g9smO7Xyy7N4YqxUW2IBh6X0 Ez0IfSC8VGzff1MPp2fE6+9zsNJvIInpNb8wB0iQ5NwyA3UBH8NcD5y98jHrR4L7 l/g/oanTlXz7jPKkF3sKfe8uAy9QYLCmm8EiQW+4ILUMBECUKzZ2o4fz9fHbzpY1 v0a+Rx6x3BUfdgJMXJsKlDQR4GRm+hWYDvtgwSYfOkdKR5mpzy09FtH9CatNQfAC H5ilP9g7d/cmfymbld5r7diWmVo3ddeBBDc3kVIRX0ZKwY+sPDOlQS6BnVeoJQ2A == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 70537247A1; Wed, 24 Jan 2018 11:52:17 -0500 (EST) From: Thomas Monjalon To: Yuanhan Liu Cc: =?ISO-8859-1?Q?Ga=EBtan?= Rivet , Ferruh Yigit , dev@dpdk.org Date: Wed, 24 Jan 2018 17:51:36 +0100 Message-ID: <15984161.x0pdKaQmNl@xps> In-Reply-To: <20180124152432.GX29540@yliu-mob> References: <1516114218-21501-1-git-send-email-yliu@fridaylinux.org> <20180123160816.uvsvegtltmzrr4yi@bidouze.vm.6wind.com> <20180124152432.GX29540@yliu-mob> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH] doc: document the new devargs syntax X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Jan 2018 16:52:18 -0000 24/01/2018 16:24, Yuanhan Liu: > On Tue, Jan 23, 2018 at 05:08:16PM +0100, Ga=EBtan Rivet wrote: > > Drivers answers to a specific API (ethdev, cryptodev, ...), to create > > standardized objects in response to parameters that are given to them > > for init. I think matching properties should be restricted to higher > > classes (bus, eth/crypto), >=20 > That's also what I thought. But I'm okay to have "driver" category > included for matching. I just don't really see a good example for that. >=20 > > while the driver class should be left > > free-form and to the responsibility of the PMD itself (while having the > > proper libraries for helping parsing safely, thus driving developpers > > toward similar syntaxes, while not forcing them in those). >=20 > I agree. The drv args are parsed by the drivers after all. It's hard to > have a good parser for all. I also don't know why we have to force them > to use "key=3Dvalue" pairs. >=20 > I even see some drawbacks from the forcement: >=20 > - some PMDs already use none key/value format. Forcing them breaks more. > If the "-w" "--vdev" compatibility is kept", nothing will be broken > from the user point of view. However, if "key=3Dvalue" pair is going to > be used, user have to do some changes. >=20 > - Some "value" might have to use the nested "=3D". Handling the nested pa= irs > introduces more complexity. >=20 > - sometimes, it's simple without an assignment. For example, it could be > "driver=3Dvhost-pmd,...,client" to let the vhost PMD acts as the client > mode. >=20 > Both Linux kernel and QEMU don't force the "key=3Dvalue" pair usage, I do= n't > see any good reason why we have to do that. OK