From: Changpeng Liu <changpeng.liu@intel.com>
To: dev@dpdk.org
Cc: changpeng.liu@intel.com, matan@mellanox.com,
maxime.coquelin@redhat.com, chenbo.xia@intel.com,
tomasz.zawadzki@intel.com
Subject: [dpdk-dev] [PATCH] vhost: return ready when at least 1 vring is configured
Date: Tue, 1 Sep 2020 15:07:37 +0800 [thread overview]
Message-ID: <1598944057-32690-1-git-send-email-changpeng.liu@intel.com> (raw)
Commit d0fcc38f "vhost: improve device readiness notifications"
needs at least 2 vrings before changing the device state to
ready, this is fine for NET device but not correct for BLK
device.
The number of vring required should be based on the device
type, e.g. virtio_scsi device needs at least 3 vrings, and
virtio_net needs at least 2 vrings, virtio_blk needs at least
1 vring. So instead of doing it in vhost library it's better
that the application who uses this library do this check.
Signed-off-by: Changpeng Liu <changpeng.liu@intel.com>
---
lib/librte_vhost/vhost_user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c
index c3c924f..4d1883c 100644
--- a/lib/librte_vhost/vhost_user.c
+++ b/lib/librte_vhost/vhost_user.c
@@ -1343,7 +1343,7 @@
vq->enabled;
}
-#define VIRTIO_DEV_NUM_VQS_TO_BE_READY 2u
+#define VIRTIO_DEV_NUM_VQS_TO_BE_READY 1u
static int
virtio_is_ready(struct virtio_net *dev)
--
1.9.3
next reply other threads:[~2020-09-01 6:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-01 7:07 Changpeng Liu [this message]
2020-09-18 9:53 ` Maxime Coquelin
2020-09-21 5:03 ` Liu, Changpeng
2020-09-21 10:19 ` Maxime Coquelin
2020-09-22 7:22 ` Liu, Changpeng
2020-09-23 8:05 ` Maxime Coquelin
2020-09-23 8:14 ` Liu, Changpeng
2020-09-29 13:54 ` Zhang, Roy Fan
2020-09-29 14:05 ` Maxime Coquelin
2020-09-29 18:15 ` Zhang, Roy Fan
2020-09-30 2:48 ` Xia, Chenbo
2020-09-30 15:36 ` Maxime Coquelin
2020-09-30 16:37 ` Zhang, Roy Fan
2020-10-01 7:55 ` Maxime Coquelin
2020-10-01 8:07 ` Zhang, Roy Fan
2020-10-01 8:26 ` Maxime Coquelin
2020-10-01 8:42 ` Zhang, Roy Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1598944057-32690-1-git-send-email-changpeng.liu@intel.com \
--to=changpeng.liu@intel.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=maxime.coquelin@redhat.com \
--cc=tomasz.zawadzki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).