From: wangyunjian <wangyunjian@huawei.com>
To: <dev@dpdk.org>
Cc: <nipun.gupta@nxp.com>, <jerry.lilijun@huawei.com>,
<xudingke@huawei.com>, Yunjian Wang <wangyunjian@huawei.com>,
<stable@dpdk.org>
Subject: [dpdk-dev] [PATCH v2] raw/dpaa2_qdma: fix missing parentheses
Date: Wed, 9 Sep 2020 09:11:46 +0800 [thread overview]
Message-ID: <1599613906-19420-1-git-send-email-wangyunjian@huawei.com> (raw)
In-Reply-To: <8f778cef6a01a8222e256daf25ff5ce6feed334b.1599485594.git.wangyunjian@huawei.com>
From: Yunjian Wang <wangyunjian@huawei.com>
This issue detected by coverity, CID#279443(Structurally dead code).
Coverity issue: 279443
Fixes: c22fab9a6c34 ("raw/dpaa2_qdma: support configuration APIs")
Cc: stable@dpdk.org
Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
v2: fix spelling in commit log
---
drivers/raw/dpaa2_qdma/dpaa2_qdma.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
index 0b9c4e3d7..4b8474951 100644
--- a/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
+++ b/drivers/raw/dpaa2_qdma/dpaa2_qdma.c
@@ -452,9 +452,10 @@ rte_qdma_reset(void)
/* In case there are pending jobs on any VQ, return -EBUSY */
for (i = 0; i < qdma_dev.max_vqs; i++) {
if (qdma_vqs[i].in_use && (qdma_vqs[i].num_enqueues !=
- qdma_vqs[i].num_dequeues))
+ qdma_vqs[i].num_dequeues)) {
DPAA2_QDMA_ERR("Jobs are still pending on VQ: %d", i);
return -EBUSY;
+ }
}
/* Reset HW queues */
--
2.18.1
next prev parent reply other threads:[~2020-09-09 1:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-07 13:41 [dpdk-dev] [PATCH] " wangyunjian
2020-09-09 1:11 ` wangyunjian [this message]
2020-10-06 21:33 ` [dpdk-dev] [PATCH v2] " Thomas Monjalon
2020-10-07 5:35 ` Nipun Gupta
2020-10-11 20:06 ` [dpdk-dev] [dpdk-stable] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1599613906-19420-1-git-send-email-wangyunjian@huawei.com \
--to=wangyunjian@huawei.com \
--cc=dev@dpdk.org \
--cc=jerry.lilijun@huawei.com \
--cc=nipun.gupta@nxp.com \
--cc=stable@dpdk.org \
--cc=xudingke@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).