From: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com> To: dev@dpdk.org Cc: kaara.satwik@chelsio.com, stable@dpdk.org Subject: [dpdk-dev] [PATCH v2] net/cxgbe: fix duplicate MAC addresses in MPS TCAM Date: Sat, 12 Sep 2020 05:17:51 +0530 Message-ID: <1599868071-6688-1-git-send-email-rahul.lakkireddy@chelsio.com> (raw) In-Reply-To: <1598980729-19850-1-git-send-email-rahul.lakkireddy@chelsio.com> From: Karra Satwik <kaara.satwik@chelsio.com> During MAC address insertion to MPS TCAM, add a default mask when the mask is not explicitly specified. Otherwise, driver misses the mask comparison and ends up inserting duplicate entries in the MPS TCAM. Fixes: 6fda3f0ddda9 ("net/cxgbe: add API to program hardware MPS table") Cc: stable@dpdk.org Signed-off-by: Karra Satwik <kaara.satwik@chelsio.com> Signed-off-by: Rahul Lakkireddy <rahul.lakkireddy@chelsio.com> --- v2: - Fix spelling Othewise to Otherwise in commit message. drivers/net/cxgbe/mps_tcam.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/cxgbe/mps_tcam.c b/drivers/net/cxgbe/mps_tcam.c index 5302d1343..6e5fae992 100644 --- a/drivers/net/cxgbe/mps_tcam.c +++ b/drivers/net/cxgbe/mps_tcam.c @@ -140,6 +140,7 @@ int cxgbe_mpstcam_modify(struct port_info *pi, int idx, const u8 *addr) /* idx can now be different from what user provided */ entry = &mpstcam->entry[idx]; memcpy(entry->eth_addr, addr, RTE_ETHER_ADDR_LEN); + memset(entry->mask, ~0, RTE_ETHER_ADDR_LEN); /* NOTE: we have considered the case that idx returned by t4_change_mac * will be different from the user provided value only if user * provided value is -1 -- 2.24.0
next prev parent reply other threads:[~2020-09-12 0:02 UTC|newest] Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-01 17:18 [dpdk-dev] [PATCH] " Rahul Lakkireddy 2020-09-11 23:47 ` Rahul Lakkireddy [this message] 2020-09-14 17:46 ` [dpdk-dev] [dpdk-stable] [PATCH v2] " Ferruh Yigit
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1599868071-6688-1-git-send-email-rahul.lakkireddy@chelsio.com \ --to=rahul.lakkireddy@chelsio.com \ --cc=dev@dpdk.org \ --cc=kaara.satwik@chelsio.com \ --cc=stable@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git