DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Yu, DapengX" <dapengx.yu@intel.com>
To: "Xing, Beilei" <beilei.xing@intel.com>, "Guo, Jia" <jia.guo@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix register setting for hash enable
Date: Wed, 27 Jan 2021 02:16:30 +0000
Message-ID: <159b0b86360f454dbb6e2f94bb42eeba@intel.com> (raw)
In-Reply-To: <MN2PR11MB38078239F37ABE95A1C39E2CF7BB9@MN2PR11MB3807.namprd11.prod.outlook.com>

Hi Beilei,

The pctype translation is introduced by i40e RSS refactor commit: ef4c16fd9148 by mistake, its behavior is inconsistent with the implementation before the refactor. 

This inconsistency can be gotten from the comparison of the running of the code.

I have also confirmed with the author of commit: ef4c16fd9148 that the adding of the translation is a mistake. 

So actually even if without x722 datasheet, we can know the translation is unnecessary.

I cannot find x722 datasheet from Intel website. It will be great if you can share one. Thanks!

-----Original Message-----
From: Xing, Beilei 
Sent: Wednesday, January 27, 2021 9:44 AM
To: Yu, DapengX <dapengx.yu@intel.com>; Guo, Jia <jia.guo@intel.com>
Cc: dev@dpdk.org; Yu, DapengX <dapengx.yu@intel.com>; stable@dpdk.org
Subject: RE: [PATCH] net/i40e: fix register setting for hash enable

> -----Original Message-----
> From: dapengx.yu@intel.com <dapengx.yu@intel.com>
> Sent: Tuesday, January 26, 2021 5:52 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Guo, Jia <jia.guo@intel.com>
> Cc: dev@dpdk.org; Yu, DapengX <dapengx.yu@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/i40e: fix register setting for hash enable
> From: Dapeng Yu <dapengx.yu@intel.com>
> The original code causes wrong value to be set into PFQF_HENA register 
> because unnecessary calling to get translated pctype value for X722 
> NIC. The result is RSS cannot work.
> So remove the unnecessary translation.
> Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow")
> Cc: stable@dpdk.org
> Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
> ---
>  drivers/net/i40e/i40e_hash.c | 4 ----
>  1 file changed, 4 deletions(-)
> diff --git a/drivers/net/i40e/i40e_hash.c 
> b/drivers/net/i40e/i40e_hash.c index
> 9271797a7..b1cb24f43 100644
> --- a/drivers/net/i40e/i40e_hash.c
> +++ b/drivers/net/i40e/i40e_hash.c
> @@ -678,10 +678,6 @@ i40e_hash_enable_pctype(struct i40e_hw *hw,  {  
> uint32_t reg, reg_val, mask;
> -/* For X722, get translated pctype in fd pctype register */ -if 
> (hw->mac.type == I40E_MAC_X722) -pctype = i40e_read_rx_ctl(hw, 
> I40E_GLQF_FD_PCTYPES(pctype));
> -

Did you check the latest X722 datasheet to confirm the behavior?

>  if (pctype < 32) {
>  mask = BIT(pctype);
>  reg = I40E_PFQF_HENA(0);
> --
> 2.27.0

  reply	other threads:[~2021-01-27  2:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-26  9:52 dapengx.yu
2021-01-27  1:44 ` Xing, Beilei
2021-01-27  2:16   ` Yu, DapengX [this message]
2021-01-27  3:07 ` Xing, Beilei
2021-01-28 13:31   ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=159b0b86360f454dbb6e2f94bb42eeba@intel.com \
    --to=dapengx.yu@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=jia.guo@intel.com \
    --cc=stable@dpdk.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git