From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B02DAA0C4C; Tue, 5 Oct 2021 18:39:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9A81D413FC; Tue, 5 Oct 2021 18:39:19 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id CA3C2413FB for ; Tue, 5 Oct 2021 18:39:17 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10128"; a="212915295" X-IronPort-AV: E=Sophos;i="5.85,349,1624345200"; d="scan'208";a="212915295" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Oct 2021 09:39:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,349,1624345200"; d="scan'208";a="623462782" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by fmsmga001.fm.intel.com with ESMTP; 05 Oct 2021 09:39:15 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Tue, 5 Oct 2021 09:39:15 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Tue, 5 Oct 2021 09:39:15 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.176) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Tue, 5 Oct 2021 09:39:15 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eeNG5PRD8URHcYY/4pLV6DmfG+0zk6L3WX6hLdSlfBUjogUJYQ1ZlKAVFhXLft6EKSWuEC6miH7PeeOWjqf8ZXLB0JhlW277VEeWc3zFPgLcJmgLfU0i9g6lo/PKUrvRVnPRpAOvzn1/vvqSXx1ZeU1L3qtPwi7DrvTzvdj+MVEpWCNSaV6Qxzwt+AeFHbITIZWREcoJ5selGU3LOsFzCMefap4r1TL9WjQ+X3dCD+z4/Ryjd69kNBYeN9Cv/81mOERdRMKSuOZM0gU3kp8zFnWUena9ukkoCjAPu3flUjqTRrvXXRwiv9ALZwmEnma/1lwZhYJeJaWNh5CeODRAQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0DkhcRuwPYpCiLGxCenwOX9EkG30+RIuVA5PvVhH6J4=; b=L//mVMO7hCKBwVGdlPaiCWvvKCZSsn6fB+CFFmLqE7q8C4DyxkZqjG0z/818R5r/2sjvhadmgb1OghdN/j/F8fXybtTfbYeKkp6X6weIbhGFN3hhJ4+9OuZYg3nK4edTgyhu6O9hv7to0O1xPPnjywehIpR/U6oFkuQAUTixf16CjGXx4t5GKLFP1tCym4yqHUiRG2mWzPn0L1SGR7kPRESUJ9NHcEMcX5L7OQV1gdgWXYXYGIDWi7wZEJsxfLaUnVRfdV8DvCpiy6SE+eIUhfeCXfjEx5JCJURVF5zAXqCTAPCyYJvOaq5BLAj/AMoeEawSOHBoEHw8oAyByorGmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0DkhcRuwPYpCiLGxCenwOX9EkG30+RIuVA5PvVhH6J4=; b=CIRo13OC7qQnU2mO3+MgqA6dzcm4hZvNA+KZCZwSnTQpOq+fUdHSXgptu8MHjM9hUw+gyugn/zZs0Xs334BxoFj3yBHRr7E+4FKkrgc1cTvUeYZuTZqkxfVvHfOsLxjs8hLnjcliyfyQV5O46pYW36J2USMLi8214hvvsG1TBU8= Authentication-Results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4968.namprd11.prod.outlook.com (2603:10b6:510:39::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4587.18; Tue, 5 Oct 2021 16:39:04 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%4]) with mapi id 15.20.4566.022; Tue, 5 Oct 2021 16:39:04 +0000 Message-ID: <15acc50c-f215-b3cb-9367-6446dd5ad0f2@intel.com> Date: Tue, 5 Oct 2021 17:38:46 +0100 Content-Language: en-US To: "Xueming(Steven) Li" , "yisen.zhuang@huawei.com" , "oulijun@huawei.com" , "dev@dpdk.org" , "humin29@huawei.com" , "spinler@cesnet.cz" CC: "mczekaj@marvell.com" , "radhac@marvell.com" , "sthotton@marvell.com" , "Matan Azrad" , "kirankumark@marvell.com" , "rmody@marvell.com" , "beilei.xing@intel.com" , "chenbo.xia@intel.com" , "vburru@marvell.com" , "somnath.kotur@broadcom.com" , "jiawenwu@trustnetic.com" , "skori@marvell.com" , "hemant.agrawal@nxp.com" , "maxime.coquelin@redhat.com" , "asomalap@amd.com" , "yongwang@vmware.com" , "andrew.rybchenko@oktetlabs.ru" , "heinrich.kuhn@corigine.com" , "ajit.khaparde@broadcom.com" , "hkalra@marvell.com" , "shaibran@amazon.com" , "chas3@att.com" , "cloud.wangxiaoyun@huawei.com" , "sthemmin@microsoft.com" , "jerinj@marvell.com" , "qiming.yang@intel.com" , "pnalla@marvell.com" , NBU-Contact-Thomas Monjalon , "mk@semihalf.com" , "srinivasan@marvell.com" , "mw@semihalf.com" , "keith.wiles@intel.com" , "xiao.w.wang@intel.com" , "xuanziyang2@huawei.com" , "mtetsuyah@gmail.com" , "qi.z.zhang@intel.com" , "g.singh@nxp.com" , "aboyer@pensando.io" , "steven.webster@windriver.com" , "evgenys@amazon.com" , "johndale@cisco.com" , "irusskikh@marvell.com" , "dsinghrawat@marvell.com" , "shshaikh@marvell.com" , "lironh@marvell.com" , "Slava Ovsiienko" , "aman.deep.singh@intel.com" , "sachin.saxena@oss.nxp.com" , "rahul.lakkireddy@chelsio.com" , "matt.peters@windriver.com" , "jianwang@trustnetic.com" , "skoteshwar@marvell.com" , "zr@semihalf.com" , "jingjing.wu@intel.com" , NBU-Contact-longli , "igorch@amazon.com" , "grive@u256.net" , "zhouguoyang@huawei.com" , "jgrajcia@cisco.com" , "hyonkim@cisco.com" , "haiyue.wang@intel.com" , "ndabilpuram@marvell.com" References: <20210727034134.20556-1-xuemingl@nvidia.com> <20210918123525.135129-1-xuemingl@nvidia.com> <20210918123525.135129-3-xuemingl@nvidia.com> <5dbc3817-924b-9bdd-5176-f971ed63c493@intel.com> <0007ffea2d8fd0eaa02bda6db5764fd057e909d1.camel@nvidia.com> <127f917b-e360-3278-7080-88a26c5e7016@intel.com> <0a40b42090f1d0b3a3c6304bf4e5e54bb982c1f4.camel@nvidia.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0071.eurprd04.prod.outlook.com (2603:10a6:10:232::16) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0071.eurprd04.prod.outlook.com (2603:10a6:10:232::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4566.14 via Frontend Transport; Tue, 5 Oct 2021 16:38:52 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1747cd78-3ae0-4d18-f70d-08d9881ea444 X-MS-TrafficTypeDiagnostic: PH0PR11MB4968: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yeFeYaRhA+q+KMp6Ww8nRlZwIL8zAPF4z1+l+0QLKqTvpSlBivcAwGL6KAh6QXAcUmx6D/yQ1joV2eFyynraDgbnjovULn6jv7aEwNQlD6D4STsRhIJcAxLSRtvaz3nd3kSsGPRH4eA+voMJEVOgioodpp+eOvyjXWHj2k3jiHNMw9CZaBIDjRjh58IjCZHyc65c7SUIrf1IIcQwG59IlktSeR2zEwIcbdX8fEATTqr6WQ8dJu6WSnwHzD8xRl7CXdTlW2K3TKbI8qYXIWWZWK/WmtB0icWi8Ws9QN5W/ILNHL9XRyimfnMbz3UPYsJTPjLdeFUez8biZSOLheSQFBfOcKZDm+fizqNRj87G7kyl5W7Zg1WJim31z8YjMz7Q+yoCIp+ZMyqK+X9FynwnDhC7jIilQYMErAaEbvV/cO2vmg9mIMpNMK+r9u0OxDw4g51zYg7m2EnH+EnRUgDNz/IS59rOD6HqAzw6SVovDpAvFY9Mxg7uhsPFXSCNktD5E4ICzBuOXges0vl24oN//BtZ2JMpNGfkMC2mfopBvDZhXUWsR/dyQctDAbEZXs/JAm6RP41Rdtyl+NcTqX/M4lXOl0Zp91tFnrL34Y3K8r9leTDIkRj/qsCGVlmYQWupbVaqrzuvH2wg5ykiSJmZ/q+A0+CKl8auWzgutu8L9JXMYhnsyBleL95HvIwTESEvEN20PE3U4NBrw6ixsieurA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(2906002)(38100700002)(83380400001)(36756003)(26005)(7406005)(7416002)(956004)(7366002)(2616005)(186003)(316002)(8936002)(4326008)(6486002)(16576012)(8676002)(110136005)(31686004)(54906003)(5660300002)(31696002)(6666004)(66946007)(66476007)(66556008)(508600001)(53546011)(44832011)(86362001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aXd1dTh5ZG95bTRJZEZkSEpySitZMGdUM1l0SDd0bHdaMGRCUVR3UU1hU2ZZ?= =?utf-8?B?cUtqZ3Ezc3NvZjZQeGNpZFc0LzJoSU9VdlhaaDNqY2F2NEJlUVFRSnpGbVNB?= =?utf-8?B?aHRQamdWVU1jL2N5OU0xOVhXb2xpKzdWZ2RpSHlzbm1sdUQ3WndRa0R5c1l4?= =?utf-8?B?NzA1VEtzd283RndsVjRFNEUrOHEyYWRSMEp3andyZUtodlZRUlhmZWtHeS9x?= =?utf-8?B?MlA1Y255WEU4VzVpaWNKYXZ4MHZjck9OdklpYk54N2Q1bmMvaTVINDRwNFZL?= =?utf-8?B?VVJFcHdnQ0dFSXdNTjRhSkowZEZHcnpqUkx5bHlucXNkVElFcXVlZEUvRCt5?= =?utf-8?B?ZEQ0UjdBbVFhbVlsZXFDN2pMVldQMisvQkJnamQrd1QzT050V2tYOWp0UzV5?= =?utf-8?B?Qm9Gd1J3SktoUUYxblJGWUVzMXBWZHpWczdaUXdxL3ZiQ3dJWWprQVd1Sktx?= =?utf-8?B?N3cwS2hpcWhwQU5iTWpxSXZseGYwVWtpTFRnRW4xS1hVV3ZkdktNQkllNzlm?= =?utf-8?B?aGVpdHhmemNUdGVnSUM0SjJKUFMyYlAvM1NlcmZqV0UwTk41NFBxd3FJNnAr?= =?utf-8?B?Mncra3NDWkVaK2tJZlRGaHBYV0x2ampWekRPZzhMZ0h0cWd6Vk92K1dRZXNB?= =?utf-8?B?c05ZVUVxcVY1cy85Y2NQdWZNYnBHTW53Q1RVeXF0dmQvNEZpTjh3QmxScGZl?= =?utf-8?B?QzJwM0FPand1VTNLYjFiTzBpcDcrbXRMZWp6MW9nUG1oRjcyRXhqdmVJc3li?= =?utf-8?B?SG1vNTZHdkxIcFZKa3VDVWVaMk9GdnhzS2ZaS3BCSWRSNnp6RXBSci9jNHgr?= =?utf-8?B?eGxaQUh2WWlRMW1JdG9TRlo5amtmajZhQ3RVQy9wZ2JmdkdLL2dhZVN0MXll?= =?utf-8?B?cTNkVkIrMEFFRDIyM3UwQVl6OENOWlVqck4xTXRQQnE5a2lEbEU5eXlVc2h5?= =?utf-8?B?U25ZZ0QrbmFrTFcyS3RPZ2djczNTZjJQWDRKbktYcVlXZ3NJeDV3SFNVWnYz?= =?utf-8?B?em9iZW10d1czQnhWSTBWQlVKT0xSUWw1UUw2Qk5lOEJVRFQ2YlY1UVF3MURN?= =?utf-8?B?SE1vZkw0bEpaVUxrc2lSZGdqVTVFTHE0Z09NdEVYS3Jxbld5TVlySlZRU01Y?= =?utf-8?B?Szg4V3dJV0UxT0Q1K0lid0grdDcwRUtPTllreWhlR283TkF3Rk5uanphSGdZ?= =?utf-8?B?akpobmxPNG5tQXVCcXdab292akZ2dVdzcEFMZjJkdUZleGl2Tng1RzRSYWla?= =?utf-8?B?UFpjZVJtK21LeUI4a3dwMVAxekVydnJRY3BSTEs3Z3VGQmZVQm1UREY0RVBh?= =?utf-8?B?Q2RtaUhwTjVVVi9sTDRibXJaa2o0WVVqN3BxZkl1RVdkVnJ4VEp1WW9sRzBE?= =?utf-8?B?dm1zVmxsUGZYVyt3T1JDMU9ISHhKOGc1dHJmcVUwWGhqK3JPN01tUHNpVERB?= =?utf-8?B?T1o5aFpyd1lBREduU0g3WU9YZUdqZFZsMmc5SDZpdGYzMjdsVGdJTTRjSnJT?= =?utf-8?B?dXFLUWd4UjZCSUdpQ3VKV3N3ZzlaaDRKSU5WcVZPaU0xRFIwU0p3alFmWnc0?= =?utf-8?B?OVJzNkNQalRPSG04NnZDcFhZajlYVnZWb0lyTkxVb2RBVUkwMGpWMjNXY1RM?= =?utf-8?B?L01jVFg2M0ZsRDdRV0preDFPN3VEMFdHeEhBK3FjY1ZkTDU2cFVaZVlFRzZk?= =?utf-8?B?UndINkR4M1lVdmdkWStGeENEcmRqbGM4OTY5VzJncDd3T1BVT1ROV0JIOEJE?= =?utf-8?Q?H+Mcm91qttb4ATIyHBH1G+tUasRNz91LUZAo+ne?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1747cd78-3ae0-4d18-f70d-08d9881ea444 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Oct 2021 16:39:04.0993 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: cj8VG5d6NZQGKFUFtzlGhUG9KSVi9P0MATpMnKU0NGI5W1zBc93TraEeB1HCwOe/mFWVB8EZw8bn3WnJIpbY1g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4968 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v5 2/2] ethdev: change queue release callback X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/29/2021 2:57 PM, Xueming(Steven) Li wrote: > On Wed, 2021-09-22 at 12:54 +0000, Xueming(Steven) Li wrote: >> On Wed, 2021-09-22 at 11:57 +0100, Ferruh Yigit wrote: >>>>> >>>>> <...> >>>>> >>>>>> void >>>>>> -i40e_dev_rx_queue_release(void *rxq) >>>>>> +i40e_dev_rx_queue_release(struct rte_eth_dev *dev, uint16_t qid) >>>>>> +{ >>>>>> + i40e_rx_queue_release(dev->data->rx_queues[qid]); >>>>>> +} >>>>>> + >>>>>> +void >>>>>> +i40e_dev_tx_queue_release(struct rte_eth_dev *dev, uint16_t qid) >>>>>> +{ >>>>>> + i40e_tx_queue_release(dev->data->tx_queues[qid]); >>>>>> +} >>>>>> + >>>>> >>>>> Is there any specific reason to not update driver but add wrappers for it? >>>> >>>> Some caller don't have queue ID on hand, adding wrapper seems more >>>> convinient. >>>> >>> >>> Convinient for the patch, but not sure convinient for the driver. >>> >>> As mentioned before, not sure about approach to update some driver and add >>> wrappers for some others. >>> >>> qede, ice and i40e seems not updated, I am for syncronizing with their >>> maintainers before proceed. >>> >>>> >> >> For qede, qede_tx_queue_release(txq_obj) is called by >> qede_alloc_tx_queue_mem(dev, qid), while upper caller >> qede_tx_queue_setup() doesn't always save txq_obj to dev->data->txqs[]. >> >> For ice and i40e, it's similar, ice_tx_queue_release() is used to free >> txq, but some txq isn't saved into dev, please refer to >> ice_fdir_setup(), wrapper is needed. >> >> These 3 PMDs create rxq/txq that not saved in dev->data, can't change >> parameter to dev+qid for such case, that's why wrapper was there. >> > > Hi Ferruh, > > No response from qede, ice and i40e. Basically the original queue > release api is shared by private queues(not registered to ethdev), > can't access by index, that why a warpper was there. To avoid more > rebase in last minute for this big patch, do you think we could close > it? > I see the reason and since there is no update from maintainers, to keep the ball rolling agree to continue with wrappers, those PMDs can send incremental patches if required. > BTW, from feedback from hns3, I will post a new version to add the > macro. > I have concern about this one, how accessing to the global variable 'rte_eth_devices' via a macro improves the situation? Can you please make wrappers for hns3 driver too, we can follow it later with driver maintainer? Thanks, ferruh