From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A064641CF0; Mon, 20 Feb 2023 21:21:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 93BA9430EF; Mon, 20 Feb 2023 21:21:15 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 097BC430E4 for ; Mon, 20 Feb 2023 21:21:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676924474; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/akxUyeCnOX+jHCFqWmshUrqfCCBY7o9ZpAndOjFD4c=; b=TMeMCZtTHMjB/7CzzR5hixV+6zDkcgISpwCVoa1W34HhKBv8UJeXozn1kDIjht3J7yuHye IuiuG3zdHZtRPQ6UohMmTzRZNmtNgiHoZOGhaX69ZOJ7C3Z7PR4TW2aRaD6dYFT5gWru7W A9mRHXRD495r3Jhx8m1TFuLlaRXXWUw= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-7-6fP-NW_YNFuGR4SXsEyb_w-1; Mon, 20 Feb 2023 15:21:11 -0500 X-MC-Unique: 6fP-NW_YNFuGR4SXsEyb_w-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B48391C05198; Mon, 20 Feb 2023 20:21:10 +0000 (UTC) Received: from [10.39.208.21] (unknown [10.39.208.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 846682166B33; Mon, 20 Feb 2023 20:21:09 +0000 (UTC) Message-ID: <15ada1b5-4be5-ca0c-092c-e830bf1f1b4b@redhat.com> Date: Mon, 20 Feb 2023 21:21:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 07/16] test/bbdev: test start/stop bbdev API To: Hernan Vargas , dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com References: <20230215170949.60569-1-hernan.vargas@intel.com> <20230215170949.60569-8-hernan.vargas@intel.com> From: Maxime Coquelin In-Reply-To: <20230215170949.60569-8-hernan.vargas@intel.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/15/23 18:09, Hernan Vargas wrote: > Add a call to queue start and queue stop specifically for testing the > bbdev API. > > Signed-off-by: Hernan Vargas > --- > app/test-bbdev/test_bbdev_perf.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c > index 057fb5ac9e..e4eb71050a 100644 > --- a/app/test-bbdev/test_bbdev_perf.c > +++ b/app/test-bbdev/test_bbdev_perf.c > @@ -890,6 +890,7 @@ add_bbdev_dev(uint8_t dev_id, struct rte_bbdev_info *info, > ret = rte_bbdev_queue_configure(ad->dev_id, queue_id, > &qconf); > } > + rte_bbdev_queue_start(ad->dev_id, queue_id); You may want to check the return value, that would be useful since the goal is to test the API. > if (ret != 0) { > printf("All queues on dev %u allocated: %u\n", > dev_id, queue_id); > @@ -898,8 +899,8 @@ add_bbdev_dev(uint8_t dev_id, struct rte_bbdev_info *info, > ad->queue_ids[queue_id] = queue_id; > } > TEST_ASSERT(queue_id != 0, > - "ERROR Failed to configure any queues on dev %u", > - dev_id); > + "ERROR Failed to configure any queues on dev %u\n" > + "\tthe device may not support or have been configured", dev_id); > ad->nb_queues = queue_id; > > set_avail_op(ad, op_type); > @@ -3846,6 +3847,7 @@ throughput_pmd_lcore_ldpc_dec(void *arg) > TEST_ASSERT_SUCCESS(ret, "Validation failed!"); > } > > + rte_bbdev_queue_stop(tp->dev_id, queue_id); Ditto. > rte_bbdev_dec_op_free_bulk(ops_enq, num_ops); > > double tb_len_bits = calc_ldpc_dec_TB_size(ref_op);