From: "Raz Amir" <razamir22@gmail.com>
To: "'Ouyang, Changchun'" <changchun.ouyang@intel.com>,
"'Thomas Monjalon'" <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v3] Restore support for virtio on FreeBSD
Date: Tue, 14 Apr 2015 19:07:34 +0300 [thread overview]
Message-ID: <15dd01d076cd$1f412280$5dc36780$@gmail.com> (raw)
In-Reply-To: <F52918179C57134FAEC9EA62FA2F962511ABC531@shsmsx102.ccr.corp.intel.com>
Thomas, I will add more information to the commit message, but regarding
your feedback on the iopl comment, it is called also iopl on FreeBSD.
See this link to FreeBSD source code, for the io driver code - the flag name
is PSL_IOPL:
https://github.com/freebsd/freebsd/blob/master/sys/i386/i386/io.c#L38
Ouyang, I will implement your suggestion in the next patch version I submit.
-----Original Message-----
From: Ouyang, Changchun [mailto:changchun.ouyang@intel.com]
Sent: 14 April 2015 05:33
To: Thomas Monjalon; Raz Amir
Cc: dev@dpdk.org; Ouyang, Changchun
Subject: RE: [dpdk-dev] [PATCH v3] Restore support for virtio on FreeBSD
Hi
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Monday, April 13, 2015 8:55 PM
> To: Raz Amir
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3] Restore support for virtio on
> FreeBSD
>
> Please provide more information in the commit message.
> We need to know what was the problem (crash) in the git history.
> Then when doing git blame, we'll have the full explanation.
>
> 2015-04-13 15:19, Raz Amir:
> > Fixes: 8a312224bcde ("eal/bsd: fix fd leak")
> >
> > Signed-off-by: Raz Amir <razamir22@gmail.com>
> > ---
> > lib/librte_eal/bsdapp/eal/eal.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/librte_eal/bsdapp/eal/eal.c
> > b/lib/librte_eal/bsdapp/eal/eal.c index 871d5f4..e20f915 100644
> > --- a/lib/librte_eal/bsdapp/eal/eal.c
> > +++ b/lib/librte_eal/bsdapp/eal/eal.c
> > @@ -426,7 +426,7 @@ rte_eal_iopl_init(void)
> > fd = open("/dev/io", O_RDWR);
> > if (fd < 0)
> > return -1;
> > - close(fd);
> > + /* keep fd open for iopl */
Copy and paste my comment into this new patch:
Would you pls think about this solution?
Declare a static var to keep the fd which is opened for freebsd; Then define
a deinit function for virtio device, Inside the deinit function, close the
fd which was opened in init stage.
Done.
thanks
Changchun
next prev parent reply other threads:[~2015-04-14 16:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-07 23:45 [dpdk-dev] [PATCH] " Raz Amir
2015-04-07 23:48 ` [dpdk-dev] [PATCH v2] " Raz Amir
2015-04-13 12:19 ` [dpdk-dev] [PATCH v3] " Raz Amir
2015-04-13 12:54 ` Thomas Monjalon
2015-04-14 2:32 ` Ouyang, Changchun
2015-04-14 16:07 ` Raz Amir [this message]
2015-04-14 16:23 ` [dpdk-dev] [PATCH v5] " Raz Amir
2015-04-14 22:22 ` Ananyev, Konstantin
2015-04-16 3:31 ` Ouyang, Changchun
2015-04-16 7:50 ` Raz Amir
2015-04-16 8:02 ` [dpdk-dev] [PATCH v6] " Raz Amir
2015-04-16 9:39 ` Bruce Richardson
2015-04-16 11:44 ` Raz Amir
2015-04-16 11:52 ` [dpdk-dev] [PATCH v7] " Raz Amir
2015-04-28 14:18 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='15dd01d076cd$1f412280$5dc36780$@gmail.com' \
--to=razamir22@gmail.com \
--cc=changchun.ouyang@intel.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).