From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 84DF8AACA for ; Tue, 13 Mar 2018 15:46:52 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Mar 2018 07:46:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,465,1515484800"; d="scan'208";a="41583673" Received: from rhorton-mobl1.ger.corp.intel.com (HELO [163.33.230.232]) ([163.33.230.232]) by orsmga002.jf.intel.com with ESMTP; 13 Mar 2018 07:46:50 -0700 To: dev@dpdk.org References: <1520828243-25191-1-git-send-email-zijie.pan@6wind.com> <1520828243-25191-4-git-send-email-zijie.pan@6wind.com> Cc: Zijie Pan From: Remy Horton Organization: Intel Shannon Limited Message-ID: <15e2e186-0ca1-0998-8f28-caaf0f034f49@intel.com> Date: Tue, 13 Mar 2018 14:46:50 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1520828243-25191-4-git-send-email-zijie.pan@6wind.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 3/5] net/ixgbe: add module EEPROM callbacks for ixgbe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Mar 2018 14:46:52 -0000 On 12/03/2018 04:17, Zijie Pan wrote: [..] > Signed-off-by: Zijie Pan > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 76 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 76 insertions(+) Reviewed-by: Remy Horton > + if (addr_mode & IXGBE_SFF_ADDRESSING_MODE) { > + PMD_DRV_LOG(ERR, "Address change required to access page 0xA2, but not supported. Please report the module type to the driver maintainers."); Checkpatch: 80 characters