From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2392FA0548; Thu, 4 Nov 2021 13:07:46 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D6E63411A4; Thu, 4 Nov 2021 13:07:45 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 5741641144 for ; Thu, 4 Nov 2021 13:07:43 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10157"; a="231938374" X-IronPort-AV: E=Sophos;i="5.87,208,1631602800"; d="scan'208";a="231938374" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2021 05:07:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,208,1631602800"; d="scan'208";a="489923902" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga007.jf.intel.com with ESMTP; 04 Nov 2021 05:07:41 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 4 Nov 2021 05:07:41 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Thu, 4 Nov 2021 05:07:41 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Thu, 4 Nov 2021 05:07:41 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.48) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Thu, 4 Nov 2021 05:07:40 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QjZgXQeikxwPLh8GtgZr1UoeoTn9gAEkp8Lzy3N+TDdGUvieapP1wsvz2OCmw66IBUnXSbi7mOdILGZOOXA+4XykL1sBMHgCLFwXngSQPA1ojhcQSh+9lYD8RbqLlYm2t0ZSm8dDZ/s+uR7qXeD83DGouGMqKKREzyfE+C8aKjOlg9VcVOsUWNbmegw3j00IYEHtB23t/QwfXPyhK0WmKl9GjnYn8NpiUsSbc2Q1pILeZji470aOkibp4upagcLklACffCnZbah/KHK83HDG6lq3tMzHdNmIcshV9amxXP8y0diQsHIorRwOxf2l99/4INsaMsyhubSGmdHna8MDQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fKeN6vJ9zhNq8utR31j7wugdcTKV0EsVAz9Cw14QxB8=; b=dmtLSDrELBWKKfUUYLfRmB6sWdrA3oTg2lUXMe+FTltgQdTrrTW/LF+4TEjMqJrJFQgd5tTuXebk4YPnXAp8X2dWmrOy0Zz8A3B1D/UsA1JQTbZM0P6gWr/3cyIvPIrerRPTjjkeRfTWLpwRpO+8SvAhX8IXijvlhgnEbKg+W+8Ycwz0RHyEW/zrUtby32vu8DSg1gJrwLuy6VCfQkz/YiWwDKzUhtpnVlAASqqOOdRVlPF+H1h+kqkWFr54LRPlpiJ0Tc3TX5rPsBJviZYQcKbzRuYictYqxxG5XDLP8zkTQs8HKuCpLlXUjnfFQiLXU3g+SOu3WfQ749iDul/+pw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fKeN6vJ9zhNq8utR31j7wugdcTKV0EsVAz9Cw14QxB8=; b=O1YJodmnvLD2yH+jXwM3gV/IsNh14w2INF3wVmqMsmvvelYBwBc1aNvcHb8t368WDIOmlsrYY97LevCVJ/OnIjGd7IMcdGALat2EPpyCzDZ0OuO4QWlsemXcXVfkcY4i+OgZdW767MpPQZjOMyEAxgsKrYo4eGOodulnz5PiX6o= Authentication-Results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4790.namprd11.prod.outlook.com (2603:10b6:510:40::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.11; Thu, 4 Nov 2021 12:07:40 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%7]) with mapi id 15.20.4669.011; Thu, 4 Nov 2021 12:07:39 +0000 Message-ID: <15ebac73-1f33-7150-4084-2ba1ec675d41@intel.com> Date: Thu, 4 Nov 2021 12:07:33 +0000 Content-Language: en-US To: Tudor Cornea CC: , , , References: <1635868044-69456-1-git-send-email-tudor.cornea@gmail.com> <1635931891-27283-1-git-send-email-tudor.cornea@gmail.com> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <1635931891-27283-1-git-send-email-tudor.cornea@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LNXP265CA0048.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5c::36) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by LNXP265CA0048.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:5c::36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4669.10 via Frontend Transport; Thu, 4 Nov 2021 12:07:38 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2b2971d4-7042-4663-8fb5-08d99f8bb2a8 X-MS-TrafficTypeDiagnostic: PH0PR11MB4790: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 7jA5Vvbkpx1qP+f3CZqrH4k/UE4fF0JZuuKh8D9KLi6UigNGfaq4qTawzdhS1f098MwME0NquYaX+qbtVxnjvF85DQFKlS2qS/1UPjo2gRsldxwY8Pw6GIBuM/KCzy8JUUDzt33DsaIIeh6PYDPvG2vtkFw+3cMc8ROW/KGV++9zJ8cKj3mQ+4wnBXmYJR/SMuu4+XTxWRd0CCnL9ptPO5g9cOEdbqfmKCRbiYrptpUaQkRpxWb/R/FgUo6MksDPeejJNzWoFF1TLuHz4spa7LQOnOnoLHEJosb5n6uAsVAXEPlztc5xMSHj32eDG7qsvnUjv9Hdu9kXiksiQAgySTPNTVOpVUbJaLf3pDj+aZNv3PO+6EKnvtcabYq/nj0v05xODNoncFvb2gVH9Hj5M+zQasEtPuQlr8te3yZ3aEvqa800YLXGD9UQ8rwaLp9dAM3AsuFbLCOhEKjtQqMxC3XNqO1OQhmHY1eTi6MO3gSNft+q14nQfnL+m+LKLtg5ZsYbb3a+ZSVSNs6yRyW/28+qvCpObMxy2oWUlsjj+NtQCScFFTFrVBjE/FJEC+KrRUlI4e6J7aPzdXG18LzJjRY8GeTozhZJt4t5rTQL8qI1smu4bJT/733n6Pp6Pv1W238JIeKBljup+b/vMvciP4hV8wpSFZs5jcQvrNNWY35xhQtvWWtZwGEss7LQ9lQ4NLxEHR/Yw+EzPopnU+BBhQ0oNisPjZ1MwJI0mULNwqUshy4BQVQFdL9KKiq133gLn5VGRsLbT/2y2f8f51ah8QWMvrBz0dAqSS2hK6XL67A= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(316002)(6916009)(16576012)(44832011)(6666004)(6486002)(83380400001)(2906002)(31696002)(36756003)(66946007)(8936002)(2616005)(956004)(31686004)(8676002)(86362001)(53546011)(186003)(66556008)(66476007)(508600001)(4326008)(966005)(82960400001)(26005)(5660300002)(38100700002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TXRvUTF4NUZBb0lGbmNOUk9kUlVwa2lmWXNVYW5xa3kwTldLQ1VXd21xck44?= =?utf-8?B?dmhDTkdRQmQ0RFFGZVRrajlHYzRlMW1uajYybTR2N0dPcWZvOERSZURBNlpN?= =?utf-8?B?MnVqT3VYdnZhN0dkOFhJODdwdEd6TmJQNXFFL09kajU3VXY2ZGVONUppZ25q?= =?utf-8?B?M3pYNTVmWERwQVFyeFFoRklHc1owaW94ejkzRllNMGVUYjVYS2NaUW9pTGZs?= =?utf-8?B?L0M2bXF2MmNCSjEreUNkQUQyTllTUmpwL1Mwa2JSbVdBdkUvNS9NMjR0MS96?= =?utf-8?B?VUUzMWREaGhxVlBFb3dMN0NHMklvZHliL1FxYlcrd3RwN1BkcG4rY280V0p0?= =?utf-8?B?Vnc5Y0FmaVpva0lMdDNyeVlMMHZRUmtkeXFCYTY5dFBSTjdtVUtWOVRTeFhQ?= =?utf-8?B?NEh1TnRsY1JvMk9QQVZsT0VwSnRkK0dtWlNZek9lQklWZ2szTVplM2RvMUtF?= =?utf-8?B?cFBHZGU5SXhEL21zay8yQ0dENUowazJCRGVuWkZXSFBmQWhZVFZCSFRPUHFI?= =?utf-8?B?b1Nxcnh0czRqMVRsMnlhMHFIbXU1a1F6N2hUZzRkUXdkcUpvWGZzejhwck5G?= =?utf-8?B?N2UzY09TR3lmY3lPQUYrVlNUZ0NnYUE4RkJxVjNRcjJlMGxqTWhLYmsyY2xq?= =?utf-8?B?UWloY1NtWW01WVNxVkFpZUg1aTZGWVgvWHN5N0l6Qjh6ODhhZ0F3ZHZlQTYy?= =?utf-8?B?Q2lvayt1WnJtOXkzU2xMUnFaZGdsbktWdFpzZHE4ZUUzaVFMM2pLUzIzVHEv?= =?utf-8?B?dTk3cWlPWHRwNTNZN3NhR2RMNmxHSXVqR0FiZzQ2V3kxbnliTkFHbXBvY2xY?= =?utf-8?B?bUZIdThRL0NTcVdQRVBqMnN3Rnh3YUMwU21TOXJaTzRJanBiVVg2c09PRXVI?= =?utf-8?B?VzVNOWNTWTdsY1RKTFlpb2hsY0N6aTlJZTlVcU9rem1Ybm5xZHZxVVVETVkv?= =?utf-8?B?VmkxWjI5MFlvRW5XVnRXYkdvZlBSUGxjbEVtNGxvVjJpSTFSb1Z5UUM3eC9W?= =?utf-8?B?R0FtTHJ0ajJYNHlNc0dhNGlLOThZOE9MaDh2NTBYOWtxbXQwRmJWZ1ZlZHBo?= =?utf-8?B?RG9oK2VyeStsWkJORW5mRmxZbXVuSkk2YXdnYUJIc0V3bjM0cTJpY3krWVZl?= =?utf-8?B?N2lrSS9PdjVyVHBic2VaL0JUd0h6RzdEaFllSW83bno2VVpjZDVMeWJwQ0lB?= =?utf-8?B?a1E1VWZpKzhSUGNFa1Jqc1BUZHRld3NmQmxDR1c2cnN0ejB0TVRBQ1lNbUNp?= =?utf-8?B?M044YmMyUWdibkg2RFRxbWpwNEs5NUlnKzNlTWwzVWZlRzFRVENwWDJhNDVF?= =?utf-8?B?aUtjeFNudEJ5SGhwdmhrWklReFlhamxnemZOWkpJVHhFOE1vT2hNOGEyRW9F?= =?utf-8?B?OWJBeUZRMTFYbGJkTjk1YngzZVBBSlVTUDQzK2RFdGxOcGlGV2hBQmsrN3FV?= =?utf-8?B?Y2JlYXpFN0F0VVp4dmNleEd2dkpuSlNheWZMVlB6M3F2UnAyQnhHYS9qdCt6?= =?utf-8?B?ZVlLQ3psRy9iL1pCN3BMTTBXazI4azRtZC95cjhkU2J6MjJvTnRyekI0d2Yr?= =?utf-8?B?VDVPREpBWW5IcUJhRGlTdXdTL3BYMi8vNCtvQ1JjKzZlL2Jkb2YxZ0kyWll3?= =?utf-8?B?cUI5TDFJVFpHZ1V4Wm9zeCtObVdQbnpuUE9FU3FvU3VHckp1TXFQaEplS1Nt?= =?utf-8?B?RCt0S3k0M2ZIbTBFNVpPVkNwK084NHRuSE9OR1BSU3R6MzBsSnB3WERuZDRy?= =?utf-8?B?Qnd2VWJqNG5RcG5nREZBZmtib1F2QVMwclFSRU14UnMzaUc4MzJDRlYrZjlJ?= =?utf-8?B?Nmk2MS82a3FMOGV3WkhpSG10VkJLVjR3ZHhJaU05RW92SlU2RnlyaWxhU3NB?= =?utf-8?B?UzFoRXFadEVVYTZXaHFuMjlFVlBJWjBSdS8yU2gySjFnb3U4OHIwK1pZQkZo?= =?utf-8?B?UWdFQ1BjWmJEZ0JWRWs4bHhBVldBcTFBVDhibG85Z0kzbjJRWXJMSTVLb1dI?= =?utf-8?B?ZnZqSS81bUhiNitIL3dtYWdNdGdBdUFaZWNraDV4Y0F3bnhKUGdTN1NEWTR4?= =?utf-8?B?aXBTU0gxSVgwWHhKcXNqR0VPOEFKam1zQzJZbjBLSEdqa2pDYXRrM3BHaWRW?= =?utf-8?B?T3BQZDJZQnJ5VTNaRjg2NlFoTmxYYmd3Zm5GdDI4Q0xuOHZDU1JnUUg1elBr?= =?utf-8?Q?e2ew3BYnTbwPohZQ0bux19A=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 2b2971d4-7042-4663-8fb5-08d99f8bb2a8 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2021 12:07:39.9055 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: rK8R9Cfl9vFa3ofTRBMPd5YEcVH+czpE05sZk51TUj0XAadYWBXcMRr4L2QfDUtWDCTd+Mbs+N0J6SZzPl81cw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4790 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4] net/af_packet: fix ignoring full ring on tx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/3/2021 9:31 AM, Tudor Cornea wrote: > The poll call can return POLLERR which is ignored, or it can return > POLLOUT, even if there are no free frames in the mmap-ed area. > > We can account for both of these cases by re-checking if the next > frame is empty before writing into it. > > We have attempted to reproduce this issue with pktgen-dpdk, using the > following configuration. > > pktgen -l 1-4 -n 4 --proc-type=primary --no-pci --no-telemetry \ > --no-huge -m 512 \ > --vdev=net_af_packet0,iface=eth1,blocksz=16384,framesz=8192, \ > framecnt=2048,qpairs=1,qdisc_bypass=0 \ > -- \ > -P \ > -T \ > -m "3.0" \ > -f themes/black-yellow.theme > > We configure a low tx rate (~ 335 packets / second) and a small > packet size, of about 300 bytes from the pktgen CLI. > > set 0 size 300 > set 0 rate 0.008 > set 0 burst 1 > start 0 > > After bringing the interface down, and up again, we seem to arrive > in a state in which the tx rate is inconsistent, and does not recover. > > ifconfig eth1 down; sleep 7; ifconfig eth1 up > > [1] http://code.dpdk.org/pktgen-dpdk/pktgen-20.11.2/source/INSTALL.md > > Signed-off-by: Mihai Pogonaru > Signed-off-by: Tudor Cornea > Reviewed-by: Ferruh Yigit Used comment from v3, only POLLERR related part kept as in this patch. Fixes: 364e08f2bbc0 ("af_packet: add PMD for AF_PACKET-based virtual devices") Cc: stable@dpdk.org Applied to dpdk-next-net/main, thanks.