From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8454DA00C4; Fri, 5 Aug 2022 10:01:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4ACD142C1E; Fri, 5 Aug 2022 10:01:24 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 0C5C8400D5 for ; Fri, 5 Aug 2022 10:01:23 +0200 (CEST) Received: from [192.168.1.39] (unknown [188.170.75.116]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 525A7A5; Fri, 5 Aug 2022 11:01:22 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 525A7A5 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1659686482; bh=26o0NyKreMNmTWjo9Ds+lWs8v4rj5nYKWjUUUZxEL7s=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=vNzckzcIchvv488XiwaxN3mcElQFTs7aKG0EzlbAx3PQRGvsxtBjP/MXzwSkQfCl9 zi8xNRsCY9dVoSbDiwIXnc7ZKFPBsJjOxvqjuhY6h2AvQTN1GVP1FH+E9DVswymv1W 0Jqtu7jdpN6BMak9qB3ytBHBWflnGrIDgSpusv2g= Message-ID: <15fc2ac6-29ce-35e2-417b-6332caf0d6ec@oktetlabs.ru> Date: Fri, 5 Aug 2022 11:01:09 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 00/10] ethdev: cleanup deprecated defines Content-Language: en-US To: Stephen Hemminger Cc: Thomas Monjalon , Ferruh Yigit , dev@dpdk.org References: <20220804190602.1045171-1-andrew.rybchenko@oktetlabs.ru> <20220804122912.484c8a79@hermes.local> From: Andrew Rybchenko In-Reply-To: <20220804122912.484c8a79@hermes.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 8/4/22 22:29, Stephen Hemminger wrote: > On Thu, 4 Aug 2022 22:05:52 +0300 > Andrew Rybchenko wrote: > >> Remove deprecated because of invalid namespace defines. >> >> Andrew Rybchenko (10): >> ethdev: remove deprecated link speed and duplex defines >> ethdev: remove deprecated Rx and Tx multi-queue mode defines >> ethdev: remove deprecated defines for RSS configuration >> ethdev: remove deprecated Rx and Tx offload defines >> ethdev: remove deprecated DCB and VMDq defines >> ethdev: remove deprecated tunnel type defines >> ethdev: remove deprecated flow control defines >> ethdev: remove deprecated VLAN offload configuration defines >> ethdev: remove deprecated maximum Rx MAC addresses define >> ethdev: remove deprecated metadata dynamic fields defines >> >> doc/guides/rel_notes/release_22_11.rst | 34 ++++ >> lib/ethdev/rte_ethdev.h | 242 ------------------------- >> lib/ethdev/rte_flow.h | 4 - >> 3 files changed, 34 insertions(+), 246 deletions(-) >> > > > Looks good. I assume the flow director (FDIR) defines should also > go away in this release when it is removed. Yes, I wanted but simply forgot to mention it in the cover letter. FDIR defines are covered by fdir cleanup patch series [1]. I decided that it does not deserve separate patch. [1] https://patches.dpdk.org/project/dpdk/patch/20220803111358.375544-4-andrew.rybchenko@oktetlabs.ru/ > > Series-Acked-by: Stephen Hemminger Thanks for the review, Stephen.