From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 07F0BA04C7;
Wed, 16 Sep 2020 10:24:25 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 2FDB91C205;
Wed, 16 Sep 2020 10:24:18 +0200 (CEST)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
by dpdk.org (Postfix) with ESMTP id 3CF211C202
for <dev@dpdk.org>; Wed, 16 Sep 2020 10:24:13 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BFBE8101E;
Wed, 16 Sep 2020 01:24:12 -0700 (PDT)
Received: from phil-VirtualBox.shanghai.arm.com
(phil-VirtualBox.shanghai.arm.com [10.169.182.49])
by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 95A783F718;
Wed, 16 Sep 2020 01:24:10 -0700 (PDT)
From: Phil Yang <phil.yang@arm.com>
To: david.marchand@redhat.com,
dev@dpdk.org
Cc: Honnappa.Nagarahalli@arm.com, Ruifeng.Wang@arm.com, nd@arm.com,
Nicolas Chautru <nicolas.chautru@intel.com>
Date: Wed, 16 Sep 2020 16:23:46 +0800
Message-Id: <1600244628-13062-3-git-send-email-phil.yang@arm.com>
X-Mailer: git-send-email 2.7.4
In-Reply-To: <1600244628-13062-1-git-send-email-phil.yang@arm.com>
References: <1599794967-17500-1-git-send-email-phil.yang@arm.com>
<1600244628-13062-1-git-send-email-phil.yang@arm.com>
Subject: [dpdk-dev] [PATCH v2 2/4] bbdev: use C11 atomic builtins for device
processing counter
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Since rte_atomicXX APIs are not allowed to be used, use C11 atomic builtins
for device processing counter.
Signed-off-by: Phil Yang <phil.yang@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
---
lib/librte_bbdev/rte_bbdev.c | 5 +++--
lib/librte_bbdev/rte_bbdev.h | 4 +---
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/lib/librte_bbdev/rte_bbdev.c b/lib/librte_bbdev/rte_bbdev.c
index a4fdb69..5ba891c 100644
--- a/lib/librte_bbdev/rte_bbdev.c
+++ b/lib/librte_bbdev/rte_bbdev.c
@@ -210,7 +210,7 @@ rte_bbdev_allocate(const char *name)
return NULL;
}
- rte_atomic16_inc(&bbdev->data->process_cnt);
+ __atomic_add_fetch(&bbdev->data->process_cnt, 1, __ATOMIC_RELAXED);
bbdev->data->dev_id = dev_id;
bbdev->state = RTE_BBDEV_INITIALIZED;
@@ -252,7 +252,8 @@ rte_bbdev_release(struct rte_bbdev *bbdev)
}
/* clear shared BBDev Data if no process is using the device anymore */
- if (rte_atomic16_dec_and_test(&bbdev->data->process_cnt))
+ if (__atomic_sub_fetch(&bbdev->data->process_cnt, 1,
+ __ATOMIC_RELAXED) == 0)
memset(bbdev->data, 0, sizeof(*bbdev->data));
memset(bbdev, 0, sizeof(*bbdev));
diff --git a/lib/librte_bbdev/rte_bbdev.h b/lib/librte_bbdev/rte_bbdev.h
index 5729137..7017124 100644
--- a/lib/librte_bbdev/rte_bbdev.h
+++ b/lib/librte_bbdev/rte_bbdev.h
@@ -33,7 +33,6 @@ extern "C" {
#include <string.h>
#include <rte_compat.h>
-#include <rte_atomic.h>
#include <rte_bus.h>
#include <rte_cpuflags.h>
#include <rte_memory.h>
@@ -426,8 +425,7 @@ struct rte_bbdev_data {
uint16_t dev_id; /**< Device ID */
int socket_id; /**< NUMA socket that device is on */
bool started; /**< Device run-time state */
- /** Counter of processes using the device */
- rte_atomic16_t process_cnt;
+ uint16_t process_cnt; /** Counter of processes using the device */
};
/* Forward declarations */
--
2.7.4