DPDK patches and discussions
 help / color / Atom feed
* [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf issue
@ 2020-09-17  1:14 Abhinandan Gujjar
  2020-09-22 19:29 ` Akhil Goyal
  0 siblings, 1 reply; 9+ messages in thread
From: Abhinandan Gujjar @ 2020-09-17  1:14 UTC (permalink / raw)
  To: dev, jerinj; +Cc: narender.vangati, abhinandan.gujjar

This patch updates the xform with right configuration.
For session based ops, sym session pool is created with
valid userdata size.

Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
---
 app/test/test_event_crypto_adapter.c | 24 +++++-------------------
 1 file changed, 5 insertions(+), 19 deletions(-)

diff --git a/app/test/test_event_crypto_adapter.c b/app/test/test_event_crypto_adapter.c
index 8d42462..530ce96 100644
--- a/app/test/test_event_crypto_adapter.c
+++ b/app/test/test_event_crypto_adapter.c
@@ -171,7 +171,6 @@ struct rte_event_crypto_request request_info = {
 	struct rte_event ev;
 	uint32_t cap;
 	int ret;
-	uint8_t cipher_key[17];
 
 	memset(&m_data, 0, sizeof(m_data));
 
@@ -183,14 +182,7 @@ struct rte_event_crypto_request request_info = {
 	/* Setup Cipher Parameters */
 	cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
 	cipher_xform.next = NULL;
-
-	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC;
-	cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
-
-	cipher_xform.cipher.key.data = cipher_key;
-	cipher_xform.cipher.key.length = 16;
-	cipher_xform.cipher.iv.offset = IV_OFFSET;
-	cipher_xform.cipher.iv.length = 16;
+	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
 
 	op = rte_crypto_op_alloc(params.op_mpool,
 			RTE_CRYPTO_OP_TYPE_SYMMETRIC);
@@ -378,7 +370,6 @@ struct rte_event_crypto_request request_info = {
 	struct rte_mbuf *m;
 	uint32_t cap;
 	int ret;
-	uint8_t cipher_key[17];
 
 	memset(&m_data, 0, sizeof(m_data));
 
@@ -390,14 +381,7 @@ struct rte_event_crypto_request request_info = {
 	/* Setup Cipher Parameters */
 	cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
 	cipher_xform.next = NULL;
-
-	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC;
-	cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
-
-	cipher_xform.cipher.key.data = cipher_key;
-	cipher_xform.cipher.key.length = 16;
-	cipher_xform.cipher.iv.offset = IV_OFFSET;
-	cipher_xform.cipher.iv.length = 16;
+	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
 
 	op = rte_crypto_op_alloc(params.op_mpool,
 			RTE_CRYPTO_OP_TYPE_SYMMETRIC);
@@ -564,7 +548,9 @@ struct rte_event_crypto_request request_info = {
 
 	params.session_mpool = rte_cryptodev_sym_session_pool_create(
 			"CRYPTO_ADAPTER_SESSION_MP",
-			MAX_NB_SESSIONS, 0, 0, 0, SOCKET_ID_ANY);
+			MAX_NB_SESSIONS, 0, 0,
+			sizeof(union rte_event_crypto_metadata),
+			SOCKET_ID_ANY);
 	TEST_ASSERT_NOT_NULL(params.session_mpool,
 			"session mempool allocation failed\n");
 
-- 
1.9.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf issue
  2020-09-17  1:14 [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf issue Abhinandan Gujjar
@ 2020-09-22 19:29 ` Akhil Goyal
  2020-09-23  7:10   ` Gujjar, Abhinandan S
  0 siblings, 1 reply; 9+ messages in thread
From: Akhil Goyal @ 2020-09-22 19:29 UTC (permalink / raw)
  To: Abhinandan Gujjar, dev, jerinj; +Cc: narender.vangati

Hi Abhinandan,

> This patch updates the xform with right configuration.
> For session based ops, sym session pool is created with
> valid userdata size.
> 
> Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> ---
The patch description do not match with the patch.
I can see that you are changing the cipher algo from AES-CBC to NULL
Without explaining the reason.
Could you please clarify the need of this patch.

Regards,
Akhil


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf issue
  2020-09-22 19:29 ` Akhil Goyal
@ 2020-09-23  7:10   ` Gujjar, Abhinandan S
  2020-10-06 10:25     ` Gujjar, Abhinandan S
  0 siblings, 1 reply; 9+ messages in thread
From: Gujjar, Abhinandan S @ 2020-09-23  7:10 UTC (permalink / raw)
  To: Akhil Goyal, dev, jerinj; +Cc: Vangati, Narender

Hi Akhil,

Recently, I observed that test was failing with sw adapter.
I noticed that, it was because of some changes went in related to crypto in the past releases.
One of the tests, configures a session in turn calls null_crypto_set_session_parameters()
which checks for params was failing. As part of fixing & updating the xforms to address this issue,
thought of getting rid of algo as well, to make the test simpler. The test continues to use null cryptodev
and does not deal with any encryption or auth.

Regards
Abhinandan

> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Wednesday, September 23, 2020 12:59 AM
> To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>; dev@dpdk.org;
> jerinj@marvell.com
> Cc: Vangati, Narender <narender.vangati@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf issue
> 
> Hi Abhinandan,
> 
> > This patch updates the xform with right configuration.
> > For session based ops, sym session pool is created with valid userdata
> > size.
> >
> > Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> > ---
> The patch description do not match with the patch.
> I can see that you are changing the cipher algo from AES-CBC to NULL
> Without explaining the reason.
> Could you please clarify the need of this patch.
> 
> Regards,
> Akhil


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf issue
  2020-09-23  7:10   ` Gujjar, Abhinandan S
@ 2020-10-06 10:25     ` Gujjar, Abhinandan S
  2020-10-09 19:01       ` Akhil Goyal
  0 siblings, 1 reply; 9+ messages in thread
From: Gujjar, Abhinandan S @ 2020-10-06 10:25 UTC (permalink / raw)
  To: Akhil Goyal, dev, jerinj; +Cc: Vangati, Narender

Hi Akhil,

If the patch is ok, could you please ack it?

Regards
Abhinandan

> -----Original Message-----
> From: Gujjar, Abhinandan S
> Sent: Wednesday, September 23, 2020 12:41 PM
> To: Akhil Goyal <akhil.goyal@nxp.com>; dev@dpdk.org; jerinj@marvell.com
> Cc: Vangati, Narender <narender.vangati@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf issue
> 
> Hi Akhil,
> 
> Recently, I observed that test was failing with sw adapter.
> I noticed that, it was because of some changes went in related to crypto in
> the past releases.
> One of the tests, configures a session in turn calls
> null_crypto_set_session_parameters()
> which checks for params was failing. As part of fixing & updating the xforms
> to address this issue, thought of getting rid of algo as well, to make the test
> simpler. The test continues to use null cryptodev and does not deal with any
> encryption or auth.
> 
> Regards
> Abhinandan
> 
> > -----Original Message-----
> > From: Akhil Goyal <akhil.goyal@nxp.com>
> > Sent: Wednesday, September 23, 2020 12:59 AM
> > To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>; dev@dpdk.org;
> > jerinj@marvell.com
> > Cc: Vangati, Narender <narender.vangati@intel.com>
> > Subject: RE: [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf
> > issue
> >
> > Hi Abhinandan,
> >
> > > This patch updates the xform with right configuration.
> > > For session based ops, sym session pool is created with valid
> > > userdata size.
> > >
> > > Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> > > ---
> > The patch description do not match with the patch.
> > I can see that you are changing the cipher algo from AES-CBC to NULL
> > Without explaining the reason.
> > Could you please clarify the need of this patch.
> >
> > Regards,
> > Akhil


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf issue
  2020-10-06 10:25     ` Gujjar, Abhinandan S
@ 2020-10-09 19:01       ` Akhil Goyal
  2020-10-12  6:24         ` Gujjar, Abhinandan S
  0 siblings, 1 reply; 9+ messages in thread
From: Akhil Goyal @ 2020-10-09 19:01 UTC (permalink / raw)
  To: Gujjar, Abhinandan S, dev, jerinj; +Cc: Vangati, Narender

Hi Abhinandan,

> Hi Akhil,
> 
> If the patch is ok, could you please ack it?
> 
Could you please send the Fixes tag for the original patch which introduced this
Issue? I will add it while applying the patch.

Acked-by: Akhil Goyal <akhil.goyal@nxp.com>


> >
> > Hi Akhil,
> >
> > Recently, I observed that test was failing with sw adapter.
> > I noticed that, it was because of some changes went in related to crypto in
> > the past releases.
> > One of the tests, configures a session in turn calls
> > null_crypto_set_session_parameters()
> > which checks for params was failing. As part of fixing & updating the xforms
> > to address this issue, thought of getting rid of algo as well, to make the test
> > simpler. The test continues to use null cryptodev and does not deal with any
> > encryption or auth.
> >
> > Regards
> > Abhinandan
> >
> > > -----Original Message-----
> > > From: Akhil Goyal <akhil.goyal@nxp.com>
> > > Sent: Wednesday, September 23, 2020 12:59 AM
> > > To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>; dev@dpdk.org;
> > > jerinj@marvell.com
> > > Cc: Vangati, Narender <narender.vangati@intel.com>
> > > Subject: RE: [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf
> > > issue
> > >
> > > Hi Abhinandan,
> > >
> > > > This patch updates the xform with right configuration.
> > > > For session based ops, sym session pool is created with valid
> > > > userdata size.
> > > >
> > > > Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> > > > ---
> > > The patch description do not match with the patch.
> > > I can see that you are changing the cipher algo from AES-CBC to NULL
> > > Without explaining the reason.
> > > Could you please clarify the need of this patch.
> > >
> > > Regards,
> > > Akhil


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf issue
  2020-10-09 19:01       ` Akhil Goyal
@ 2020-10-12  6:24         ` Gujjar, Abhinandan S
  2020-10-12 19:29           ` Akhil Goyal
  0 siblings, 1 reply; 9+ messages in thread
From: Gujjar, Abhinandan S @ 2020-10-12  6:24 UTC (permalink / raw)
  To: Akhil Goyal, dev, jerinj; +Cc: Vangati, Narender

Hi Akhil,

This was introduced in patch (24054e3640a2).

Fixes: 24054e3640a2 ("test/crypto: use separate session mempools")

Thanks
Abhinandan

> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Saturday, October 10, 2020 12:32 AM
> To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>; dev@dpdk.org;
> jerinj@marvell.com
> Cc: Vangati, Narender <narender.vangati@intel.com>
> Subject: RE: [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf issue
> 
> Hi Abhinandan,
> 
> > Hi Akhil,
> >
> > If the patch is ok, could you please ack it?
> >
> Could you please send the Fixes tag for the original patch which introduced this
> Issue? I will add it while applying the patch.
> 
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
> 
> 
> > >
> > > Hi Akhil,
> > >
> > > Recently, I observed that test was failing with sw adapter.
> > > I noticed that, it was because of some changes went in related to
> > > crypto in the past releases.
> > > One of the tests, configures a session in turn calls
> > > null_crypto_set_session_parameters()
> > > which checks for params was failing. As part of fixing & updating
> > > the xforms to address this issue, thought of getting rid of algo as
> > > well, to make the test simpler. The test continues to use null
> > > cryptodev and does not deal with any encryption or auth.
> > >
> > > Regards
> > > Abhinandan
> > >
> > > > -----Original Message-----
> > > > From: Akhil Goyal <akhil.goyal@nxp.com>
> > > > Sent: Wednesday, September 23, 2020 12:59 AM
> > > > To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>;
> > > > dev@dpdk.org; jerinj@marvell.com
> > > > Cc: Vangati, Narender <narender.vangati@intel.com>
> > > > Subject: RE: [dpdk-dev] [PATCH] test/event_crypto_adapter: fix
> > > > conf issue
> > > >
> > > > Hi Abhinandan,
> > > >
> > > > > This patch updates the xform with right configuration.
> > > > > For session based ops, sym session pool is created with valid
> > > > > userdata size.
> > > > >
> > > > > Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> > > > > ---
> > > > The patch description do not match with the patch.
> > > > I can see that you are changing the cipher algo from AES-CBC to
> > > > NULL Without explaining the reason.
> > > > Could you please clarify the need of this patch.
> > > >
> > > > Regards,
> > > > Akhil


^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf issue
  2020-10-12  6:24         ` Gujjar, Abhinandan S
@ 2020-10-12 19:29           ` Akhil Goyal
  0 siblings, 0 replies; 9+ messages in thread
From: Akhil Goyal @ 2020-10-12 19:29 UTC (permalink / raw)
  To: Gujjar, Abhinandan S, dev, jerinj; +Cc: Vangati, Narender

> Hi Akhil,
> 
> This was introduced in patch (24054e3640a2).
> 
> Fixes: 24054e3640a2 ("test/crypto: use separate session mempools")
> 
Applied to dpdk-next-crypto

Cc: stable@dpdk.org

Thanks.



^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf issue
  2020-09-17  0:57 Abhinandan Gujjar
@ 2020-09-18 10:08 ` Gujjar, Abhinandan S
  0 siblings, 0 replies; 9+ messages in thread
From: Gujjar, Abhinandan S @ 2020-09-18 10:08 UTC (permalink / raw)
  To: dev, jerinj

Please disregard the patch. Didn't realizes commented changes for meson.

> -----Original Message-----
> From: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
> Sent: Thursday, September 17, 2020 6:28 AM
> To: dev@dpdk.org; jerinj@marvell.com
> Cc: Vangati, Narender <narender.vangati@intel.com>; Gujjar, Abhinandan S
> <abhinandan.gujjar@intel.com>
> Subject: [PATCH] test/event_crypto_adapter: fix conf issue
> 
> This patch updates the xform with right configuration.
> For session based ops, sym session pool is created with valid userdata size.
> 
> Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>
> 
> ---
>  app/test/test_event_crypto_adapter.c | 24 +++++-------------------
>  drivers/crypto/meson.build           | 12 ++++++------
>  2 files changed, 11 insertions(+), 25 deletions(-)
> 
> diff --git a/app/test/test_event_crypto_adapter.c
> b/app/test/test_event_crypto_adapter.c
> index 8d42462..530ce96 100644
> --- a/app/test/test_event_crypto_adapter.c
> +++ b/app/test/test_event_crypto_adapter.c
> @@ -171,7 +171,6 @@ struct rte_event_crypto_request request_info = {
>  	struct rte_event ev;
>  	uint32_t cap;
>  	int ret;
> -	uint8_t cipher_key[17];
> 
>  	memset(&m_data, 0, sizeof(m_data));
> 
> @@ -183,14 +182,7 @@ struct rte_event_crypto_request request_info = {
>  	/* Setup Cipher Parameters */
>  	cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
>  	cipher_xform.next = NULL;
> -
> -	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC;
> -	cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
> -
> -	cipher_xform.cipher.key.data = cipher_key;
> -	cipher_xform.cipher.key.length = 16;
> -	cipher_xform.cipher.iv.offset = IV_OFFSET;
> -	cipher_xform.cipher.iv.length = 16;
> +	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
> 
>  	op = rte_crypto_op_alloc(params.op_mpool,
>  			RTE_CRYPTO_OP_TYPE_SYMMETRIC);
> @@ -378,7 +370,6 @@ struct rte_event_crypto_request request_info = {
>  	struct rte_mbuf *m;
>  	uint32_t cap;
>  	int ret;
> -	uint8_t cipher_key[17];
> 
>  	memset(&m_data, 0, sizeof(m_data));
> 
> @@ -390,14 +381,7 @@ struct rte_event_crypto_request request_info = {
>  	/* Setup Cipher Parameters */
>  	cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
>  	cipher_xform.next = NULL;
> -
> -	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC;
> -	cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
> -
> -	cipher_xform.cipher.key.data = cipher_key;
> -	cipher_xform.cipher.key.length = 16;
> -	cipher_xform.cipher.iv.offset = IV_OFFSET;
> -	cipher_xform.cipher.iv.length = 16;
> +	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
> 
>  	op = rte_crypto_op_alloc(params.op_mpool,
>  			RTE_CRYPTO_OP_TYPE_SYMMETRIC);
> @@ -564,7 +548,9 @@ struct rte_event_crypto_request request_info = {
> 
>  	params.session_mpool = rte_cryptodev_sym_session_pool_create(
>  			"CRYPTO_ADAPTER_SESSION_MP",
> -			MAX_NB_SESSIONS, 0, 0, 0, SOCKET_ID_ANY);
> +			MAX_NB_SESSIONS, 0, 0,
> +			sizeof(union rte_event_crypto_metadata),
> +			SOCKET_ID_ANY);
>  	TEST_ASSERT_NOT_NULL(params.session_mpool,
>  			"session mempool allocation failed\n");
> 
> diff --git a/drivers/crypto/meson.build b/drivers/crypto/meson.build index
> a242350..149a8e1 100644
> --- a/drivers/crypto/meson.build
> +++ b/drivers/crypto/meson.build
> @@ -5,14 +5,14 @@ if is_windows
>  	subdir_done()
>  endif
> 
> -drivers = ['aesni_gcm',
> -	   'aesni_mb',
> +drivers = [#'aesni_gcm',
> +	   #'aesni_mb',
>  	   'armv8',
>  	   'caam_jr',
>  	   'ccp',
>  	   'dpaa_sec',
>  	   'dpaa2_sec',
> -	   'kasumi',
> +	  # 'kasumi',
>  	   'mvsam',
>  	   'nitrox',
>  	   'null',
> @@ -21,9 +21,9 @@ drivers = ['aesni_gcm',
>  	   'openssl',
>  	   'qat',
>  	   'scheduler',
> -	   'snow3g',
> -	   'virtio',
> -	   'zuc']
> +	   #'snow3g',
> +	   'virtio']
> +	   #'zuc']
> 
>  std_deps = ['cryptodev'] # cryptodev pulls in all other needed deps
> config_flag_fmt = 'RTE_LIBRTE_@0@_PMD'
> --
> 1.9.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

* [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf issue
@ 2020-09-17  0:57 Abhinandan Gujjar
  2020-09-18 10:08 ` Gujjar, Abhinandan S
  0 siblings, 1 reply; 9+ messages in thread
From: Abhinandan Gujjar @ 2020-09-17  0:57 UTC (permalink / raw)
  To: dev, jerinj; +Cc: narender.vangati, abhinandan.gujjar

This patch updates the xform with right configuration.
For session based ops, sym session pool is created with
valid userdata size.

Signed-off-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>

---
 app/test/test_event_crypto_adapter.c | 24 +++++-------------------
 drivers/crypto/meson.build           | 12 ++++++------
 2 files changed, 11 insertions(+), 25 deletions(-)

diff --git a/app/test/test_event_crypto_adapter.c b/app/test/test_event_crypto_adapter.c
index 8d42462..530ce96 100644
--- a/app/test/test_event_crypto_adapter.c
+++ b/app/test/test_event_crypto_adapter.c
@@ -171,7 +171,6 @@ struct rte_event_crypto_request request_info = {
 	struct rte_event ev;
 	uint32_t cap;
 	int ret;
-	uint8_t cipher_key[17];
 
 	memset(&m_data, 0, sizeof(m_data));
 
@@ -183,14 +182,7 @@ struct rte_event_crypto_request request_info = {
 	/* Setup Cipher Parameters */
 	cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
 	cipher_xform.next = NULL;
-
-	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC;
-	cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
-
-	cipher_xform.cipher.key.data = cipher_key;
-	cipher_xform.cipher.key.length = 16;
-	cipher_xform.cipher.iv.offset = IV_OFFSET;
-	cipher_xform.cipher.iv.length = 16;
+	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
 
 	op = rte_crypto_op_alloc(params.op_mpool,
 			RTE_CRYPTO_OP_TYPE_SYMMETRIC);
@@ -378,7 +370,6 @@ struct rte_event_crypto_request request_info = {
 	struct rte_mbuf *m;
 	uint32_t cap;
 	int ret;
-	uint8_t cipher_key[17];
 
 	memset(&m_data, 0, sizeof(m_data));
 
@@ -390,14 +381,7 @@ struct rte_event_crypto_request request_info = {
 	/* Setup Cipher Parameters */
 	cipher_xform.type = RTE_CRYPTO_SYM_XFORM_CIPHER;
 	cipher_xform.next = NULL;
-
-	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_AES_CBC;
-	cipher_xform.cipher.op = RTE_CRYPTO_CIPHER_OP_ENCRYPT;
-
-	cipher_xform.cipher.key.data = cipher_key;
-	cipher_xform.cipher.key.length = 16;
-	cipher_xform.cipher.iv.offset = IV_OFFSET;
-	cipher_xform.cipher.iv.length = 16;
+	cipher_xform.cipher.algo = RTE_CRYPTO_CIPHER_NULL;
 
 	op = rte_crypto_op_alloc(params.op_mpool,
 			RTE_CRYPTO_OP_TYPE_SYMMETRIC);
@@ -564,7 +548,9 @@ struct rte_event_crypto_request request_info = {
 
 	params.session_mpool = rte_cryptodev_sym_session_pool_create(
 			"CRYPTO_ADAPTER_SESSION_MP",
-			MAX_NB_SESSIONS, 0, 0, 0, SOCKET_ID_ANY);
+			MAX_NB_SESSIONS, 0, 0,
+			sizeof(union rte_event_crypto_metadata),
+			SOCKET_ID_ANY);
 	TEST_ASSERT_NOT_NULL(params.session_mpool,
 			"session mempool allocation failed\n");
 
diff --git a/drivers/crypto/meson.build b/drivers/crypto/meson.build
index a242350..149a8e1 100644
--- a/drivers/crypto/meson.build
+++ b/drivers/crypto/meson.build
@@ -5,14 +5,14 @@ if is_windows
 	subdir_done()
 endif
 
-drivers = ['aesni_gcm',
-	   'aesni_mb',
+drivers = [#'aesni_gcm',
+	   #'aesni_mb',
 	   'armv8',
 	   'caam_jr',
 	   'ccp',
 	   'dpaa_sec',
 	   'dpaa2_sec',
-	   'kasumi',
+	  # 'kasumi',
 	   'mvsam',
 	   'nitrox',
 	   'null',
@@ -21,9 +21,9 @@ drivers = ['aesni_gcm',
 	   'openssl',
 	   'qat',
 	   'scheduler',
-	   'snow3g',
-	   'virtio',
-	   'zuc']
+	   #'snow3g',
+	   'virtio']
+	   #'zuc']
 
 std_deps = ['cryptodev'] # cryptodev pulls in all other needed deps
 config_flag_fmt = 'RTE_LIBRTE_@0@_PMD'
-- 
1.9.1


^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, back to index

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-17  1:14 [dpdk-dev] [PATCH] test/event_crypto_adapter: fix conf issue Abhinandan Gujjar
2020-09-22 19:29 ` Akhil Goyal
2020-09-23  7:10   ` Gujjar, Abhinandan S
2020-10-06 10:25     ` Gujjar, Abhinandan S
2020-10-09 19:01       ` Akhil Goyal
2020-10-12  6:24         ` Gujjar, Abhinandan S
2020-10-12 19:29           ` Akhil Goyal
  -- strict thread matches above, loose matches on Subject: below --
2020-09-17  0:57 Abhinandan Gujjar
2020-09-18 10:08 ` Gujjar, Abhinandan S

DPDK patches and discussions

Archives are clonable:
	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox