From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id AB4C25B3A for ; Mon, 22 Oct 2018 16:02:17 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4638221687; Mon, 22 Oct 2018 10:02:17 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 22 Oct 2018 10:02:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=+n7Av3X01zzYPLKoNfGB++8TSGGu9DQwEZWW0SErmck=; b=KEyG3vG8Rp6A sYKNZ/2cyXYNR+2vjXI5QdU130F0A8A20CePsNkDQGdsI3Vyri6nDDGYJiS3VrrZ YeOdjB57Nvww7ZHDYuTEnDB3JXqNM19yHTiliRYhYz+nZN4XERTgZBrg952j9nb/ 9CuRy0xA5Q5hKEUYNvS5pxxaM7873bs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=+n7Av3X01zzYPLKoNfGB++8TSGGu9DQwEZWW0SErm ck=; b=bbXhTVfvbMlzbpk/ep07pZ/FH62AXDfJsAcv2Me4lLowCCjbRW9wkYsga CmuBCPg7Tjm8J381fFd0evT0gtp36LiVMFRqSnJCHuyh4VQaChrOgiEJ6N+iYwJK QX0/YpcaoLGOdp9dGQYbkua94PMRbPP0OSOv9b6jlSPH4Cusi/ysFFUjIe8KYpwN snMrSaRbH9nQ6BFOy5bUFJfzlg4eEQULxCTdfl+ssaP7ue39uidGHi2jiOWMeuM/ dHi8BboEnea6zdHUweXCd14l+EgbghxTD2pG3FQ1wGWUe/m+VhNkFKykXNdgnao7 +QRaE7SRxeVxP3772IEWNlJBEmsLA== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 00A1DE421C; Mon, 22 Oct 2018 10:02:14 -0400 (EDT) From: Thomas Monjalon To: Andrew Rybchenko Cc: dev@dpdk.org, gaetan.rivet@6wind.com, ophirmu@mellanox.com, ferruh.yigit@intel.com, olivier.matz@6wind.com, remy.horton@intel.com, bruce.richardson@intel.com, olivier.matz@6wind.com Date: Mon, 22 Oct 2018 16:02:17 +0200 Message-ID: <1600652.GbAxOGCmMO@xps> In-Reply-To: References: <20181009021858.19216-1-thomas@monjalon.net> <20181022131530.6403-5-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 4/4] ethdev: support MAC address as iterator filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Oct 2018 14:02:17 -0000 22/10/2018 15:37, Andrew Rybchenko: > On 10/22/18 4:15 PM, Thomas Monjalon wrote: > > The MAC addresses of a port can be matched with devargs. > > > > As the conflict between rte_ether.h and netinet/ether.h is not resolved, > > the MAC parsing is done with a rte_cmdline function. > > As a result, cmdline library becomes a dependency of ethdev. > > > > Signed-off-by: Thomas Monjalon > > I'd like to share my thought about a new dependency. > Looking at cmdline I think that it is a bad and strange > dependency for kvargs. IMHO, even duplication of the > code to parse MAC address it less evil in this case. cmdline is not a dependency for kvargs. I have added it as a dependency for ethdev. > May be it is possible to provide internal wrapper > which is implemented using ether_aton_r() and located > in a separate C file which does not include rte_ether.h etc? I raised the issue in technical board and it has been decided to fix the conflict with libc in the next release (with Olivier's help). So Bruce and me decided to use cmdline function in the meantime.