From: Lijun Ou <oulijun@huawei.com>
To: <wenzhuo.lu@intel.com>, <beilei.xing@intel.com>,
<adrien.mazarguil@6wind.com>, <ferruh.yigit@intel.com>
Cc: <dev@dpdk.org>, <linuxarm@huawei.com>
Subject: [dpdk-dev] [PATCH v4] app/testpmd: fix the default RSS key configuration
Date: Thu, 24 Sep 2020 21:45:05 +0800 [thread overview]
Message-ID: <1600955105-53176-2-git-send-email-oulijun@huawei.com> (raw)
In-Reply-To: <1600955105-53176-1-git-send-email-oulijun@huawei.com>
It use the NIC valid default RSS key instead of the testpmd
dummy RSS key in the flow configuration when the RSS key is
not specified in the flow rule. If the NIC RSS key is
invalid, it will use testpmd dummy RSS key as the default
key.
Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API")
Cc: stable@dpdk.org
Signed-off-by: Lijun Ou <oulijun@huawei.com>
---
V3->V4:
-fix checkpatch warning and shorter commit content.
V2->V3:
-fix checkpatch warning.
V1->V2:
-fix the commit.
---
app/test-pmd/cmdline_flow.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 6263d30..e6648da 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -4312,6 +4312,7 @@ parse_vc_action_rss(struct context *ctx, const struct token *token,
action_rss_data->queue[i] = i;
if (!port_id_is_invalid(ctx->port, DISABLED_WARN) &&
ctx->port != (portid_t)RTE_PORT_ALL) {
+ struct rte_eth_rss_conf rss_conf = {0};
struct rte_eth_dev_info info;
int ret2;
@@ -4322,6 +4323,13 @@ parse_vc_action_rss(struct context *ctx, const struct token *token,
action_rss_data->conf.key_len =
RTE_MIN(sizeof(action_rss_data->key),
info.hash_key_size);
+
+ rss_conf.rss_key_len = sizeof(action_rss_data->key);
+ rss_conf.rss_key = action_rss_data->key;
+ ret2 = rte_eth_dev_rss_hash_conf_get(ctx->port, &rss_conf);
+ if (ret2 != 0)
+ return ret2;
+ action_rss_data->conf.key = rss_conf.rss_key;
}
action->conf = &action_rss_data->conf;
return ret;
--
2.7.4
next prev parent reply other threads:[~2020-09-24 13:47 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-10 1:51 [dpdk-dev] [PATCH v3] " Lijun Ou
2020-09-22 9:51 ` Phil Yang
2020-09-22 13:50 ` oulijun
2020-09-22 15:44 ` Phil Yang
2020-09-24 13:45 ` [dpdk-dev] [PATCH v4] RSS key use with testpmd Lijun Ou
2020-09-24 13:45 ` Lijun Ou [this message]
2020-09-29 15:35 ` [dpdk-dev] [PATCH v4] app/testpmd: fix the default RSS key configuration Phil Yang
2020-09-30 12:57 ` Ferruh Yigit
2020-10-09 11:55 ` oulijun
2020-10-09 18:27 ` Ferruh Yigit
2020-10-09 18:54 ` Ferruh Yigit
2020-09-30 13:36 ` Ferruh Yigit
2020-10-09 11:59 ` oulijun
2020-10-09 18:36 ` Ferruh Yigit
2020-10-15 12:41 ` [dpdk-dev] [PATCH v5] " Lijun Ou
2020-10-15 13:52 ` Ferruh Yigit
2020-10-15 14:04 ` oulijun
2020-10-15 14:43 ` Ferruh Yigit
2020-10-15 16:05 ` Ferruh Yigit
2020-10-15 23:21 ` Ophir Munk
2020-10-15 23:53 ` Ferruh Yigit
2020-10-16 0:14 ` Ajit Khaparde
2020-10-16 6:46 ` Ophir Munk
2020-10-16 10:05 ` oulijun
2020-10-16 15:13 ` Ophir Munk
2020-10-16 10:04 ` oulijun
2020-10-16 10:57 ` Ferruh Yigit
2020-10-16 14:59 ` Ophir Munk
2020-10-20 9:00 ` oulijun
2020-10-20 10:02 ` Ferruh Yigit
2020-10-20 13:35 ` oulijun
2020-10-20 14:34 ` Ferruh Yigit
2020-10-21 8:19 ` oulijun
2020-10-21 9:38 ` Ferruh Yigit
2020-10-21 10:07 ` oulijun
[not found] ` <20201015195637.26476-1-robot@bytheb.org>
2020-10-16 9:39 ` [dpdk-dev] |WARNING| pw80899 " oulijun
2020-10-16 9:41 ` David Marchand
2020-09-30 13:17 ` [dpdk-dev] [PATCH v4] RSS key use with testpmd Ferruh Yigit
2020-10-09 12:09 ` oulijun
2020-10-09 18:52 ` Ferruh Yigit
2020-10-10 3:07 ` Phil Yang
2020-10-14 6:15 ` oulijun
2020-10-14 8:41 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1600955105-53176-2-git-send-email-oulijun@huawei.com \
--to=oulijun@huawei.com \
--cc=adrien.mazarguil@6wind.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=linuxarm@huawei.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).