From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas.monjalon@6wind.com>
Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com
 [209.85.212.174]) by dpdk.org (Postfix) with ESMTP id E10C4C310
 for <dev@dpdk.org>; Mon, 20 Apr 2015 14:45:56 +0200 (CEST)
Received: by wizk4 with SMTP id k4so97647584wiz.1
 for <dev@dpdk.org>; Mon, 20 Apr 2015 05:45:56 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:organization
 :user-agent:in-reply-to:references:mime-version
 :content-transfer-encoding:content-type;
 bh=A7Ecp6iyw44zu5xDrs13c56aLB42h9vyBlqh7cRPUyQ=;
 b=B8PDOQojrbLTnjlu4oC8rxyv/rv+AzXJaQMHl7OEugK9IJ6iL5aRrewVEGMAfUClxf
 iSF2To6sspUKXTvF4T52uvoLkY8Uirms9Kt8yNlWdFbbh6rRAmYXt12vRn98Oqi/U0lr
 iKEoAl+JhDLc7LHjXW+3K6wiE9MM57wzSqrW7XKVNfQQF/b+MqYSNNeuTKnM2/2rUyeu
 BeoUVQdjC1iHUjLew/+XBDkjObh5fp3zoITyluwGmI6xziBZ/HbSOV8EALAwzkt+fMJw
 ZBPqYCWyDa4SxtpiKeMJkPeX2NIugVWnMnnKvPE2LsW87QPcdFB5F4PPjfekD9L7hKvP
 kdWg==
X-Gm-Message-State: ALoCoQmYZLCwlBEgYwga9dMaSNoB8iFx0bMnt66xxo4NDNJl1bpP7O6yk27IPE10aZhKpc4mglWi
X-Received: by 10.194.184.10 with SMTP id eq10mr31093047wjc.147.1429533956801; 
 Mon, 20 Apr 2015 05:45:56 -0700 (PDT)
Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136])
 by mx.google.com with ESMTPSA id n3sm15457930wix.1.2015.04.20.05.45.55
 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
 Mon, 20 Apr 2015 05:45:55 -0700 (PDT)
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: dev@dpdk.org
Date: Mon, 20 Apr 2015 14:45:12 +0200
Message-ID: <1602194.3mSZX90Ns8@xps13>
Organization: 6WIND
User-Agent: KMail/4.14.4 (Linux/3.18.4-1-ARCH; KDE/4.14.4; x86_64; ; )
In-Reply-To: <553365CD.5070407@cloudius-systems.com>
References: <1429130956-17828-1-git-send-email-thomas.monjalon@6wind.com>
 <1429222237-8002-2-git-send-email-thomas.monjalon@6wind.com>
 <553365CD.5070407@cloudius-systems.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH v3 2/2] use simple zero initializers
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Mon, 20 Apr 2015 12:45:57 -0000

> > To initialize a structure with zeros, one field was explicitly set
> > to avoid "missing initializer" bug with old GCC (e.g. 4.4).
> > This warning is now disabled (commit <insertlater>) for old versions of GCC,
> > so the workarounds may be removed.
> >
> > These initializers should not be needed for static variables but they
> > are still used to workaround an ICC bug (see commit b2595c4aa92d).
> >
> > There is one remaining exception where {0} initializer doesn't work cleanly,
> > even with recent GCC:
> > lib/librte_pmd_ixgbe/ixgbe_rxtx_vec.c:735:9:
> > error: missing braces around initializer [-Werror=missing-braces]
> >    struct rte_mbuf mb_def = {0}; /* zeroed mbuf */
> >
> > Tested with gcc-4.4.7 (CentOS), gcc-4.7.2 (Debian), gcc-4.9.2 (Arch),
> > clang-3.6.0 and icc-13.1.1.
> >
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > Tested-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> > Tested-by: John McNamara <john.mcnamara@intel.com>
> 
> Acked-by: Vlad Zolotarov <vladz@cloudius-systems.com>

Applied, thanks