From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Wiles, Roger Keith" <keith.wiles@windriver.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] Clang compile error with RTE_LIBRTE_MEMPOOL_DEBUG enabled.
Date: Wed, 01 Oct 2014 14:58:05 +0200 [thread overview]
Message-ID: <1602501.e1dujvioa1@xps13> (raw)
In-Reply-To: <3EC8A7DC-C947-40DC-B8FD-60023A12B00A@windriver.com>
2014-09-28 05:30, Wiles, Roger Keith:
> When enabling RTE_LIBRTE_MEMPOOL_DEBUG and compiling with clang
> compiler an error occurs, because ifdefed code now includes GCC pragmas.
>
> GCC 4.4 is when push_options and pop_options pragma show up.
>
> Signed-off-by: Keith Wiles <keith.wiles@windriver.com>
[...]
> -#ifndef __INTEL_COMPILER
> +#if (__GNUC__ > 4) || ((__GNUC__ == 4) && (__GNUC_MINOR__ >= 4))
> #pragma GCC push_options
> #pragma GCC diagnostic ignored "-Wcast-qual"
> #endif
Does clang accept const casting with -Wcast-qual?
I'd prefer to use the same logic as in rte_mempool.c:
#pragma GCC diagnostic ignored "-Wcast-qual"
#pragma GCC diagnostic error "-Wcast-qual"
without using push/pop.
Or if push/pop is really needed, it is implemented in clang:
http://clang.llvm.org/docs/UsersManual.html#controlling-diagnostics-via-pragmas
--
Thomas
next prev parent reply other threads:[~2014-10-01 12:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-27 5:53 [dpdk-dev] [PATCH] " Wiles, Roger Keith
2014-09-28 1:08 ` Wiles, Roger Keith
2014-09-28 5:30 ` [dpdk-dev] [PATCH v2] " Wiles, Roger Keith
2014-10-01 12:58 ` Thomas Monjalon [this message]
2014-10-01 14:57 ` Wiles, Roger Keith
2014-10-01 17:06 ` Wiles, Roger Keith
2014-10-01 17:11 ` [dpdk-dev] [PATCH v3] " Wiles, Roger Keith
2014-10-02 22:22 ` Wiles, Roger Keith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1602501.e1dujvioa1@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).