From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56C5CA04B6; Mon, 12 Oct 2020 20:40:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F35191D97C; Mon, 12 Oct 2020 20:40:49 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 55EA51D972 for ; Mon, 12 Oct 2020 20:40:47 +0200 (CEST) IronPort-SDR: 9hQXF8Hml1TIErHwvLhEMZzYlmyZ05dQbosrgPShuBuKj46qYULsev5VcUb6UmQx7cEoqoUW1h Box10jeJza1w== X-IronPort-AV: E=McAfee;i="6000,8403,9772"; a="152716044" X-IronPort-AV: E=Sophos;i="5.77,367,1596524400"; d="scan'208";a="152716044" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Oct 2020 11:40:44 -0700 IronPort-SDR: gz8TbClwEa65QRe/kZLvOtLPS1DwQxTKyq9G7icA8URhjWzZW1+iQ0QiMj5UDX6CMitd/QQRXL WgyNBNNuWeNA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,367,1596524400"; d="scan'208";a="530074613" Received: from txasoft-yocto.an.intel.com ([10.123.72.192]) by orsmga005.jf.intel.com with ESMTP; 12 Oct 2020 11:40:43 -0700 From: Timothy McDaniel To: Jerin Jacob , Ray Kinsella , Neil Horman Cc: dev@dpdk.org, erik.g.carrillo@intel.com, gage.eads@intel.com, harry.van.haaren@intel.com Date: Mon, 12 Oct 2020 13:42:49 -0500 Message-Id: <1602528169-14356-1-git-send-email-timothy.mcdaniel@intel.com> X-Mailer: git-send-email 1.7.10 In-Reply-To: <1599843867-28048-1-git-send-email-timothy.mcdaniel@intel.com> References: <1599843867-28048-1-git-send-email-timothy.mcdaniel@intel.com> Subject: [dpdk-dev] [PATCH] eventdev: add PCI probe named convenience function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Add new internal wrapper function for use by pci drivers as a .probe function to attach to an event interface. Same as rte_event_pmd_pci_probe, except the caller can specify the name. Updated rte_event_pmd_pci_probe so as to not duplicate code. Signed-off-by: Timothy McDaniel --- lib/librte_eventdev/rte_eventdev_pmd_pci.h | 45 ++++++++++++++++++++-------- lib/librte_eventdev/rte_eventdev_version.map | 1 + 2 files changed, 33 insertions(+), 13 deletions(-) diff --git a/lib/librte_eventdev/rte_eventdev_pmd_pci.h b/lib/librte_eventdev/rte_eventdev_pmd_pci.h index a3f9244..4c215f7 100644 --- a/lib/librte_eventdev/rte_eventdev_pmd_pci.h +++ b/lib/librte_eventdev/rte_eventdev_pmd_pci.h @@ -32,28 +32,24 @@ typedef int (*eventdev_pmd_pci_callback_t)(struct rte_eventdev *dev); /** * @internal - * Wrapper for use by pci drivers as a .probe function to attach to a event - * interface. + * Wrapper for use by pci drivers as a .probe function to attach to an event + * interface. Same as rte_event_pmd_pci_probe, except caller can specify + * the name. */ static inline int -rte_event_pmd_pci_probe(struct rte_pci_driver *pci_drv, - struct rte_pci_device *pci_dev, - size_t private_data_size, - eventdev_pmd_pci_callback_t devinit) +rte_event_pmd_pci_probe_named(struct rte_pci_driver *pci_drv, + struct rte_pci_device *pci_dev, + size_t private_data_size, + eventdev_pmd_pci_callback_t devinit, + const char *name) { struct rte_eventdev *eventdev; - - char eventdev_name[RTE_EVENTDEV_NAME_MAX_LEN]; - int retval; if (devinit == NULL) return -EINVAL; - rte_pci_device_name(&pci_dev->addr, eventdev_name, - sizeof(eventdev_name)); - - eventdev = rte_event_pmd_allocate(eventdev_name, + eventdev = rte_event_pmd_allocate(name, pci_dev->device.numa_node); if (eventdev == NULL) return -ENOMEM; @@ -90,6 +86,29 @@ rte_event_pmd_pci_probe(struct rte_pci_driver *pci_drv, /** * @internal + * Wrapper for use by pci drivers as a .probe function to attach to a event + * interface. + */ +static inline int +rte_event_pmd_pci_probe(struct rte_pci_driver *pci_drv, + struct rte_pci_device *pci_dev, + size_t private_data_size, + eventdev_pmd_pci_callback_t devinit) +{ + char eventdev_name[RTE_EVENTDEV_NAME_MAX_LEN]; + + rte_pci_device_name(&pci_dev->addr, eventdev_name, + sizeof(eventdev_name)); + + return rte_event_pmd_pci_probe_named(pci_drv, + pci_dev, + private_data_size, + devinit, + eventdev_name); +} + +/** + * @internal * Wrapper for use by pci drivers as a .remove function to detach a event * interface. */ diff --git a/lib/librte_eventdev/rte_eventdev_version.map b/lib/librte_eventdev/rte_eventdev_version.map index 2846d04..88fb2bd 100644 --- a/lib/librte_eventdev/rte_eventdev_version.map +++ b/lib/librte_eventdev/rte_eventdev_version.map @@ -57,6 +57,7 @@ DPDK_21 { rte_event_eth_tx_adapter_stop; rte_event_pmd_allocate; rte_event_pmd_pci_probe; + rte_event_pmd_pci_probe_named; rte_event_pmd_pci_remove; rte_event_pmd_release; rte_event_pmd_vdev_init; -- 2.6.4