From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCEF2A04C0; Tue, 13 Oct 2020 15:50:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CB0B61DBDE; Tue, 13 Oct 2020 15:46:25 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 8CE401DB76 for ; Tue, 13 Oct 2020 15:46:04 +0200 (CEST) Received: from mx1-us1.ppe-hosted.com (unknown [10.110.50.144]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 2DBA1200CE for ; Tue, 13 Oct 2020 13:46:03 +0000 (UTC) Received: from us4-mdac16-75.at1.mdlocal (unknown [10.110.50.193]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 2B223800A9 for ; Tue, 13 Oct 2020 13:46:03 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.110.50.7]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id AC22C4007B for ; Tue, 13 Oct 2020 13:46:02 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 768DC4C0066 for ; Tue, 13 Oct 2020 13:46:02 +0000 (UTC) Received: from ukex01.SolarFlarecom.com (10.17.10.4) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 13 Oct 2020 14:45:56 +0100 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Tue, 13 Oct 2020 14:45:56 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 09DDjua7006116 for ; Tue, 13 Oct 2020 14:45:56 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id A99671613A9 for ; Tue, 13 Oct 2020 14:45:56 +0100 (BST) From: Andrew Rybchenko To: Date: Tue, 13 Oct 2020 14:45:44 +0100 Message-ID: <1602596753-32282-28-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1602596753-32282-1-git-send-email-arybchenko@solarflare.com> References: <1602596753-32282-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.6.1012-25722.003 X-TM-AS-Result: No-1.102700-8.000000-10 X-TMASE-MatchedRID: b602RmutDtG2zoyRglahHEf49ONH0RaSUHV7v8X++rkOkJQR4QWbsLsn APikIQ0U2XHJ0L4jOIQs/31GzKkTsVPnI9A/227jA9lly13c/gEn8jQhMLowhcj0QMA/92m2qXA FsS+trPLi8zVgXoAltsIJ+4gwXrEtWBd6ltyXuvvt1VQaAnI+OKg+17CYs/L35avHv6aQi6khsI fiialKskwRdo8+TqgKWeXxPCUCYwpP/AgRkKkqbrJPtZeKZ4sQ4loVUZLitaWqFrt9xUgp+uq+T 0IcdvQ1BtPt5WQTZkLauEQaIW46K4YinWuMIb+iftwZ3X11IV0= X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10-1.102700-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.6.1012-25722.003 X-MDID: 1602596763-WZQGEQU_LXIQ X-PPE-DISP: 1602596763;WZQGEQU_LXIQ Subject: [dpdk-dev] [PATCH 27/36] common/sfc_efx/base: simplify to request Rx prefix fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Introduce an extra variable with required Rx prefix fields mask to make it easier to request more fields. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/rhead_rx.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/common/sfc_efx/base/rhead_rx.c b/drivers/common/sfc_efx/base/rhead_rx.c index d683f280ce..d3d7339b8c 100644 --- a/drivers/common/sfc_efx/base/rhead_rx.c +++ b/drivers/common/sfc_efx/base/rhead_rx.c @@ -594,6 +594,7 @@ rhead_rx_qcreate( const efx_nic_cfg_t *encp = efx_nic_cfg_get(enp); efx_mcdi_init_rxq_params_t params; efx_rx_prefix_layout_t erpl; + uint32_t fields_mask = 0; efx_rc_t rc; _NOTE(ARGUNUSED(id)) @@ -631,8 +632,8 @@ rhead_rx_qcreate( * which fields are required or may be allow to request so-called * default Rx prefix (which ID is equal to 0). */ - if ((rc = rhead_rx_choose_prefix_id(enp, - (1U << EFX_RX_PREFIX_FIELD_LENGTH), &erpl)) != 0) + fields_mask |= 1U << EFX_RX_PREFIX_FIELD_LENGTH; + if ((rc = rhead_rx_choose_prefix_id(enp, fields_mask, &erpl)) != 0) goto fail3; params.prefix_id = erpl.erpl_id; -- 2.17.1