From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id E0628A04DD;
Tue, 20 Oct 2020 10:52:41 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 616E8BC08;
Tue, 20 Oct 2020 10:49:20 +0200 (CEST)
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
[148.163.129.52]) by dpdk.org (Postfix) with ESMTP id BCADDAD3C
for <dev@dpdk.org>; Tue, 20 Oct 2020 10:49:00 +0200 (CEST)
Received: from mx1-us1.ppe-hosted.com (unknown [10.7.65.64])
by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id
4D7C960055 for <dev@dpdk.org>; Tue, 20 Oct 2020 08:48:59 +0000 (UTC)
Received: from us4-mdac16-6.ut7.mdlocal (unknown [10.7.65.74])
by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 4BA602009B
for <dev@dpdk.org>; Tue, 20 Oct 2020 08:48:59 +0000 (UTC)
X-Virus-Scanned: Proofpoint Essentials engine
Received: from mx1-us1.ppe-hosted.com (unknown [10.7.65.200])
by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id C6A5622004D
for <dev@dpdk.org>; Tue, 20 Oct 2020 08:48:58 +0000 (UTC)
Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))
(No client certificate requested)
by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 7D8E7800058
for <dev@dpdk.org>; Tue, 20 Oct 2020 08:48:58 +0000 (UTC)
Received: from ukex01.SolarFlarecom.com (10.17.10.4) by
ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id
15.0.1497.2; Tue, 20 Oct 2020 09:48:50 +0100
Received: from opal.uk.solarflarecom.com (10.17.10.1) by
ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id
15.0.1497.2 via Frontend Transport; Tue, 20 Oct 2020 09:48:50 +0100
Received: from ukv-loginhost.uk.solarflarecom.com
(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])
by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 09K8mnWD030802;
Tue, 20 Oct 2020 09:48:49 +0100
Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])
by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 1DA98161711;
Tue, 20 Oct 2020 09:48:48 +0100 (BST)
From: Andrew Rybchenko <arybchenko@solarflare.com>
To: <y@solarflare.com>
CC: <dev@dpdk.org>, Ivan Malov <ivan.malov@oktetlabs.ru>
Date: Tue, 20 Oct 2020 09:47:35 +0100
Message-ID: <1603183709-23420-9-git-send-email-arybchenko@solarflare.com>
X-Mailer: git-send-email 1.8.3.1
In-Reply-To: <1603183709-23420-1-git-send-email-arybchenko@solarflare.com>
References: <1603183709-23420-1-git-send-email-arybchenko@solarflare.com>
MIME-Version: 1.0
Content-Type: text/plain
X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.6.1012-25736.003
X-TM-AS-Result: No-1.924100-8.000000-10
X-TMASE-MatchedRID: joDPjHIAhMJEJxhN6FUHdZCYtcHXhxbamdrHMkUHHq/6dwaYkcj1la+X
0GkMw17YkpsU2cOjMqFVwC6U6YW0/7a6/BliGsjAsFkCLeeufNvBknKaYrutknCR0itW3xfVXY5
FfQHz6pNPV+yNmYX6rOb1L/R4hBRv6jHbEaTIvGE/ApMPW/xhXquVOrDvB8LT27KSseGDg90nOW
hZYy8qHbltJQY4FJPn6ahUvNzUOyf75cEN6/qvTNE+Q9UKuqQnfS0Ip2eEHnz3IzXlXlpamPoLR
4+zsDTts9zZIznkhZN/443wofcQYQOw9otiz8Zv5YKFwFZCQFQ5zzZy99DD9JsAYX4P7xdXnTix
+p0hrY28vlyc3kHB2ZqEEgaXNh1SO9tPIm6/FPXaQLtLC8aUqEPBvsmCWGHWUWQ7Bol0IqC+I8S
pxyUS3FXK9tOD+u6c
X-TM-AS-User-Approved-Sender: Yes
X-TM-AS-User-Blocked-Sender: No
X-TMASE-Result: 10-1.924100-8.000000
X-TMASE-Version: SMEX-12.5.0.1300-8.6.1012-25736.003
X-MDID: 1603183739-s_244kqazvbM
X-PPE-DISP: 1603183739;s_244kqazvbM
Subject: [dpdk-dev] [PATCH 08/62] common/sfc_efx/base: add match spec
init/fini APIs
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
From: Ivan Malov <ivan.malov@oktetlabs.ru>
An MAE rule is a function of match criteria and a priority. The said match
criteria have to be provided using "mask-value pairs" packing format which
on its own should not be exposed to client drivers. The latter have to use
a functional interface of sorts in order to generate a match specification.
Define an EFX match specification and implement initialise / finalise APIs.
The "mask-value pairs" buffer itself is not used in this particular patch,
so the corresponding struct member will be added in the follow-up patch.
Signed-off-by: Ivan Malov <ivan.malov@oktetlabs.ru>
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
Reviewed-by: Andy Moreton <amoreton@xilinx.com>
---
drivers/common/sfc_efx/base/efx.h | 22 +++++++++
drivers/common/sfc_efx/base/efx_impl.h | 9 ++++
drivers/common/sfc_efx/base/efx_mae.c | 46 +++++++++++++++++++
.../sfc_efx/rte_common_sfc_efx_version.map | 2 +
4 files changed, 79 insertions(+)
diff --git a/drivers/common/sfc_efx/base/efx.h b/drivers/common/sfc_efx/base/efx.h
index db66be0faf..40c5968ea9 100644
--- a/drivers/common/sfc_efx/base/efx.h
+++ b/drivers/common/sfc_efx/base/efx.h
@@ -4058,6 +4058,28 @@ efx_mae_get_limits(
__in efx_nic_t *enp,
__out efx_mae_limits_t *emlp);
+typedef enum efx_mae_rule_type_e {
+ EFX_MAE_RULE_ACTION = 0,
+
+ EFX_MAE_RULE_NTYPES
+} efx_mae_rule_type_t;
+
+typedef struct efx_mae_match_spec_s efx_mae_match_spec_t;
+
+LIBEFX_API
+extern __checkReturn efx_rc_t
+efx_mae_match_spec_init(
+ __in efx_nic_t *enp,
+ __in efx_mae_rule_type_t type,
+ __in uint32_t prio,
+ __out efx_mae_match_spec_t **specp);
+
+LIBEFX_API
+extern void
+efx_mae_match_spec_fini(
+ __in efx_nic_t *enp,
+ __in efx_mae_match_spec_t *spec);
+
#endif /* EFSYS_OPT_MAE */
#ifdef __cplusplus
diff --git a/drivers/common/sfc_efx/base/efx_impl.h b/drivers/common/sfc_efx/base/efx_impl.h
index 6e9329c203..931989f17a 100644
--- a/drivers/common/sfc_efx/base/efx_impl.h
+++ b/drivers/common/sfc_efx/base/efx_impl.h
@@ -1675,6 +1675,15 @@ efx_pci_xilinx_cap_tbl_find(
#endif /* EFSYS_OPT_PCI */
+#if EFSYS_OPT_MAE
+
+struct efx_mae_match_spec_s {
+ efx_mae_rule_type_t emms_type;
+ uint32_t emms_prio;
+};
+
+#endif /* EFSYS_OPT_MAE */
+
#ifdef __cplusplus
}
#endif
diff --git a/drivers/common/sfc_efx/base/efx_mae.c b/drivers/common/sfc_efx/base/efx_mae.c
index c93342de15..b1ebc93714 100644
--- a/drivers/common/sfc_efx/base/efx_mae.c
+++ b/drivers/common/sfc_efx/base/efx_mae.c
@@ -126,4 +126,50 @@ efx_mae_get_limits(
return (rc);
}
+ __checkReturn efx_rc_t
+efx_mae_match_spec_init(
+ __in efx_nic_t *enp,
+ __in efx_mae_rule_type_t type,
+ __in uint32_t prio,
+ __out efx_mae_match_spec_t **specp)
+{
+ efx_mae_match_spec_t *spec;
+ efx_rc_t rc;
+
+ switch (type) {
+ case EFX_MAE_RULE_ACTION:
+ break;
+ default:
+ rc = ENOTSUP;
+ goto fail1;
+ }
+
+ EFSYS_KMEM_ALLOC(enp->en_esip, sizeof (*spec), spec);
+ if (spec == NULL) {
+ rc = ENOMEM;
+ goto fail2;
+ }
+
+ spec->emms_type = type;
+ spec->emms_prio = prio;
+
+ *specp = spec;
+
+ return (0);
+
+fail2:
+ EFSYS_PROBE(fail2);
+fail1:
+ EFSYS_PROBE1(fail1, efx_rc_t, rc);
+ return (rc);
+}
+
+ void
+efx_mae_match_spec_fini(
+ __in efx_nic_t *enp,
+ __in efx_mae_match_spec_t *spec)
+{
+ EFSYS_KMEM_FREE(enp->en_esip, sizeof (*spec), spec);
+}
+
#endif /* EFSYS_OPT_MAE */
diff --git a/drivers/common/sfc_efx/rte_common_sfc_efx_version.map b/drivers/common/sfc_efx/rte_common_sfc_efx_version.map
index 4b500b646a..57a6c96b3e 100644
--- a/drivers/common/sfc_efx/rte_common_sfc_efx_version.map
+++ b/drivers/common/sfc_efx/rte_common_sfc_efx_version.map
@@ -88,6 +88,8 @@ INTERNAL {
efx_mae_fini;
efx_mae_get_limits;
efx_mae_init;
+ efx_mae_match_spec_fini;
+ efx_mae_match_spec_init;
efx_mcdi_fini;
efx_mcdi_get_proxy_handle;
--
2.17.1