From: Tianfei zhang <tianfei.zhang@intel.com> To: dev@dpdk.org , rosen.xu@intel.com, qi.z.zhang@intel.com Cc: Wei Huang <wei.huang@intel.com>, stable@dpdk.org, Tianfei zhang <tianfei.zhang@intel.com> Subject: [dpdk-dev] [PATCH v3 3/5] raw/ifpga/base: fix return of IRQ unregister properly Date: Fri, 23 Oct 2020 04:59:57 -0400 Message-ID: <1603443599-7356-4-git-send-email-tianfei.zhang@intel.com> (raw) In-Reply-To: <1603443599-7356-1-git-send-email-tianfei.zhang@intel.com> From: Wei Huang <wei.huang@intel.com> Since 'rte_intr_callback_unregister()' can return positive value as success, but 'ifpga_rawdev_destroy()' handle it as an error. Instead, only negative return is treated as failure. Fixes: e0a1aafe ("raw/ifpga: introduce IRQ functions") Cc: stable@dpdk.org Signed-off-by: Wei Huang <wei.huang@intel.com> Signed-off-by: Tianfei zhang <tianfei.zhang@intel.com> --- drivers/raw/ifpga/ifpga_rawdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c index 374a7ff1d..04ca5032a 100644 --- a/drivers/raw/ifpga/ifpga_rawdev.c +++ b/drivers/raw/ifpga/ifpga_rawdev.c @@ -1564,7 +1564,7 @@ ifpga_rawdev_destroy(struct rte_pci_device *pci_dev) return -ENODEV; if (ifpga_unregister_msix_irq(IFPGA_FME_IRQ, 0, - fme_interrupt_handler, mgr)) + fme_interrupt_handler, mgr) < 0) return -EINVAL; opae_adapter_data_free(adapter->data); -- 2.17.1
next prev parent reply other threads:[~2020-10-23 10:01 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-23 7:30 [dpdk-dev] [PATCH v4 0/4] raw/ifpga/base: An inprovement for multi-process Tianfei zhang 2020-09-23 7:30 ` [dpdk-dev] [PATCH v4 1/4] raw/ifpga/base: fix bug in IRQ functions Tianfei zhang 2020-09-23 7:30 ` [dpdk-dev] [PATCH v4 2/4] raw/ifpga/base: free resources when destroying ifpga device Tianfei zhang 2020-09-23 7:30 ` [dpdk-dev] [PATCH v4 3/4] raw/ifpga/base: cleanup ifpga raw devices when process quit Tianfei zhang 2020-09-23 7:30 ` [dpdk-dev] [PATCH v4 4/4] raw/ifpga/base: enhance driver reliablity in multi-process Tianfei zhang 2020-09-28 1:40 ` [dpdk-dev] [PATCH v2 0/4] raw/ifpga/base: An improvement for multi-process Tianfei zhang 2020-09-28 1:40 ` [dpdk-dev] [PATCH v2 1/4] raw/ifpga/base: fix bug in IRQ functions Tianfei zhang 2020-09-29 1:42 ` Xu, Rosen 2020-10-14 9:59 ` Zhang, Tianfei 2020-10-15 13:14 ` Zhang, Qi Z 2020-10-15 18:56 ` Ferruh Yigit 2020-10-16 5:46 ` Zhang, Tianfei 2020-09-28 1:40 ` [dpdk-dev] [PATCH v2 2/4] raw/ifpga/base: free resources when destroying ifpga device Tianfei zhang 2020-09-29 1:42 ` Xu, Rosen 2020-10-15 13:15 ` Zhang, Qi Z 2020-10-15 18:57 ` Ferruh Yigit 2020-10-16 5:51 ` Zhang, Tianfei 2020-09-28 1:40 ` [dpdk-dev] [PATCH v2 3/4] raw/ifpga/base: cleanup ifpga raw devices when process quit Tianfei zhang 2020-09-29 1:43 ` Xu, Rosen 2020-10-15 13:15 ` Zhang, Qi Z 2020-10-15 18:57 ` Ferruh Yigit 2020-10-16 5:54 ` Zhang, Tianfei 2020-09-28 1:40 ` [dpdk-dev] [PATCH v2 4/4] raw/ifpga/base: enhance driver reliability in multi-process Tianfei zhang 2020-10-15 6:08 ` Xu, Rosen 2020-10-15 13:16 ` Zhang, Qi Z 2020-10-23 8:59 ` [dpdk-dev] [PATCH v3 0/5] raw/ifpga/base: An improvement for multi-process Tianfei zhang 2020-10-23 8:59 ` [dpdk-dev] [PATCH v3 1/5] raw/ifpga/base: fix interrupt handler instance usage Tianfei zhang 2020-10-23 8:59 ` [dpdk-dev] [PATCH v3 2/5] raw/ifpga/base: handle unsupported interrupt type Tianfei zhang 2020-10-23 8:59 ` Tianfei zhang [this message] 2020-10-23 8:59 ` [dpdk-dev] [PATCH v3 4/5] raw/ifpga/base: free resources when destroying ifpga device Tianfei zhang 2020-10-23 8:59 ` [dpdk-dev] [PATCH v3 5/5] raw/ifpga/base: enhance driver reliablity in multi-process Tianfei zhang 2020-10-26 1:04 ` [dpdk-dev] [PATCH v3 0/5] raw/ifpga/base: An improvement for multi-process Zhang, Qi Z 2020-10-23 9:06 ` Tianfei zhang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1603443599-7356-4-git-send-email-tianfei.zhang@intel.com \ --to=tianfei.zhang@intel.com \ --cc=dev@dpdk.org \ --cc=stable@dpdk.org \ --cc=wei.huang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git