From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D3908A04DD; Fri, 23 Oct 2020 20:38:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EA4286883; Fri, 23 Oct 2020 20:30:45 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 29F0A5A93 for ; Fri, 23 Oct 2020 20:30:40 +0200 (CEST) IronPort-SDR: hPbE0RFZYDy5cp3+ueFD0fKPCA10V3yLl/KpjS2xcWmv61k9kK28Bps/IVRmVl30GHBojeiZgh s0RSf4BlOCgg== X-IronPort-AV: E=McAfee;i="6000,8403,9783"; a="167837620" X-IronPort-AV: E=Sophos;i="5.77,409,1596524400"; d="scan'208";a="167837620" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Oct 2020 11:30:39 -0700 IronPort-SDR: atPuGGpfGjtWSxmhuidlymZOm6zm42LIFoG0NUrUxUBVe71IHsHzvm05Aad0lWS2lQkIf8Olo7 K4gcPSm8sGZw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,409,1596524400"; d="scan'208";a="534500517" Received: from txasoft-yocto.an.intel.com ([10.123.72.192]) by orsmga005.jf.intel.com with ESMTP; 23 Oct 2020 11:30:38 -0700 From: Timothy McDaniel To: Cc: dev@dpdk.org, erik.g.carrillo@intel.com, gage.eads@intel.com, harry.van.haaren@intel.com, jerinj@marvell.com Date: Fri, 23 Oct 2020 13:32:09 -0500 Message-Id: <1603477952-583-1-git-send-email-timothy.mcdaniel@intel.com> X-Mailer: git-send-email 1.7.10 In-Reply-To: <1596138614-17409-2-git-send-email-timothy.mcdaniel@intel.com> References: <1596138614-17409-2-git-send-email-timothy.mcdaniel@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] =?utf-8?q?=5BPATCH_v6_00/23=5D_Add_DLB_PMD?= X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The following patch series adds support for a new eventdev PMD. The DLB PMD adds support for the Intel Dynamic Load Balancer (DLB) hardware. The DLB is a PCIe device that provides load-balanced, prioritized scheduling of core-to-core communication. The device consists of queues and arbiters that connect producer and consumer cores, and implements load-balanced queueing features including: - Lock-free multi-producer/multi-consumer operation. - Multiple priority levels for varying traffic types. - 'Direct' traffic (i.e. multi-producer/single-consumer) - Simple unordered load-balanced distribution. - Atomic lock-free load balancing across multiple consumers. - Queue element reordering feature allowing ordered load-balanced distribution. The DLB hardware supports both load balanced and directed ports and queues. Unlike other eventdev devices already in the repo, not all DLB ports and queues are equally capable. In particular, directed ports are limited to a single link, and must be connected to a directed queue. Additionally, even though LDB ports may link multiple queues, the number of queues that may be linked is limited by hardware. Another difference is that DLB does not have a straightforward way of carrying the flow_id in the queue elements (QE) that the hardware operates on. While reviewing the code, please be aware that this PMD has full control over the DLB hardware. Intel will be extending the DLB PMD in the future (not as part of this first series) with a mode that we refer to as the bifurcated PMD. The bifurcated PMD communicates with a kernel driver to configure the device, ports, and queues, and memory maps device MMIO so datapath operations occur purely in user-space. The framework to support both the PF PMD and bifurcated PMD exists in this patchset, and is why the iface.[ch] layer is present. Major changes in v6 after dpdk reviews: ===================== - fixed meson conditional build. Moved test into driver’s meson.build file instead of event/meson.build - documentation is populated as associated code is introduced - add log_register in add dynamic logging patch - rename RTE_xxx symbol(s) as DLB2_xxx - replaced function ptr enqueue_four with direct call to movdir64b - remove unused port_pages - broke up probe patch into 3 smaller patches for easier review - changed param order of movdir64b/movntdq to match intrinsics - added self to MAINTAINERS files - squashed announcement of availability into last patch in series - correct spelling errors and delete repeated words - DPDK_21.0 -> DPDK 21 in map file - add experimental banner to public structs and APIs - implemented other suggestions from code reviews of DLB2 PMD. The software is very similar in form so some DLB2 reviews comments were applicable to DLB as well Major changes in v5 after dpdk reviews and additional internal reviews by colleagues at Intel: ================ - implement changes requested in code reviews by Gage Eads and Mike Chen - fix a memzone leak - convert to use eal rte-cpuflags patch from Liang Ma Major changes in v4 after dpdk reviews and additional internal reviews by colleagues at Intel: ================ - Remove make infrastructure - shared code (pf/base) is now added incrementally - flexible interface (iface.[ch]) is now added incrementally - removed calls to rte_panic - do not call pthread_create directly - remove unused internal API, os_time - convert rte_atomic to __atomic builtins - broke out eventdev ABI changes, test/api changes, and new internal PCI named probe API - relocated enqueue logic to enqueue patch Major Changes in V3: ================ - Fixed a memory corruption issue due to not allocating enough CQ memory for depths < 8. Hardware requires minimum allocation to be at least 8 entries. - Address review comments from Gage and Mattias. - Remove versioning - minor formatting changes Major changes in V2: ================ - Correct ABI break that was present in V1. - Address some of the review comments received from Mattias. I will address the remaining items identified by Mattias in the next patch delivery. - General code cleanup based on internal code reviews Depends-on: patch-79539 ("eal: add new x86 cpuid support for WAITPKG") Timothy McDaniel (23): event/dlb: add documentation and meson infrastructure event/dlb: add dynamic logging event/dlb: add private data structures and constants event/dlb: add definitions shared with LKM or shared code event/dlb: add inline functions event/dlb: add eventdev probe event/dlb: add flexible interface event/dlb: add probe-time hardware init event/dlb: add xstats event/dlb: add infos get and configure event/dlb: add queue and port default conf event/dlb: add queue setup event/dlb: add port setup event/dlb: add port link event/dlb: add port unlink and port unlinks in progress event/dlb: add eventdev start event/dlb: add enqueue and its burst variants event/dlb: add dequeue and its burst variants event/dlb: add eventdev stop and close event/dlb: add PMD's token pop public interface event/dlb: add PMD self-tests event/dlb: add queue and port release event/dlb: add timeout ticks entry point MAINTAINERS | 5 + app/test/test_eventdev.c | 7 + config/rte_config.h | 8 +- doc/api/doxy-api-index.md | 1 + doc/guides/eventdevs/dlb.rst | 341 ++ doc/guides/eventdevs/index.rst | 1 + doc/guides/rel_notes/release_20_11.rst | 5 + drivers/event/dlb/dlb.c | 4129 ++++++++++++++ drivers/event/dlb/dlb_iface.c | 79 + drivers/event/dlb/dlb_iface.h | 82 + drivers/event/dlb/dlb_inline_fns.h | 59 + drivers/event/dlb/dlb_log.h | 25 + drivers/event/dlb/dlb_priv.h | 513 ++ drivers/event/dlb/dlb_selftest.c | 1551 +++++ drivers/event/dlb/dlb_user.h | 814 +++ drivers/event/dlb/dlb_xstats.c | 1222 ++++ drivers/event/dlb/meson.build | 21 + drivers/event/dlb/pf/base/dlb_hw_types.h | 334 ++ drivers/event/dlb/pf/base/dlb_osdep.h | 310 + drivers/event/dlb/pf/base/dlb_osdep_bitmap.h | 441 ++ drivers/event/dlb/pf/base/dlb_osdep_list.h | 131 + drivers/event/dlb/pf/base/dlb_osdep_types.h | 31 + drivers/event/dlb/pf/base/dlb_regs.h | 2368 ++++++++ drivers/event/dlb/pf/base/dlb_resource.c | 6904 +++++++++++++++++++++++ drivers/event/dlb/pf/base/dlb_resource.h | 876 +++ drivers/event/dlb/pf/dlb_main.c | 586 ++ drivers/event/dlb/pf/dlb_main.h | 47 + drivers/event/dlb/pf/dlb_pf.c | 750 +++ drivers/event/dlb/rte_pmd_dlb.c | 38 + drivers/event/dlb/rte_pmd_dlb.h | 77 + drivers/event/dlb/rte_pmd_dlb_event_version.map | 9 + drivers/event/meson.build | 2 +- 32 files changed, 21765 insertions(+), 2 deletions(-) create mode 100644 doc/guides/eventdevs/dlb.rst create mode 100644 drivers/event/dlb/dlb.c create mode 100644 drivers/event/dlb/dlb_iface.c create mode 100644 drivers/event/dlb/dlb_iface.h create mode 100644 drivers/event/dlb/dlb_inline_fns.h create mode 100644 drivers/event/dlb/dlb_log.h create mode 100644 drivers/event/dlb/dlb_priv.h create mode 100644 drivers/event/dlb/dlb_selftest.c create mode 100644 drivers/event/dlb/dlb_user.h create mode 100644 drivers/event/dlb/dlb_xstats.c create mode 100644 drivers/event/dlb/meson.build create mode 100644 drivers/event/dlb/pf/base/dlb_hw_types.h create mode 100644 drivers/event/dlb/pf/base/dlb_osdep.h create mode 100644 drivers/event/dlb/pf/base/dlb_osdep_bitmap.h create mode 100644 drivers/event/dlb/pf/base/dlb_osdep_list.h create mode 100644 drivers/event/dlb/pf/base/dlb_osdep_types.h create mode 100644 drivers/event/dlb/pf/base/dlb_regs.h create mode 100644 drivers/event/dlb/pf/base/dlb_resource.c create mode 100644 drivers/event/dlb/pf/base/dlb_resource.h create mode 100644 drivers/event/dlb/pf/dlb_main.c create mode 100644 drivers/event/dlb/pf/dlb_main.h create mode 100644 drivers/event/dlb/pf/dlb_pf.c create mode 100644 drivers/event/dlb/rte_pmd_dlb.c create mode 100644 drivers/event/dlb/rte_pmd_dlb.h create mode 100644 drivers/event/dlb/rte_pmd_dlb_event_version.map -- 2.6.4