From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f175.google.com (mail-qk0-f175.google.com [209.85.220.175]) by dpdk.org (Postfix) with ESMTP id C4FAB590F for ; Thu, 13 Oct 2016 20:50:24 +0200 (CEST) Received: by mail-qk0-f175.google.com with SMTP id o68so153823372qkf.3 for ; Thu, 13 Oct 2016 11:50:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=NJDkpqr/G1NZtbYGJPKmFAC4DwA04TWIIsEVV7EzSzE=; b=b8I4kbXL5IYPLV+KFF/pwMKGWjtcTkjR5lVSkfL06sVgBXe0cLvw+EMz8GnwtbF1m4 PAah4jQB9H7SqyZ+mT40cWyd8OLTwQMNpGS8X6wE2a3RRkkIPQTid55r9Ryu4FjAIecC w1tcxhHE79GFjRnJrtwhSH5194wLHxhpZu76Ab3+/tQE7nXHaqokQDBGaip2AQmQrwTh 4Xiy7RZjSnKnTzDdyJ2a13mtaIQ9XLhKM5huML2hJLN/izrywDSfE6ioDa6nd57PAlms tH4m/EGh53bKQu/EXPwoNAo1eivGUS0IRoLefqV9cJCUj5WsTa83ImofcNOPVzSsh6Ql n1Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=NJDkpqr/G1NZtbYGJPKmFAC4DwA04TWIIsEVV7EzSzE=; b=bdBQtrqABoVL4gIA86RRyd8HHjDkre9iwYWUouQ/j/P/FySBpPJCSF8FDMSFQuaj92 OGO4jOKWhBDMos8Sl4e12c6IpkuKNKpyGhvs+7s8gHul3GZQPW3qyGgxGV49MHIW0cuW zSGn86UmRCqP3Oe3jZP8gPgTg9wfrBoA9CcQ6kiDe6awACsMVakRbKcmF/YCqJ51i2l0 /eiYaTTP8VqYbBSwDU0mjpMbYQaoWZjShDn0CKsLxSwwCQ8QI6Lz0Qt2sr8/7JJAZDJj nWIE/b28NpL2fH67UrPJliYXa0m8+Gl9oYZ5fLQz+84OXxTqEJhPlnf6CI19NcA/iFb8 9LVA== X-Gm-Message-State: AA6/9RmFO6EK7DAi2OcIxLhNowsg/N67Om8tHMkboxHwwAkZWsKr2BH6AhiCzSlF/jJ7irTJ X-Received: by 10.194.205.1 with SMTP id lc1mr3535113wjc.192.1476384624184; Thu, 13 Oct 2016 11:50:24 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id rv12sm24775832wjb.29.2016.10.13.11.50.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 13 Oct 2016 11:50:23 -0700 (PDT) From: Thomas Monjalon To: Olivier Matz Cc: Yuanhan Liu , dev@dpdk.org, konstantin.ananyev@intel.com, sugesh.chandran@intel.com, bruce.richardson@intel.com, jianfeng.tan@intel.com, helin.zhang@intel.com, adrien.mazarguil@6wind.com, stephen@networkplumber.org, dprovan@bivio.net, xiao.w.wang@intel.com, maxime.coquelin@redhat.com Date: Thu, 13 Oct 2016 20:50:22 +0200 Message-ID: <1603777.zeWNS1Z9oX@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <20161013160551.GB16751@yliu-dev.sh.intel.com> References: <1476368171-18176-1-git-send-email-olivier.matz@6wind.com> <1476368171-18176-13-git-send-email-olivier.matz@6wind.com> <20161013160551.GB16751@yliu-dev.sh.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3 12/12] net/virtio: add Tso support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Oct 2016 18:50:25 -0000 2016-10-14 00:05, Yuanhan Liu: > On Thu, Oct 13, 2016 at 04:16:11PM +0200, Olivier Matz wrote: > > +/* When doing TSO, the IP length is not included in the pseudo header > > + * checksum of the packet given to the PMD, but for virtio it is > > + * expected. > > + */ > > +static void > > +virtio_tso_fix_cksum(struct rte_mbuf *m) > > +{ > > + /* common case: header is not fragmented */ > > + if (likely(rte_pktmbuf_data_len(m) >= m->l2_len + m->l3_len + > > + m->l4_len)) { > > + struct ipv4_hdr *iph; > > + struct ipv6_hdr *ip6h; > > + struct tcp_hdr *th; > > + uint16_t prev_cksum, new_cksum, ip_len, ip_paylen; > > + uint32_t tmp; > ... > > + } else { > > As discussed just now, if you drop the else part, you could add my > ACK for the whole virtio changes, and Review-ed by for all mbuf and > other changes. > > Thoams, please pick them by youself directly: since it depends on > other patches and they will be picked (or already be picked?) by you. Applied - without TSO checksum on fragmented header - with some release notes changes - with Yuanhan acked/reviewed Thanks