* [dpdk-dev] [PATCH] common/sfc_efx/base: fix build breakage on clang 3.4.x
@ 2020-10-27 12:08 Andrew Rybchenko
2020-10-27 14:55 ` Ali Alnubani
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Rybchenko @ 2020-10-27 12:08 UTC (permalink / raw)
To: dev
Remove duplicate typedef for efx_mae_actions_t.
Fixes: 57f9eb33d32c ("common/sfc_efx/base: add action set spec init/fini APIs")
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
drivers/common/sfc_efx/base/efx_impl.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/common/sfc_efx/base/efx_impl.h b/drivers/common/sfc_efx/base/efx_impl.h
index d8423d4..ed5b872 100644
--- a/drivers/common/sfc_efx/base/efx_impl.h
+++ b/drivers/common/sfc_efx/base/efx_impl.h
@@ -1736,7 +1736,7 @@ struct efx_mae_match_spec_s {
uint16_t emavp_tci_be;
} efx_mae_action_vlan_push_t;
-typedef struct efx_mae_actions_s {
+struct efx_mae_actions_s {
/* Bitmap of actions in spec, indexed by action type */
uint32_t emass_actions;
@@ -1746,7 +1746,7 @@ struct efx_mae_match_spec_s {
EFX_MAE_VLAN_PUSH_MAX_NTAGS];
uint32_t emass_mark_value;
efx_mport_sel_t emass_deliver_mport;
-} efx_mae_actions_t;
+};
#endif /* EFSYS_OPT_MAE */
--
1.8.3.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] common/sfc_efx/base: fix build breakage on clang 3.4.x
2020-10-27 12:08 [dpdk-dev] [PATCH] common/sfc_efx/base: fix build breakage on clang 3.4.x Andrew Rybchenko
@ 2020-10-27 14:55 ` Ali Alnubani
2020-10-27 15:23 ` Andrew Rybchenko
0 siblings, 1 reply; 3+ messages in thread
From: Ali Alnubani @ 2020-10-27 14:55 UTC (permalink / raw)
To: Andrew Rybchenko, dev
Thanks Andrew.
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Andrew Rybchenko
> Sent: Tuesday, October 27, 2020 2:09 PM
> To: dev@dpdk.org
> Subject: [dpdk-dev] [PATCH] common/sfc_efx/base: fix build breakage on
> clang 3.4.x
>
> Remove duplicate typedef for efx_mae_actions_t.
>
> Fixes: 57f9eb33d32c ("common/sfc_efx/base: add action set spec init/fini
> APIs")
>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
> ---
> drivers/common/sfc_efx/base/efx_impl.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/common/sfc_efx/base/efx_impl.h
> b/drivers/common/sfc_efx/base/efx_impl.h
> index d8423d4..ed5b872 100644
> --- a/drivers/common/sfc_efx/base/efx_impl.h
> +++ b/drivers/common/sfc_efx/base/efx_impl.h
> @@ -1736,7 +1736,7 @@ struct efx_mae_match_spec_s {
> uint16_t emavp_tci_be;
> } efx_mae_action_vlan_push_t;
>
> -typedef struct efx_mae_actions_s {
> +struct efx_mae_actions_s {
> /* Bitmap of actions in spec, indexed by action type */
> uint32_t emass_actions;
>
> @@ -1746,7 +1746,7 @@ struct efx_mae_match_spec_s {
> EFX_MAE_VLAN_PUSH_MAX_NTAGS];
> uint32_t emass_mark_value;
> efx_mport_sel_t emass_deliver_mport;
> -} efx_mae_actions_t;
> +};
>
> #endif /* EFSYS_OPT_MAE */
>
> --
> 1.8.3.1
Tested-by: Ali Alnubani <alialnu@nvidia.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-dev] [PATCH] common/sfc_efx/base: fix build breakage on clang 3.4.x
2020-10-27 14:55 ` Ali Alnubani
@ 2020-10-27 15:23 ` Andrew Rybchenko
0 siblings, 0 replies; 3+ messages in thread
From: Andrew Rybchenko @ 2020-10-27 15:23 UTC (permalink / raw)
To: Ali Alnubani, dev
On 10/27/20 5:55 PM, Ali Alnubani wrote:
> Thanks Andrew.
>
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Andrew Rybchenko
>> Sent: Tuesday, October 27, 2020 2:09 PM
>> To: dev@dpdk.org
>> Subject: [dpdk-dev] [PATCH] common/sfc_efx/base: fix build breakage on
>> clang 3.4.x
>>
>> Remove duplicate typedef for efx_mae_actions_t.
>>
>> Fixes: 57f9eb33d32c ("common/sfc_efx/base: add action set spec init/fini
>> APIs")
>>
>> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
>> ---
>> drivers/common/sfc_efx/base/efx_impl.h | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/common/sfc_efx/base/efx_impl.h
>> b/drivers/common/sfc_efx/base/efx_impl.h
>> index d8423d4..ed5b872 100644
>> --- a/drivers/common/sfc_efx/base/efx_impl.h
>> +++ b/drivers/common/sfc_efx/base/efx_impl.h
>> @@ -1736,7 +1736,7 @@ struct efx_mae_match_spec_s {
>> uint16_t emavp_tci_be;
>> } efx_mae_action_vlan_push_t;
>>
>> -typedef struct efx_mae_actions_s {
>> +struct efx_mae_actions_s {
>> /* Bitmap of actions in spec, indexed by action type */
>> uint32_t emass_actions;
>>
>> @@ -1746,7 +1746,7 @@ struct efx_mae_match_spec_s {
>> EFX_MAE_VLAN_PUSH_MAX_NTAGS];
>> uint32_t emass_mark_value;
>> efx_mport_sel_t emass_deliver_mport;
>> -} efx_mae_actions_t;
>> +};
>>
>> #endif /* EFSYS_OPT_MAE */
>>
>> --
>> 1.8.3.1
>
> Tested-by: Ali Alnubani <alialnu@nvidia.com>
>
Squashed into corresponding changeset, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-27 15:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-27 12:08 [dpdk-dev] [PATCH] common/sfc_efx/base: fix build breakage on clang 3.4.x Andrew Rybchenko
2020-10-27 14:55 ` Ali Alnubani
2020-10-27 15:23 ` Andrew Rybchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).