From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id 0A254A04DD;
Tue, 27 Oct 2020 16:03:28 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 4FCC8BBBA;
Tue, 27 Oct 2020 16:00:15 +0100 (CET)
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
by dpdk.org (Postfix) with ESMTP id 24CEB6938
for <dev@dpdk.org>; Tue, 27 Oct 2020 16:00:10 +0100 (CET)
IronPort-SDR: XV59X7St2dGi+LZazJsXAtxTJcjGegqZKqomLUxti/FM5dZieSXMfhJCSgtHngnHDXiX5+rt8I
L3J0JGoB2GUw==
X-IronPort-AV: E=McAfee;i="6000,8403,9786"; a="147378712"
X-IronPort-AV: E=Sophos;i="5.77,424,1596524400"; d="scan'208";a="147378712"
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga001.fm.intel.com ([10.253.24.23])
by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
27 Oct 2020 08:00:09 -0700
IronPort-SDR: I4nz30kYh/ge8OLtFqk9JGM/zt4/U55vxox29BaNrQdqTT8AN7mNz15JLSJQV7skhHCCv7rrCX
Ow0jdaIoAA6A==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.77,424,1596524400"; d="scan'208";a="424430535"
Received: from irvmail001.ir.intel.com ([163.33.26.43])
by fmsmga001.fm.intel.com with ESMTP; 27 Oct 2020 08:00:05 -0700
Received: from sivswdev09.ir.intel.com (sivswdev09.ir.intel.com
[10.237.217.48])
by irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id
09RF04WD016046; Tue, 27 Oct 2020 15:00:04 GMT
Received: from sivswdev09.ir.intel.com (localhost [127.0.0.1])
by sivswdev09.ir.intel.com with ESMTP id 09RF04rX023085;
Tue, 27 Oct 2020 15:00:04 GMT
Received: (from lma25@localhost)
by sivswdev09.ir.intel.com with LOCAL id 09RF04jV023081;
Tue, 27 Oct 2020 15:00:04 GMT
From: Liang Ma <liang.j.ma@intel.com>
To: dev@dpdk.org
Cc: ruifeng.wang@arm.com, haiyue.wang@intel.com, bruce.richardson@intel.com,
konstantin.ananyev@intel.com, david.hunt@intel.com,
jerinjacobk@gmail.com, nhorman@tuxdriver.com, thomas@monjalon.net,
timothy.mcdaniel@intel.com, gage.eads@intel.com, mw@semihalf.com,
gtzalik@amazon.com, ajit.khaparde@broadcom.com, hkalra@marvell.com,
johndale@cisco.com, xavier.huwei@huawei.com, xuanziyang2@huawei.com,
matan@nvidia.com, yongwang@vmware.com,
Anatoly Burakov <anatoly.burakov@intel.com>
Date: Tue, 27 Oct 2020 14:59:09 +0000
Message-Id: <1603810749-22285-10-git-send-email-liang.j.ma@intel.com>
X-Mailer: git-send-email 1.7.7.4
In-Reply-To: <1603810749-22285-1-git-send-email-liang.j.ma@intel.com>
References: <1603810749-22285-1-git-send-email-liang.j.ma@intel.com>
In-Reply-To: <1603494392-7181-1-git-send-email-liang.j.ma@intel.com>
References: <1603494392-7181-1-git-send-email-liang.j.ma@intel.com>
Subject: [dpdk-dev] [PATCH v10 9/9] examples/l3fwd-power: enable PMD power
mgmt
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
Add PMD power management feature support to l3fwd-power sample app.
Signed-off-by: Liang Ma <liang.j.ma@intel.com>
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Acked-by: David Hunt <david.hunt@intel.com>
---
Notes:
v8:
- Add return status check for queue enable
v6:
- Fixed typos in documentation
---
.../sample_app_ug/l3_forward_power_man.rst | 13 ++++++
examples/l3fwd-power/main.c | 46 ++++++++++++++++++-
2 files changed, 58 insertions(+), 1 deletion(-)
diff --git a/doc/guides/sample_app_ug/l3_forward_power_man.rst b/doc/guides/sample_app_ug/l3_forward_power_man.rst
index d7e1dc5813..b10ebe662e 100644
--- a/doc/guides/sample_app_ug/l3_forward_power_man.rst
+++ b/doc/guides/sample_app_ug/l3_forward_power_man.rst
@@ -109,6 +109,8 @@ where,
* --telemetry: Telemetry mode.
+* --pmd-mgmt: PMD power management mode.
+
See :doc:`l3_forward` for details.
The L3fwd-power example reuses the L3fwd command line options.
@@ -455,3 +457,14 @@ reference cycles and accordingly busy rate is set to either 0% or
The new stats ``empty_poll`` , ``full_poll`` and ``busy_percent`` can be viewed by running the script
``/usertools/dpdk-telemetry-client.py`` and selecting the menu option ``Send for global Metrics``.
+
+PMD power management Mode
+-------------------------
+
+The PMD power management mode support for ``l3fwd-power`` is a standalone mode, in this mode
+``l3fwd-power`` does simple l3fwding along with enable the power saving scheme on specific
+port/queue/lcore. Main purpose for this mode is to demonstrate how to use the PMD power management API.
+
+.. code-block:: console
+
+ ./build/examples/dpdk-l3fwd-power -l 1-3 -- --pmd-mgmt -p 0x0f --config="(0,0,2),(0,1,3)"
diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c
index a48d75f68f..aafa415f0b 100644
--- a/examples/l3fwd-power/main.c
+++ b/examples/l3fwd-power/main.c
@@ -47,6 +47,7 @@
#include <rte_power_empty_poll.h>
#include <rte_metrics.h>
#include <rte_telemetry.h>
+#include <rte_power_pmd_mgmt.h>
#include "perf_core.h"
#include "main.h"
@@ -199,7 +200,8 @@ enum appmode {
APP_MODE_LEGACY,
APP_MODE_EMPTY_POLL,
APP_MODE_TELEMETRY,
- APP_MODE_INTERRUPT
+ APP_MODE_INTERRUPT,
+ APP_MODE_PMD_MGMT
};
enum appmode app_mode;
@@ -1750,6 +1752,7 @@ parse_ep_config(const char *q_arg)
#define CMD_LINE_OPT_EMPTY_POLL "empty-poll"
#define CMD_LINE_OPT_INTERRUPT_ONLY "interrupt-only"
#define CMD_LINE_OPT_TELEMETRY "telemetry"
+#define CMD_LINE_OPT_PMD_MGMT "pmd-mgmt"
/* Parse the argument given in the command line of the application */
static int
@@ -1771,6 +1774,7 @@ parse_args(int argc, char **argv)
{CMD_LINE_OPT_LEGACY, 0, 0, 0},
{CMD_LINE_OPT_TELEMETRY, 0, 0, 0},
{CMD_LINE_OPT_INTERRUPT_ONLY, 0, 0, 0},
+ {CMD_LINE_OPT_PMD_MGMT, 0, 0, 0},
{NULL, 0, 0, 0}
};
@@ -1881,6 +1885,16 @@ parse_args(int argc, char **argv)
printf("telemetry mode is enabled\n");
}
+ if (!strncmp(lgopts[option_index].name,
+ CMD_LINE_OPT_PMD_MGMT,
+ sizeof(CMD_LINE_OPT_PMD_MGMT))) {
+ if (app_mode != APP_MODE_DEFAULT) {
+ printf(" power mgmt mode is mutually exclusive with other modes\n");
+ return -1;
+ }
+ app_mode = APP_MODE_PMD_MGMT;
+ printf("PMD power mgmt mode is enabled\n");
+ }
if (!strncmp(lgopts[option_index].name,
CMD_LINE_OPT_INTERRUPT_ONLY,
sizeof(CMD_LINE_OPT_INTERRUPT_ONLY))) {
@@ -2437,6 +2451,8 @@ mode_to_str(enum appmode mode)
return "telemetry";
case APP_MODE_INTERRUPT:
return "interrupt-only";
+ case APP_MODE_PMD_MGMT:
+ return "pmd mgmt";
default:
return "invalid";
}
@@ -2705,6 +2721,17 @@ main(int argc, char **argv)
} else if (!check_ptype(portid))
rte_exit(EXIT_FAILURE,
"PMD can not provide needed ptypes\n");
+ if (app_mode == APP_MODE_PMD_MGMT) {
+ ret = rte_power_pmd_mgmt_queue_enable(lcore_id,
+ portid, queueid,
+ RTE_POWER_MGMT_TYPE_SCALE);
+
+ if (ret < 0)
+ rte_exit(EXIT_FAILURE,
+ "rte_power_pmd_mgmt enable: err=%d, "
+ "port=%d\n", ret, portid);
+
+ }
}
}
@@ -2790,6 +2817,9 @@ main(int argc, char **argv)
SKIP_MAIN);
} else if (app_mode == APP_MODE_INTERRUPT) {
rte_eal_mp_remote_launch(main_intr_loop, NULL, CALL_MAIN);
+ } else if (app_mode == APP_MODE_PMD_MGMT) {
+ rte_eal_mp_remote_launch(main_telemetry_loop, NULL,
+ CALL_MAIN);
}
if (app_mode == APP_MODE_EMPTY_POLL || app_mode == APP_MODE_TELEMETRY)
@@ -2816,6 +2846,20 @@ main(int argc, char **argv)
if (app_mode == APP_MODE_EMPTY_POLL)
rte_power_empty_poll_stat_free();
+ if (app_mode == APP_MODE_PMD_MGMT) {
+ for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
+ if (rte_lcore_is_enabled(lcore_id) == 0)
+ continue;
+ qconf = &lcore_conf[lcore_id];
+ for (queue = 0; queue < qconf->n_rx_queue; ++queue) {
+ portid = qconf->rx_queue_list[queue].port_id;
+ queueid = qconf->rx_queue_list[queue].queue_id;
+ rte_power_pmd_mgmt_queue_disable(lcore_id,
+ portid, queueid);
+ }
+ }
+ }
+
if ((app_mode == APP_MODE_LEGACY || app_mode == APP_MODE_EMPTY_POLL) &&
deinit_power_library())
rte_exit(EXIT_FAILURE, "deinit_power_library failed\n");
--
2.17.1