DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bing Zhao <bingz@nvidia.com>
To: viacheslavo@nvidia.com, matan@nvidia.com, orika@nvidia.com
Cc: dev@dpdk.org, rasland@nvidia.com
Subject: [dpdk-dev] [PATCH] net/mlx5: fix the flow sync flags
Date: Wed, 28 Oct 2020 20:23:52 +0800
Message-ID: <1603887832-52852-1-git-send-email-bingz@nvidia.com> (raw)

In order to synchronize the flow steering cache with hardware in DR
mode, the new function is introduced. The function needs to use both
flags of "MLX5DV_DR_DOMAIN_SYNC_FLAGS_SW/HW", or else some actions
and rules may get stuck in the work queue.

And in some old OS release with inbox driver, the enum used in the
function is not introduced yet. To resolve this, a local defined
macro is introduced. Then in Verbs mode, it will still do nothing.
In DV mode, the glue layer will return the unsupport error.

Fixes: 2e303780c17f ("net/mlx5: add flow sync API")

Signed-off-by: Bing Zhao <bingz@nvidia.com>
Acked-by: Ori Kam <orika@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
 drivers/net/mlx5/mlx5_flow.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 2cf15f0..967bf71 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -8179,6 +8179,13 @@ int mlx5_alloc_tunnel_hub(struct mlx5_dev_ctx_shared *sh)
 	return err;
+#ifndef HAVE_MLX5DV_DR
+#define MLX5_DOMAIN_SYNC_FLOW ((1 << 0) | (1 << 1))
 int rte_pmd_mlx5_sync_flow(uint16_t port_id, uint32_t domains)
 	struct rte_eth_dev *dev = &rte_eth_devices[port_id];
@@ -8187,7 +8194,7 @@ int rte_pmd_mlx5_sync_flow(uint16_t port_id, uint32_t domains)
 	struct rte_flow_attr attr = { .transfer = 0 };
 	fops = flow_get_drv_ops(flow_get_drv_type(dev, &attr));
-	ret = fops->sync_domain(dev, domains, MLX5DV_DR_DOMAIN_SYNC_FLAGS_HW);
+	ret = fops->sync_domain(dev, domains, MLX5_DOMAIN_SYNC_FLOW);
 	if (ret > 0)
 		ret = -ret;
 	return ret;

             reply	other threads:[~2020-10-28 12:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-28 12:23 Bing Zhao [this message]
2020-10-30 10:10 ` Ferruh Yigit
2020-10-30 11:05   ` Bing Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1603887832-52852-1-git-send-email-bingz@nvidia.com \
    --to=bingz@nvidia.com \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    --cc=orika@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=viacheslavo@nvidia.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git