From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id E89ABA04B5;
Thu, 29 Oct 2020 09:53:37 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id C8E48C81A;
Thu, 29 Oct 2020 09:53:36 +0100 (CET)
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
[148.163.129.52]) by dpdk.org (Postfix) with ESMTP id 7F776C818
for <dev@dpdk.org>; Thu, 29 Oct 2020 09:53:33 +0100 (CET)
Received: from mx1-us1.ppe-hosted.com (unknown [10.7.65.64])
by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id
099A460060; Thu, 29 Oct 2020 08:53:32 +0000 (UTC)
Received: from us4-mdac16-34.ut7.mdlocal (unknown [10.7.66.153])
by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 07B992009B;
Thu, 29 Oct 2020 08:53:32 +0000 (UTC)
X-Virus-Scanned: Proofpoint Essentials engine
Received: from mx1-us1.ppe-hosted.com (unknown [10.7.65.174])
by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 8729C22004D;
Thu, 29 Oct 2020 08:53:31 +0000 (UTC)
Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])
(using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))
(No client certificate requested)
by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 5EAFE1C0069;
Thu, 29 Oct 2020 08:53:28 +0000 (UTC)
Received: from ukex01.SolarFlarecom.com (10.17.10.4) by
ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id
15.0.1497.2; Thu, 29 Oct 2020 08:53:24 +0000
Received: from opal.uk.solarflarecom.com (10.17.10.1) by
ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id
15.0.1497.2 via Frontend Transport; Thu, 29 Oct 2020 08:53:24 +0000
Received: from ukv-loginhost.uk.solarflarecom.com
(ukv-loginhost.uk.solarflarecom.com [10.17.10.39])
by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 09T8rNh6028313;
Thu, 29 Oct 2020 08:53:23 GMT
Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1])
by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id 7D8431613A9;
Thu, 29 Oct 2020 08:53:23 +0000 (GMT)
From: Andrew Rybchenko <arybchenko@solarflare.com>
To: <dev@dpdk.org>
CC: Andrey Vesnovaty <andreyv@nvidia.com>, Thomas Monjalon
<thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@intel.com>, Ray Kinsella
<mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>, Ori Kam
<orika@nvidia.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Date: Thu, 29 Oct 2020 08:52:56 +0000
Message-ID: <1603961577-13264-1-git-send-email-arybchenko@solarflare.com>
X-Mailer: git-send-email 1.8.3.1
MIME-Version: 1.0
Content-Type: text/plain
X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.6.1012-25754.003
X-TM-AS-Result: No-3.503200-8.000000-10
X-TMASE-MatchedRID: WxFAWh39R1Ax6i6qKNyVGiZm6wdY+F8KE3EgF0+MVuB8vx8dQICa64E3
pfk7XdNxRVWmp4RlJdEdBpvqzcgWQTkdZrWTFzcxGUlF/M3Dxp+hp756/rM6UlMeFKd6rzCnro8
pBJkKcOpGO66u731D0o9CL1e45ag4p6uK8TOJS3Fzu6riTtYUowCm784gsJu4wCTIeJgMBBuiRZ
m5nzncN8Ye4Y7T7wB8q5QP9dOpw8NYwMQSR3qB3b6EJGSqPePTA76tPJIOKsX8Js19y6otgG7lB
X/37R4pMPwPI+4wslH1NskoGtapdM44J5N2ZNqXv1vPAPz22FmPGXEebjsPOp4iWoNdEa7ro8WM
kQWv6iXBcIE78YqRWo6HM5rqDwqtnlTHEj68e9vT4gb46wMNiUgDdEiX6Q7HSd8kGHiUSQnW/oA
VV1XP+BqEkbHnCRfVakAKUFf9Kkw8dvuNrfSpna/PZFf8iBS6hdeYev6ImzWyrFieOBrhBjzcWr
t/fwYrRcB2ZpPnVjJuI9MGG9suFpRMZUCEHkRt
X-TM-AS-User-Approved-Sender: Yes
X-TM-AS-User-Blocked-Sender: No
X-TMASE-Result: 10--3.503200-8.000000
X-TMASE-Version: SMEX-12.5.0.1300-8.6.1012-25754.003
X-MDID: 1603961612-194OUrptUoR9
X-PPE-DISP: 1603961612;194OUrptUoR9
Subject: [dpdk-dev] [PATCH] ethdev: deprecate shared counters using action
attribute
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
A new generic shared actions API may be used to create shared
counter. There is no point to keep duplicate COUNT action specific
capability to create shared counters.
Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
---
In fact, it looks like the next logical step is to remove
struct rte_flow_action_count completely since counter ID makes
sense for shared counters only. I think it will just make it
easiser to use COUNT action. Comments are welcome.
doc/guides/rel_notes/deprecation.rst | 4 ++++
lib/librte_ethdev/rte_flow.h | 6 +++++-
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 2e082499b8..4f3bac1a6d 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -138,6 +138,10 @@ Deprecation Notices
will be limited to maximum 256 queues.
Also compile time flag ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` will be removed.
+* ethdev: Attribute ``shared`` of the ``struct rte_flow_action_count``
+ is deprecated and will be removed in DPDK 21.11. Shared counters should
+ be managed using shared actions API (``rte_flow_shared_action_create`` etc).
+
* cryptodev: support for using IV with all sizes is added, J0 still can
be used but only when IV length in following structs ``rte_crypto_auth_xform``,
``rte_crypto_aead_xform`` is set to zero. When IV length is greater or equal
diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
index a8eac4deb8..2bb93d237a 100644
--- a/lib/librte_ethdev/rte_flow.h
+++ b/lib/librte_ethdev/rte_flow.h
@@ -2287,6 +2287,9 @@ struct rte_flow_query_age {
* Counters can be retrieved and reset through ``rte_flow_query()``, see
* ``struct rte_flow_query_count``.
*
+ * @deprecated Shared attribute is deprecated, use generic
+ * RTE_FLOW_ACTION_TYPE_SHARED action.
+ *
* The shared flag indicates whether the counter is unique to the flow rule the
* action is specified with, or whether it is a shared counter.
*
@@ -2299,7 +2302,8 @@ struct rte_flow_query_age {
* to all ports within that switch domain.
*/
struct rte_flow_action_count {
- uint32_t shared:1; /**< Share counter ID with other flow rules. */
+ /** @deprecated Share counter ID with other flow rules. */
+ uint32_t shared:1;
uint32_t reserved:31; /**< Reserved, must be zero. */
uint32_t id; /**< Counter ID. */
};
--
2.17.1