Re: [dpdk-dev] [PATCH v4 0/7] e1000: add rx interrupt support

[Thomas Monjalon <thomas.monjalon@6wind.com>]

2015-10-29 23:56, Yong Liu:
> This patch set will enable interrup for physical and emulated e1000 device.
> Rx queue interrupt will work with uio driver or vfio driver with msi mode.
> l3fwd-power will disable interrupt immediately when wake-up for that e1000 not
> support interrupt auto clear.
> LSC and rxq interrupt will be seperated for e1000 can only support one
> interrupt cause in the same time.

Don't you think it should be explained in a doc?
	doc/guides/nics/e1000em.rst
I'm especially confused by the need of changing an example for this PMD.
Does it mean the API behaviour must be changed?

[...]
> Marvin Liu (7):
>   e1000: add rx interrupt support
>   e1000: separate lsc and rxq interrupt disable function
>   e1000: add ethdev rxq enable and disable function
>   e1000: add rxq interrupt handler
>   e1000: check lsc and rxq not enable in the same time
>   e1000: lsc interrupt setup function only enable itself
>   l3fwd-power: disable interrupt when wake up from sleep

Announcing a support in first patch and making it work later
is a strange logic to review.

You forgot to keep the Acked-by: Cunming Liang <cunming.liang@intel.com>

Applied in this order:
	e1000: restrict link interrupt setup scope
	e1000: separate link and Rx interrupt disabling
	e1000: support Rx interrupt setup
	e1000: add Rx interrupt handler
	l3fwd-power: disable Rx interrupt when waking up
Thanks