From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
Cc: dev@dpdk.org, "Singh, Jasvinder" <jasvinder.singh@intel.com>,
"Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
"Hunt, David" <david.hunt@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 2/4] examples/ip_pipeline: fix build for x86_64 without SSE4.2
Date: Wed, 30 Mar 2016 15:58:13 +0200 [thread overview]
Message-ID: <1604259.r6MUcN1Lc0@xps13> (raw)
In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D89126479744E9@IRSMSX108.ger.corp.intel.com>
2016-03-30 13:24, Dumitrescu, Cristian:
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > The compiler cannot use _mm_crc32_u64:
> >
> > examples/ip_pipeline/pipeline/hash_func.h:165:9:
> > error: implicit declaration of function '_mm_crc32_u64' is invalid in C99
> >
> > Fixes: 947024a26df7 ("examples/ip_pipeline: rework passthrough pipeline")
> >
> > Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
[...]
> > -#if defined(__x86_64__)
> > +#if defined(__x86_64__) && defined(RTE_CPUFLAG_SSE4_2)
>
> Hi Thomas,
>
> This is not the correct fix, as RTE_CPUFLAG_SSE4_2 is a flag that can
> only be tested at run-time (as result of calling function
> rte_cpu_get_flag_enabled()), not at build-time.
Yes you're right. It is an error, the word MACHINE is missing.
The flag should be RTE_MACHINE_CPUFLAG_SSE4_2.
> The reason it appears to fix the build issue you are mentioning is the fact
> that this change results in disabling the __x86_64__ code branch.
>
> We need to revert this patch and look for a better option.
>
> What is the compiler that generates the build issue you are mentioning?
> We could not reproduce it with gcc 5 (gcc 5.3.1).
It fails with gcc-5.2.0 and clang-3.6.2 for machine "default".
next prev parent reply other threads:[~2016-03-30 14:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 6:46 [dpdk-dev] [PATCH v2 0/4] fix examples build Thomas Monjalon
2016-02-16 6:46 ` [dpdk-dev] [PATCH v2 1/4] examples/l3fwd: fix build without SSE4.1 Thomas Monjalon
2016-02-16 6:46 ` [dpdk-dev] [PATCH v2 2/4] examples/ip_pipeline: fix build for x86_64 without SSE4.2 Thomas Monjalon
2016-03-30 13:24 ` Dumitrescu, Cristian
2016-03-30 13:58 ` Thomas Monjalon [this message]
2016-03-30 13:57 ` Dumitrescu, Cristian
2016-03-30 14:06 ` Thomas Monjalon
2016-03-30 14:15 ` Dumitrescu, Cristian
2016-03-30 15:50 ` Thomas Monjalon
2016-03-30 16:31 ` Dumitrescu, Cristian
2016-03-30 18:06 ` [dpdk-dev] [PATCH] examples/ip_pipeline: fix SSE4.2 optimization branch Thomas Monjalon
2016-03-31 20:49 ` Thomas Monjalon
2016-02-16 6:46 ` [dpdk-dev] [PATCH v2 3/4] examples/ethtool: fix build Thomas Monjalon
2016-02-16 6:46 ` [dpdk-dev] [PATCH v2 4/4] examples: fix build dependencies Thomas Monjalon
2016-02-16 6:56 ` [dpdk-dev] [PATCH v2 0/4] fix examples build Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1604259.r6MUcN1Lc0@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=cristian.dumitrescu@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).