DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/mlx5: fix meter packet missing
@ 2020-11-03  8:28 Xueming Li
  2020-11-03 11:01 ` [dpdk-dev] [PATCH v1] " Xueming Li
  2020-11-10  8:50 ` [dpdk-dev] [PATCH] " Matan Azrad
  0 siblings, 2 replies; 5+ messages in thread
From: Xueming Li @ 2020-11-03  8:28 UTC (permalink / raw)
  To: Matan Azrad, Viacheslav Ovsiienko
  Cc: dev, xuemingl, Asaf Penso, suanmingm, stable

For transfer flow with meter, packet was passed without applying flow
action. The group level was multipled by 10 for group level 65531.

This patch fixes this issue by correcting suffix table group level
calculation.

Fixes: 3e8f3e51fd93 ("net/mlx5: fix meter table definitions")
Cc: suanmingm@nvidia.com
Cc: stable@dpdk.org

Signed-off-by: Xueming Li <xuemingl@nvidia.com>
---
 drivers/net/mlx5/mlx5.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
index 63d263384b..a28f30a5ab 100644
--- a/drivers/net/mlx5/mlx5.h
+++ b/drivers/net/mlx5/mlx5.h
@@ -610,9 +610,9 @@ struct mlx5_flow_tbl_resource {
 #define MLX5_FLOW_MREG_ACT_TABLE_GROUP (MLX5_MAX_TABLES - 1)
 #define MLX5_FLOW_MREG_CP_TABLE_GROUP (MLX5_MAX_TABLES - 2)
 /* Tables for metering splits should be added here. */
-#define MLX5_MAX_TABLES_EXTERNAL (MLX5_MAX_TABLES - 3)
-#define MLX5_FLOW_TABLE_LEVEL_METER (MLX5_MAX_TABLES - 4)
 #define MLX5_FLOW_TABLE_LEVEL_SUFFIX (MLX5_MAX_TABLES - 3)
+#define MLX5_FLOW_TABLE_LEVEL_METER (MLX5_MAX_TABLES - 4)
+#define MLX5_MAX_TABLES_EXTERNAL MLX5_FLOW_TABLE_LEVEL_METER
 #define MLX5_MAX_TABLES_FDB UINT16_MAX
 #define MLX5_FLOW_TABLE_FACTOR 10
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [dpdk-dev] [PATCH v1] net/mlx5: fix meter packet missing
  2020-11-03  8:28 [dpdk-dev] [PATCH] net/mlx5: fix meter packet missing Xueming Li
@ 2020-11-03 11:01 ` Xueming Li
  2020-11-10  8:38   ` Suanming Mou
  2020-11-10 11:41   ` Raslan Darawsheh
  2020-11-10  8:50 ` [dpdk-dev] [PATCH] " Matan Azrad
  1 sibling, 2 replies; 5+ messages in thread
From: Xueming Li @ 2020-11-03 11:01 UTC (permalink / raw)
  To: Matan Azrad, Viacheslav Ovsiienko
  Cc: dev, xuemingl, Asaf Penso, suanmingm, stable

For transfer flow with meter, packet was passed without applying flow
action. The group level was multiplied by 10 for group level 65531.

This patch fixes this issue by correcting suffix table group level
calculation.

Fixes: 3e8f3e51fd93 ("net/mlx5: fix meter table definitions")
Cc: suanmingm@nvidia.com
Cc: stable@dpdk.org

Signed-off-by: Xueming Li <xuemingl@nvidia.com>
---
 drivers/net/mlx5/mlx5.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h
index 63d263384b..a28f30a5ab 100644
--- a/drivers/net/mlx5/mlx5.h
+++ b/drivers/net/mlx5/mlx5.h
@@ -610,9 +610,9 @@ struct mlx5_flow_tbl_resource {
 #define MLX5_FLOW_MREG_ACT_TABLE_GROUP (MLX5_MAX_TABLES - 1)
 #define MLX5_FLOW_MREG_CP_TABLE_GROUP (MLX5_MAX_TABLES - 2)
 /* Tables for metering splits should be added here. */
-#define MLX5_MAX_TABLES_EXTERNAL (MLX5_MAX_TABLES - 3)
-#define MLX5_FLOW_TABLE_LEVEL_METER (MLX5_MAX_TABLES - 4)
 #define MLX5_FLOW_TABLE_LEVEL_SUFFIX (MLX5_MAX_TABLES - 3)
+#define MLX5_FLOW_TABLE_LEVEL_METER (MLX5_MAX_TABLES - 4)
+#define MLX5_MAX_TABLES_EXTERNAL MLX5_FLOW_TABLE_LEVEL_METER
 #define MLX5_MAX_TABLES_FDB UINT16_MAX
 #define MLX5_FLOW_TABLE_FACTOR 10
 
-- 
2.25.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH v1] net/mlx5: fix meter packet missing
  2020-11-03 11:01 ` [dpdk-dev] [PATCH v1] " Xueming Li
@ 2020-11-10  8:38   ` Suanming Mou
  2020-11-10 11:41   ` Raslan Darawsheh
  1 sibling, 0 replies; 5+ messages in thread
From: Suanming Mou @ 2020-11-10  8:38 UTC (permalink / raw)
  To: Xueming(Steven) Li, Matan Azrad, Slava Ovsiienko
  Cc: dev, Xueming(Steven) Li, Asaf Penso, stable



> -----Original Message-----
> From: Xueming Li <xuemingl@nvidia.com>
> Sent: Tuesday, November 3, 2020 7:02 PM
> To: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>
> Cc: dev@dpdk.org; Xueming(Steven) Li <xuemingl@nvidia.com>; Asaf Penso
> <asafp@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>;
> stable@dpdk.org
> Subject: [PATCH v1] net/mlx5: fix meter packet missing
> 
> For transfer flow with meter, packet was passed without applying flow action.
> The group level was multiplied by 10 for group level 65531.
> 
> This patch fixes this issue by correcting suffix table group level calculation.
> 
> Fixes: 3e8f3e51fd93 ("net/mlx5: fix meter table definitions")
> Cc: suanmingm@nvidia.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>

Reviewed-by: Suanming Mou <suanmingm@nvidia.com>
Thanks.

> ---
>  drivers/net/mlx5/mlx5.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index
> 63d263384b..a28f30a5ab 100644
> --- a/drivers/net/mlx5/mlx5.h
> +++ b/drivers/net/mlx5/mlx5.h
> @@ -610,9 +610,9 @@ struct mlx5_flow_tbl_resource {  #define
> MLX5_FLOW_MREG_ACT_TABLE_GROUP (MLX5_MAX_TABLES - 1)  #define
> MLX5_FLOW_MREG_CP_TABLE_GROUP (MLX5_MAX_TABLES - 2)
>  /* Tables for metering splits should be added here. */ -#define
> MLX5_MAX_TABLES_EXTERNAL (MLX5_MAX_TABLES - 3) -#define
> MLX5_FLOW_TABLE_LEVEL_METER (MLX5_MAX_TABLES - 4)  #define
> MLX5_FLOW_TABLE_LEVEL_SUFFIX (MLX5_MAX_TABLES - 3)
> +#define MLX5_FLOW_TABLE_LEVEL_METER (MLX5_MAX_TABLES - 4) #define
> +MLX5_MAX_TABLES_EXTERNAL MLX5_FLOW_TABLE_LEVEL_METER
>  #define MLX5_MAX_TABLES_FDB UINT16_MAX
>  #define MLX5_FLOW_TABLE_FACTOR 10
> 
> --
> 2.25.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH] net/mlx5: fix meter packet missing
  2020-11-03  8:28 [dpdk-dev] [PATCH] net/mlx5: fix meter packet missing Xueming Li
  2020-11-03 11:01 ` [dpdk-dev] [PATCH v1] " Xueming Li
@ 2020-11-10  8:50 ` Matan Azrad
  1 sibling, 0 replies; 5+ messages in thread
From: Matan Azrad @ 2020-11-10  8:50 UTC (permalink / raw)
  To: Xueming(Steven) Li, Slava Ovsiienko
  Cc: dev, Xueming(Steven) Li, Asaf Penso, Suanming Mou, stable



From: Xueming Li
> For transfer flow with meter, packet was passed without applying flow action.
> The group level was multipled by 10 for group level 65531.
> 
> This patch fixes this issue by correcting suffix table group level calculation.
> 
> Fixes: 3e8f3e51fd93 ("net/mlx5: fix meter table definitions")
> Cc: suanmingm@nvidia.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [dpdk-dev] [PATCH v1] net/mlx5: fix meter packet missing
  2020-11-03 11:01 ` [dpdk-dev] [PATCH v1] " Xueming Li
  2020-11-10  8:38   ` Suanming Mou
@ 2020-11-10 11:41   ` Raslan Darawsheh
  1 sibling, 0 replies; 5+ messages in thread
From: Raslan Darawsheh @ 2020-11-10 11:41 UTC (permalink / raw)
  To: Xueming(Steven) Li, Matan Azrad, Slava Ovsiienko
  Cc: dev, Xueming(Steven) Li, Asaf Penso, Suanming Mou, stable

Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Xueming Li
> Sent: Tuesday, November 3, 2020 1:02 PM
> To: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>
> Cc: dev@dpdk.org; Xueming(Steven) Li <xuemingl@nvidia.com>; Asaf Penso
> <asafp@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>;
> stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v1] net/mlx5: fix meter packet missing
> 
> For transfer flow with meter, packet was passed without applying flow
> action. The group level was multiplied by 10 for group level 65531.
> 
> This patch fixes this issue by correcting suffix table group level
> calculation.
> 
> Fixes: 3e8f3e51fd93 ("net/mlx5: fix meter table definitions")
> Cc: suanmingm@nvidia.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> ---
>  drivers/net/mlx5/mlx5.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-11-10 11:41 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-03  8:28 [dpdk-dev] [PATCH] net/mlx5: fix meter packet missing Xueming Li
2020-11-03 11:01 ` [dpdk-dev] [PATCH v1] " Xueming Li
2020-11-10  8:38   ` Suanming Mou
2020-11-10 11:41   ` Raslan Darawsheh
2020-11-10  8:50 ` [dpdk-dev] [PATCH] " Matan Azrad

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git