From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB2BEA04B1; Thu, 5 Nov 2020 04:06:12 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EE07F5AB3; Thu, 5 Nov 2020 04:05:53 +0100 (CET) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id A5652592C; Thu, 5 Nov 2020 04:05:49 +0100 (CET) IronPort-SDR: QDhruU7cx+hDzQMmc5ZLsWt1ehiJjHJy3s5OKryvWv9FLGV3svnlBju71XYLnW2VPzHz69ymIb eg1AcQfSrJkA== X-IronPort-AV: E=McAfee;i="6000,8403,9795"; a="165811403" X-IronPort-AV: E=Sophos;i="5.77,452,1596524400"; d="scan'208";a="165811403" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Nov 2020 19:05:37 -0800 IronPort-SDR: Kg+6zOJZA5dhhPZ1OZcuQBdz7Ahvetwxq0AgC/e7gAFISjmZltySE6RJe9lUrwRNrxg63M0KuO LOf5U7An+f4w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,452,1596524400"; d="scan'208";a="471470858" Received: from unknown (HELO sh_lab5_1.sh.intel.com) ([10.238.175.190]) by orsmga004.jf.intel.com with ESMTP; 04 Nov 2020 19:05:36 -0800 From: Wei Huang To: dev@dpdk.org, rosen.xu@intel.com, qi.z.zhang@intel.com Cc: stable@dpdk.org, Wei Huang Date: Wed, 4 Nov 2020 21:05:39 -0500 Message-Id: <1604541940-5994-2-git-send-email-wei.huang@intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1604541940-5994-1-git-send-email-wei.huang@intel.com> References: <1604541940-5994-1-git-send-email-wei.huang@intel.com> Subject: [dpdk-dev] [PATCH v2 1/2] raw/ifpga/base: unlock mutex when nios init fail X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In fme_nios_spi_init(), a mutex is locked for protecting nios initialization process, the mutex is only unlocked when process is successful, it should also be unlocked when process fail. Fixes: e41856b515ce ("raw/ifpga/base: enhance driver reliability in multi-process") Coverity issue: 363751 Signed-off-by: Wei Huang --- drivers/raw/ifpga/base/ifpga_fme.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/raw/ifpga/base/ifpga_fme.c b/drivers/raw/ifpga/base/ifpga_fme.c index 540bb1110..f29ff3159 100644 --- a/drivers/raw/ifpga/base/ifpga_fme.c +++ b/drivers/raw/ifpga/base/ifpga_fme.c @@ -1115,6 +1115,8 @@ static int fme_nios_spi_init(struct ifpga_feature *feature) ret = nios_spi_wait_init_done(spi_master); if (ret != 0) { dev_err(fme, "FME NIOS_SPI init fail\n"); + if (spi_master->mutex) + pthread_mutex_unlock(spi_master->mutex); goto release_dev; } -- 2.29.2